akkartik/techmeet.love - Change ZOEN6BOH444OEFJLT4FBRCVPMF7JTOXLLJ2TEQCQBVSGVTDIIYWQC

bugfix: page-up

Before this commit it was scrolling up too much. Like, 2 screens up instead of 1.

This commit seems like a follow-up to commits dabb7a6c4 and a9a8d5c17. I'm not analyzing it too much, just focusing on this location after some debug logs.

Those commits should probably have noticed the missing symmetric keystroke. But I'm probably ignoring similar concerns in dealing with this so superficially.

Created by Kartik K. Agaram on June 15, 2023

ZOEN6BOH444OEFJLT4FBRCVPMF7JTOXLLJ2TEQCQBVSGVTDIIYWQC

Dependencies

In channels

main

Change contents

Replacement in text.lua at line 410 [5.1]
∅:D[3.434] → [4.3:25]
∅:D[6.1145] → [4.3:25]
∅:D[7.2605] → [4.3:25]
B:BD[8.74] → [4.3:25]
```
--?   print('pageup')
```
[3.434]
[8.74]
```
--?   print_and_log(('Text.pageup %d,%d'):format(State.screen_top1.line, State.screen_top1.pos))
```
Deletion in text.lua at line 413 [5.1]
∅:D[9.139] → [8.152:183]
∅:D[3.485] → [8.152:183]
∅:D[10.749] → [8.152:183]
∅:D[7.2662] → [8.152:183]
∅:D[11.66327] → [8.152:183]
B:BD[8.152] → [8.152:183]
```
--?   print(App.screen.height)
```
Deletion in text.lua at line 415 [5.1]
∅:D[7.2746] → [4.26:89]
∅:D[12.16711] → [4.26:89]
∅:D[11.66425] → [4.26:89]
B:BD[13.1366] → [4.26:89]
```
--?     print(y, top2.line, top2.screen_line, top2.screen_pos)
```

Insertion in text.lua at line 424 [5.1]

[10.858]

[14.175]

--? 	print_and_log(('Text.pageup B %d,%d'):format(State.screen_top1.line, State.screen_top1.pos))

Replacement in text.lua at line 427 [5.1]
∅:D[3.621] → [7.3221:3319]
∅:D[10.956] → [7.3221:3319]
B:BD[15.93] → [7.3221:3319]
∅:D[7.3319] → [4.90:116]
∅:D[11.67131] → [4.90:116]
B:BD[8.857] → [4.90:116]
```
--?   print(State.cursor1.line, State.cursor1.pos, State.screen_top1.line, State.screen_top1.pos)
--?   print('pageup end')
```
[3.621]
[16.83]
```
--? 	print_and_log(('Text.pageup C %d,%d'):format(State.screen_top1.line, State.screen_top1.pos))
```

Insertion in run.lua at line 843 [18.178044]

[17.1181]

[2.17]

--?             print_and_log(('run.keychord_press A %s %d,%d'):format(chord, Display_settings.x, Display_settings.y))

Replacement in run.lua at line 846 [18.178044]

B:BD[2.114] → [2.114:195]

            elseif chord == 'backspace' or chord == 'up' or chord == 'left' then

[2.114]

[19.405]

            elseif chord == 'backspace' or chord == 'up' or chord == 'left' or chord == 'pageup' then

Insertion in run.lua at line 852 [18.178044]

[20.901]

[19.553]

--?             print_and_log(('run.keychord_press Z %s %d,%d'):format(chord, Display_settings.x, Display_settings.y))

bugfix: page-up

Dependencies

In channels

Change contents

Replacement in text.lua at line 410 [5.1]

Deletion in text.lua at line 413 [5.1]

Deletion in text.lua at line 415 [5.1]

Insertion in text.lua at line 424 [5.1]

Replacement in text.lua at line 427 [5.1]

Insertion in run.lua at line 843 [18.178044]

Replacement in run.lua at line 846 [18.178044]

Insertion in run.lua at line 852 [18.178044]