akkartik/template-carousel-mobile - Change GGWAHCLEUEJ3PVMPZVYVLAAA3ANWSPWGIBOGQEOUP2L6QU2ERUHQC

minor cleanup and a todo for later

Created by Kartik K. Agaram on April 1, 2023

GGWAHCLEUEJ3PVMPZVYVLAAA3ANWSPWGIBOGQEOUP2L6QU2ERUHQC

Dependencies

In channels

main

Change contents

Replacement in undo.lua at line 64 [4.1]

B:BD[4.1624] → [4.1624:1687]

      table.insert(event.lines, {mode='text', data=line.data})

[4.1624]

[4.1687]

      table.insert(event.lines, {mode='text', data=line.data})  -- I've forgotten: should we deepcopy(line.data)?

Replacement in undo.lua at line 66 [4.1]

B:BD[4.1726] → [4.1726:1978]

B:BD[4.1978] → [2.1:239]

      local points=deepcopy(line.points)
--?       print('copying', line.points, 'with', #line.points, 'points into', points)
      local shapes=deepcopy(line.shapes)
--?       print('copying', line.shapes, 'with', #line.shapes, 'shapes into', shapes)
      table.insert(event.lines, {mode='drawing', h=line.h, points=points, shapes=shapes, pending={}})
--?       table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})

[4.1726]

[4.2236]

      table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})

Replacement in source_undo.lua at line 64 [6.5]

B:BD[5.1590] → [3.5:68]

      table.insert(event.lines, {mode='text', data=line.data})

[5.1590]

[5.1671]

      table.insert(event.lines, {mode='text', data=line.data})  -- I've forgotten: should we deepcopy(line.data)?

Replacement in source_undo.lua at line 66 [6.5]

B:BD[5.1710] → [5.1710:2200]

      local points=deepcopy(line.points)
--?       print('copying', line.points, 'with', #line.points, 'points into', points)
      local shapes=deepcopy(line.shapes)
--?       print('copying', line.shapes, 'with', #line.shapes, 'shapes into', shapes)
      table.insert(event.lines, {mode='drawing', h=line.h, points=points, shapes=shapes, pending={}})
--?       table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})

[5.1710]

[5.2200]

      table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})