clarify a misleading test

akkartik

Dec 6, 2024, 7:26 PM

26V2B2QH4WGLYKQULOIDIQ3K3OU22X4RUIQZVFSZEYCMJDLUYTGQC

Dependencies

• [2] 656FM555 bugfix: clear selection when clicking above or below lines
• [3] GDAWPFAV more streamlined test names
• [4] SGMA5JLE save the list of tests in repo
• [5] LF7BWEG4 group all editor globals
• [6] UHB4GARJ left/right margin -> left/right coordinates
• [7] Y2ZIPXEM new test
• [8] H3ECRBXF bugfix: clicking on empty lines
• [9] KKMFQDR4 editing source code from within the app
• [10] ORRSP7FV deduce test names on failures
• [11] APYPFFS3 call edit rather than App callbacks in tests
• [12] KOTNETIM repeat changes on source editor
• [13] A26EOZSC tweak wording in test list
• [*] LXTTOB33 extract a couple of files

Change contents

• replacement in text_tests.lua at line 322
  [2.280]→[2.280:318](∅→∅)
  − function test_click_below_all_lines()
  [2.280]

  [2.318]
  + function test_click_below_final_line_of_file()
• replacement in text_tests.lua at line 334
  [2.791]→[2.791:816](∅→∅),[2.816]→[3.2279:2330](∅→∅),[3.473]→[3.2279:2330](∅→∅)
  − -- cursor doesn't move

  − check_eq(Editor_state.cursor1.line, 1, 'cursor')
  [2.791]

  [2.817]
  + -- cursor goes to bottom

  + check_eq(Editor_state.cursor1.line, 1, 'cursor:line')

  + check_eq(Editor_state.cursor1.pos, 4, 'cursor:pos')
• replacement in text_tests at line 26
  [3.746]→[2.945:981](∅→∅)
  − click below final line does nothing
  [3.746]

  [3.746]
  + click below final line of file
• replacement in source_text_tests.lua at line 322
  [2.1264]→[2.1264:1302](∅→∅)
  − function test_click_below_all_lines()
  [2.1264]

  [2.1302]
  + function test_click_below_final_line_of_file()
• replacement in source_text_tests.lua at line 334
  [2.1775]→[2.1775:1800](∅→∅),[2.1800]→[3.25645:25696](∅→∅),[3.16198]→[3.25645:25696](∅→∅)
  − -- cursor doesn't move

  − check_eq(Editor_state.cursor1.line, 1, 'cursor')
  [2.1775]

  [2.1801]
  + -- cursor goes to bottom

  + check_eq(Editor_state.cursor1.line, 1, 'cursor:line')

  + check_eq(Editor_state.cursor1.pos, 4, 'cursor:pos')