minor cleanup and a todo for later
[?]
Apr 2, 2023, 12:34 AM
GGWAHCLEUEJ3PVMPZVYVLAAA3ANWSPWGIBOGQEOUP2L6QU2ERUHQCDependencies
- [2]
IFTYOERMline.y -> line_cache.starty in a few more places - [3]
FUOURDEYclean up some final bifold code - [4]
VJ77YABHmore efficient undo/redo - [5]
73OCE2MCafter much struggle, a brute-force undo - [6]
KKMFQDR4editing source code from within the app - [7]
OI4FPFINsupport drawings in the source editor - [8]
LF7BWEG4group all editor globals - [9]
MTJEVRJRadd state arg to a few functions
Change contents
- replacement in undo.lua at line 64
table.insert(event.lines, {mode='text', data=line.data})table.insert(event.lines, {mode='text', data=line.data}) -- I've forgotten: should we deepcopy(line.data)? - replacement in undo.lua at line 66
local points=deepcopy(line.points)--? print('copying', line.points, 'with', #line.points, 'points into', points)local shapes=deepcopy(line.shapes)--? print('copying', line.shapes, 'with', #line.shapes, 'shapes into', shapes)table.insert(event.lines, {mode='drawing', h=line.h, points=points, shapes=shapes, pending={}})--? table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}}) - replacement in source_undo.lua at line 64
table.insert(event.lines, {mode='text', data=line.data})table.insert(event.lines, {mode='text', data=line.data}) -- I've forgotten: should we deepcopy(line.data)? - replacement in source_undo.lua at line 66
local points=deepcopy(line.points)--? print('copying', line.points, 'with', #line.points, 'points into', points)local shapes=deepcopy(line.shapes)--? print('copying', line.shapes, 'with', #line.shapes, 'shapes into', shapes)table.insert(event.lines, {mode='drawing', h=line.h, points=points, shapes=shapes, pending={}})--? table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})table.insert(event.lines, {mode='drawing', h=line.h, points=deepcopy(line.points), shapes=deepcopy(line.shapes), pending={}})