akkartik/broadsheet.love - Change 3XQROLSKN5GIROYOSBN2OW2DSG34PKDU4BGYV7DL6F3V5RNSHATQC

redo version checks yet again

I'm starting to feel better after replacing 1 line with 20 and 2 new bits of global state. I'm now handling two scenarios more explicitly:

If I change Current_app within key_press, the corresponding text_input and key_release events go to the new app. If it's an editor it might insert the key, which is undesirable. Putting such handlers in key_release now feels overly clever, particularly since it took me forever to realize why I was getting stuck in an infinite loop.
Both 'run' and 'source' can hit the version check, so we need to be able to transition from the 'error' app to either. Which necessitates yet another global bit of state: Next_app.

Created by akkartik on December 7, 2023

3XQROLSKN5GIROYOSBN2OW2DSG34PKDU4BGYV7DL6F3V5RNSHATQC

Dependencies

In channels

main

Change contents

Insertion in main.lua at line 92 [5.2]

[4.414]

[3.299]


  -- Another weird bit for a class of corner cases. E.g.:
  -- * I press ctrl+e, switch Current_app. I don't want the new app to receive
  --   text_input and key_release events.
  -- If I try to avoid text_input events by switching modes on key_release, I
  -- hit a new problem:
  -- * I press ctrl+e, am running an untested version, Current_app goes to
  --   'error', and immediately rolls back out of 'error' in the key_release
  --   event.
  -- Skip_rest_of_key_events is ugly, but feels cleaner than creating yet
  -- another possible value for Current_app.
  Skip_rest_of_key_events = nil
  -- Where to go from 'error' app.
  Next_app = nil

Deletion in main.lua at line 111 [5.2]
B:BD[3.401] → [3.401:432]
```
    Unsupported_version = true
```

Deletion in main.lua at line 113 [5.2]

B:BD[3.596] → [3.596:602]

∅:D[4.414] → [6.1047:1052]

∅:D[3.602] → [6.1047:1052]

∅:D[7.86064] → [6.1047:1052]

∅:D[8.187113] → [6.1047:1052]

B:BD[6.1047] → [6.1047:1052]

B:BD[6.1052] → [3.603:1005]

  end
end
function App.love_version_check()
  if Unsupported_version then
    Current_app = 'error'
    Error_message = ("This app hasn't been tested with LÖVE version %s; please switch to version %s if you run into issues. Press any key to continue."):format(Version, Supported_versions[1])
    print(Error_message)
    -- continue initializing everything; hopefully we won't have errors during initialization

Insertion in main.lua at line 130 [5.2]
[8.187329]
[6.1139]
```
  check_love_version()
```

Insertion in main.lua at line 134 [5.2]

[9.1320]

[8.187382]

function check_love_version()
  if array.find(Supported_versions, Version) == nil then
    Next_app = Current_app
    Current_app = 'error'
    Error_message = ("This app hasn't been tested with LÖVE version %s; please switch to version %s if you run into issues. Press any key to continue."):format(Version, Supported_versions[1])
    -- continue initializing everything; hopefully we won't have errors during initialization
  end
end

Insertion in main.lua at line 144 [5.2]
[8.187407]
[8.187407]
```
  if Current_app == 'error' then return end
```
Deletion in main.lua at line 149 [5.2]
B:BD[8.187568] → [2.114:151]
```
  elseif Current_app == 'error' then
```
Insertion in main.lua at line 156 [5.2]
[8.187701]
[8.187701]
```
  if Current_app == 'error' then return end
```
Deletion in main.lua at line 161 [5.2]
B:BD[10.4536] → [2.152:189]
```
  elseif Current_app == 'error' then
```
Insertion in main.lua at line 167 [5.2]
[8.188032]
[8.188032]
```
  if Current_app == 'error' then return end
```
Deletion in main.lua at line 175 [5.2]
B:BD[8.188255] → [2.190:227]
```
  elseif Current_app == 'error' then
```
Insertion in main.lua at line 197 [5.2]
[4.521]
[11.148]
```
  if Current_app == 'error' then return end
```
Deletion in main.lua at line 207 [5.2]
B:BD[8.188606] → [2.368:405]
```
  elseif Current_app == 'error' then
```
Insertion in main.lua at line 218 [5.2]
[8.188858]
[12.1044]
```
  Skip_rest_of_key_events = nil
```

Insertion in main.lua at line 222 [5.2]

[12.1154]

    else
      Current_app = Next_app
      Next_app = nil
      Skip_rest_of_key_events = true

Insertion in main.lua at line 253 [5.2]
[8.189585]
[8.189585]
```
    Skip_rest_of_key_events = true
```
Insertion in main.lua at line 272 [5.2]
[8.189951]
[8.189951]
```
  if Skip_rest_of_key_events then return end
```
Insertion in main.lua at line 283 [5.2]
[13.57]
[8.190224]
```
  if Current_app == 'error' then return end
```

Replacement in main.lua at line 289 [5.2]

B:BD[8.190302] → [14.20:53]

B:BD[14.53] → [14.53:77]

B:BD[14.77] → [14.77:112]

  if Current_app == 'error' then
    Current_app = 'run'
  elseif Current_app == 'run' then

[8.190302]

[13.58]

  if Skip_rest_of_key_events then return end
  if Current_app == 'run' then

Deletion in app.lua at line 15 [15.2]

B:BD[8.209821] → [3.1064:1197]

  App.love_version_check()  -- hack: we want to run this just the first time and not every time we bounce between 'run' and 'source'

Replacement in Manual_tests.md at line 33 [16.1]

B:BD[8.211526] → [3.1779:1971]

* run with an untested version. Error message pops up. Press a key. Text editor comes up, and doesn't receive the key. Press ctrl+e. Source editor opens up. Press ctrl+e. Text editor returns.

[8.211526]

[3.1971]

* run with an untested version. Error message pops up. Press a key. Text editor comes up, and doesn't receive the key. Press ctrl+e. Error pops up. Press a key. Source editor opens up. Press ctrl+e. Error pops up. Press a key. Text editor returns.

redo version checks yet again

Dependencies

In channels

Change contents

Insertion in main.lua at line 92 [5.2]

Deletion in main.lua at line 111 [5.2]

Deletion in main.lua at line 113 [5.2]

Insertion in main.lua at line 130 [5.2]

Insertion in main.lua at line 134 [5.2]

Insertion in main.lua at line 144 [5.2]

Deletion in main.lua at line 149 [5.2]

Insertion in main.lua at line 156 [5.2]

Deletion in main.lua at line 161 [5.2]

Insertion in main.lua at line 167 [5.2]

Deletion in main.lua at line 175 [5.2]

Insertion in main.lua at line 197 [5.2]

Deletion in main.lua at line 207 [5.2]

Insertion in main.lua at line 218 [5.2]

Insertion in main.lua at line 222 [5.2]

Insertion in main.lua at line 253 [5.2]

Insertion in main.lua at line 272 [5.2]

Insertion in main.lua at line 283 [5.2]

Replacement in main.lua at line 289 [5.2]

Deletion in app.lua at line 15 [15.2]

Replacement in Manual_tests.md at line 33 [16.1]