don't hide errors when driver.love connects

akkartik

Nov 17, 2023, 7:23 AM

IRUOJEU5EN245A2W6E445HCGBS2V7EWWKPIGLX237X5P65ST2EXQC

Dependencies

• [2] K7ABD3WD attempt at better error recovery
• [3] UCFXFH6C send a response when deleting a definition
• [4] 7EICPXK2 don't tolerate Lua comments when parsing commands
• [5] 4XBR6CLD be robust to leading whitespace
• [6] LZDP7K7X include Current_time in reference
• [7] TNRO6KLZ new live app
• [8] Y2K3ID34 ignore comments when selecting buffer name
• [9] JUTECG5X bring template-live's protocol in sync with template-live-editor
• [10] BXXTVMBQ better organization of errors
• [*] AJLUO3UI generalize the protocol to return errors, etc.

Change contents

• replacement in main.lua at line 123
  [5.4531]→[5.4531:4550](∅→∅),[5.4550]→[2.594:613](∅→∅)
  − app.run(buf)

  − Mode = 'run'
  [5.4531]

  [5.1]
  + local possibly_mutated = app.run(buf)

  + if possibly_mutated then

  + Mode = 'run'

  + end
• replacement in main.lua at line 181
  [5.5713]→[5.5713:5754](∅→∅)
  − -- define or undefine top-level bindings
  [5.5713]

  [5.5754]
  + -- returns true if we might have mutated the app, by either creating or deleting a definition
• edit in main.lua at line 207
  [3.21]

  [5.6577]
  + return true
• edit in main.lua at line 235
  [4.152]

  [4.152]
  + if definition_name == nil then

  + -- contents are all Lua comments; we don't currently have a plan for them

  + app.send('ERROR empty definition')

  + return

  + end
• edit in main.lua at line 261
  [12.20]

  [5.7608]
  + return true