akkartik/view.love - Change 4FTOQOPZLSWHIQ45X6BTMJ5RXP6NIOOYYYRBCXVMDADSTSJD4P6AC

bugfix #2 in search UI

Created by akkartik on October 29, 2024

4FTOQOPZLSWHIQ45X6BTMJ5RXP6NIOOYYYRBCXVMDADSTSJD4P6AC

Dependencies

In channels

main

Change contents

Insertion in text_tests.lua at line 2083 [3.2]

[2.271]

  Editor_state.screen_top1 = {line=1, pos=1}
  edit.draw(Editor_state)
  -- search for empty string
  edit.run_after_keychord(Editor_state, 'C-f', 'f')
  edit.run_after_keychord(Editor_state, 'down', 'down')
  -- no crash
end
function test_search_downwards_from_final_pos_of_line()
  App.screen.init{width=120, height=60}
  Editor_state = edit.initialize_test_state()
  Editor_state.lines = load_array{'abc', 'def', 'ghi'}
  Text.redraw_all(Editor_state)
  Editor_state.cursor1 = {line=1, pos=3}

Insertion in source_text_tests.lua at line 2083 [4.3498]

[2.768]

  Editor_state.screen_top1 = {line=1, pos=1}
  edit.draw(Editor_state)
  -- search for empty string
  edit.run_after_keychord(Editor_state, 'C-f', 'f')
  edit.run_after_keychord(Editor_state, 'down', 'down')
  -- no crash
end
function test_search_downwards_from_final_pos_of_line()
  App.screen.init{width=120, height=60}
  Editor_state = edit.initialize_test_state()
  Editor_state.lines = load_array{'abc', 'def', 'ghi'}
  Text.redraw_all(Editor_state)
  Editor_state.cursor1 = {line=1, pos=3}

Replacement in source_edit.lua at line 435 [4.152440]

B:BD[4.158906] → [2.1974:2049]

∅:D[2.2049] → [4.159057:159087]

∅:D[5.7269] → [4.159057:159087]

B:BD[4.159057] → [4.159057:159087]

      edit.put_cursor_on_next_text_loc_wrapping_around_if_necessary(State)
      Text.search_next(State)

[4.158906]

[4.159087]

      if #State.search_term > 0 then
        edit.put_cursor_on_next_text_loc_wrapping_around_if_necessary(State)
        Text.search_next(State)
      end

Replacement in source_edit.lua at line 440 [4.152440]

B:BD[4.159117] → [4.159117:159151]

      Text.search_previous(State)

[4.159117]

[4.159151]

      if #State.search_term > 0 then
        Text.search_previous(State)
      end

Insertion in search.lua at line 20 [3.48846]
[6.39]
[7.721]
```
  assert(#State.search_term > 0)
```
Insertion in search.lua at line 75 [3.48846]
[6.1072]
[8.761]
```
  assert(#State.search_term > 0)
```

Replacement in edit.lua at line 429 [9.413]

B:BD[9.11621] → [2.2890:2965]

∅:D[2.2965] → [6.2118:2148]

B:BD[10.7537] → [6.2118:2148]

      edit.put_cursor_on_next_text_loc_wrapping_around_if_necessary(State)
      Text.search_next(State)

[9.11621]

[9.11680]

      if #State.search_term > 0 then
        edit.put_cursor_on_next_text_loc_wrapping_around_if_necessary(State)
        Text.search_next(State)
      end

Replacement in edit.lua at line 434 [9.413]

B:BD[9.11710] → [6.2149:2183]

      Text.search_previous(State)

[9.11710]

[9.11739]

      if #State.search_term > 0 then
        Text.search_previous(State)
      end