akkartik/view.love - Change QJISOCHJGOGK4PTD4IGOBKBU2KMEXJZJCTBL6Y2ZNDVQ2WNR7N4AC

some temporary logging to catch a bug

The bug has been spotted twice:

In snap.love, I selected text in one node, then another, and hit: Error: text.lua:789: attempt to compare nil with number stack traceback: text.lua:789: in function 'lt1' select.lua:19: in function 'clip_selection' text.lua:32: in function 'draw' edit.lua:117: in function 'draw' [string "REPL"]:21: in function 'draw' main.lua:152: in function 'draw' app.lua:102: in function <app.lua:84> [C]: in function 'xpcall' app.lua:112: in function <app.lua:111> [C]: in function 'xpcall'

Couldn't reproduce.

In text.love, inscript selected all text in a small buffer and then clicked outside the text. And got:

Error: text.lua:784: attempt to compare nil with number Traceback [love "callbacks.lua"]:228: in function 'handler' text.lua:784: in function 'lt1' select.lua:19: in function 'clip_selection' text.lua:27: in function 'draw' edit.lua:117: in function 'draw' run.lua:136: in function 'draw' main.lua:148: in function 'draw' app.lua:42: in function <app.lua:22> [C]: in function 'xpcall'

This is reproducible, and also across forks.

Created by Kartik K. Agaram on June 1, 2023

QJISOCHJGOGK4PTD4IGOBKBU2KMEXJZJCTBL6Y2ZNDVQ2WNR7N4AC

Dependencies

In channels

main

Change contents

Insertion in select.lua at line 11 [5.43980]
[4.655]
[4.655]
```
  print_and_log('text.clip_selection')
```

Insertion in select.lua at line 14 [5.43980]

[4.772]

[5.44653]

  print_and_log(('text.clip_selection: one end from selection: %d,%d'):format(minl,minp))

Insertion in select.lua at line 18 [5.43980]

[6.4046]

[5.44737]

    print_and_log(('text.clip_selection: other end from mouse: %d,%d'):format(maxl,maxp))

Insertion in select.lua at line 21 [5.43980]

[4.878]

[5.44785]

    print_and_log(('text.clip_selection: other end from cursor: %d,%d'):format(maxl,maxp))

Insertion in run.lua at line 51 [7.178044]
[7.179346]
[7.179346]
```
function print_and_log(s)
  print(s)
  log(3, s)
end
```

Replacement in edit.lua at line 226 [9.413]

B:BD[8.4581] → [3.84:125]

--?   print('press', State.cursor1.line)

[8.4581]

[10.15]

  print_and_log(('edit.mouse_press: cursor at %d,%d').format(State.cursor1.line, State.cursor1.pos))

Insertion in edit.lua at line 244 [9.413]

[11.5449]

[8.4792]

        print_and_log(('edit.mouse_press: in line %d').format(line_index))

Replacement in edit.lua at line 252 [9.413]

B:BD[9.7962] → [8.5068:5144]

--?         print('selection', State.selection1.line, State.selection1.pos)

[9.7962]

[9.8026]

        print_and_log(('edit.mouse_press: selection now %d,%d').format(State.selection1.line, State.selection1.pos))

Replacement in edit.lua at line 270 [9.413]

B:BD[8.5338] → [3.126:169]

--?   print('release', State.cursor1.line)

[8.5338]

[8.5339]

  print_and_log(('edit.mouse_release: cursor at %d,%d').format(State.cursor1.line, State.cursor1.pos))

Insertion in edit.lua at line 279 [9.413]

[9.8804]

[8.5479]

    print_and_log('edit.mouse_release: no current drawing')

Replacement in edit.lua at line 283 [9.413]
∅:D[12.165] → [9.8966:9005]
∅:D[13.258] → [9.8966:9005]
∅:D[8.5626] → [9.8966:9005]
∅:D[14.6573] → [9.8966:9005]
∅:D[15.22831] → [9.8966:9005]
∅:D[16.101439] → [9.8966:9005]
B:BD[9.8966] → [9.8966:9005]
```
--?           print('reset selection')
```
[13.258]
[8.5627]
```
          print_and_log(('edit.mouse_release: in line %d').format(line_index))
```

Replacement in edit.lua at line 288 [9.413]

B:BD[9.9165] → [8.5764:5833]

--?           print('cursor', State.cursor1.line, State.cursor1.pos)

[9.9165]

[8.5833]

          print_and_log(('edit.mouse_release: cursor now %d,%d').format(State.cursor1.line, State.cursor1.pos))

Replacement in edit.lua at line 304 [9.413]

B:BD[9.9624] → [8.6203:6276]

--?     print('selection:', State.selection1.line, State.selection1.pos)

[9.9624]

[2.1864]

    print_and_log(('edit.mouse_release: finally selection %s,%s cursor %d,%d').format(tostring(State.selection1.line), tostring(State.selection1.pos), State.cursor1.line, State.cursor1.pos))