akkartik/view.love - Change VDFARWQXPIQUTVRFLZ6QOYSG2ON7CLQVKRHJJZZAEMO7QLTNXXHQC

remove some support for long lines from source editor

A code editor is unlikely to need support for extremely long lines. And that kind of scroll is jarring anyway in a code editor. We don't read code like a novel, and less scroll per page implies more scrolling work.

I'd gotten rid of this functionality and the test for it [1] back in the spokecone fork, but only took out the test when first pulling it into the source editor.

[1] test_pagedown_often_shows_start_of_wrapping_line

Created by Kartik K. Agaram on April 20, 2023

VDFARWQXPIQUTVRFLZ6QOYSG2ON7CLQVKRHJJZZAEMO7QLTNXXHQC

Dependencies

In channels

main

Change contents

Insertion in text.lua at line 620 [4.1]

[3.226]

  if State.cursor1.pos == nil then
    State.cursor1.pos = 1
  end

Replacement in source_text.lua at line 432 [5.83723]

B:BD[5.108390] → [2.2497:2660]

∅:D[2.2660] → [5.108390:108443]

B:BD[5.108390] → [5.108390:108443]

B:BD[5.108443] → [2.2661:2754]

∅:D[2.2754] → [5.108443:108572]

B:BD[5.108443] → [5.108443:108572]

B:BD[5.108572] → [2.2755:2842]

∅:D[2.2842] → [5.108659:108665]

∅:D[6.6889] → [5.108659:108665]

B:BD[5.108659] → [5.108659:108665]

  -- If a line/paragraph gets to a page boundary, I often want to scroll
  -- before I get to the bottom.
  -- However, only do this if it makes forward progress.
  local bot2 = Text.to2(State, State.screen_bottom1)
  if bot2.screen_line > 1 then
    bot2.screen_line = math.max(bot2.screen_line-10, 1)
  end
  local new_top1 = Text.to1(State, bot2)
  if Text.lt1(State.screen_top1, new_top1) then
    State.screen_top1 = new_top1
  else
    State.screen_top1 = {line=State.screen_bottom1.line, pos=State.screen_bottom1.pos}
  end

[5.108390]

[5.108665]

  State.screen_top1 = {line=State.screen_bottom1.line, pos=State.screen_bottom1.pos}

Insertion in source_text.lua at line 678 [5.83723]

[6.10848]

  end
  if State.cursor1.pos == nil then
    State.cursor1.pos = 1