akkartik/bf.love - Change ZLJGZYQGQ2S4UFWTVF4PQDSGMP6A4IS4GDHCMBAAA5SK2N2NWR3QC

select text with shift + mouseclick

It's still a bit simple-minded. Most software will keep the first bound fixed and move the second. Lines currently has the bounds in a queue of sorts. But I have a test to indicate the behavior that is definitely desired. We'll see if we need it to get more complex.

Created by Kartik K. Agaram on June 4, 2022

ZLJGZYQGQ2S4UFWTVF4PQDSGMP6A4IS4GDHCMBAAA5SK2N2NWR3QC

Dependencies

In channels

main

Change contents

Insertion in text_tests.lua at line 162 [2.2]
[2.5932]
[2.5932]
```
  Selection1 = {}
```

Insertion in text_tests.lua at line 168 [2.2]

[2.6250]

  check_nil(Selection1.line, 'F - test_move_cursor_using_mouse/selection:line')
  check_nil(Selection1.pos, 'F - test_move_cursor_using_mouse/selection:pos')
end
function test_select_text_using_mouse()
  io.write('\ntest_select_text_using_mouse')
  App.screen.init{width=50, height=60}
  Lines = load_array{'abc', 'def', 'xyz'}
  Line_width = App.screen.width
  Cursor1 = {line=1, pos=1}
  Screen_top1 = {line=1, pos=1}
  Screen_bottom1 = {}
  Selection1 = {}
  App.draw()  -- populate line.y for each line in Lines
  local screen_left_margin = 25  -- pixels
  -- click on first location
  App.run_after_mousepress(screen_left_margin+8,Margin_top+5, '1')
  App.run_after_mouserelease(screen_left_margin+8,Margin_top+5, '1')
  -- hold down shift and click somewhere else
  App.keypress('lshift')
  App.run_after_mousepress(screen_left_margin+20,Margin_top+5, '1')
  App.run_after_mouserelease(screen_left_margin+20,Margin_top+Line_height+5, '1')
  App.keyrelease('lshift')
  check_eq(Cursor1.line, 2, 'F - test_select_text_using_mouse/cursor:line')
  check_eq(Cursor1.pos, 4, 'F - test_select_text_using_mouse/cursor:pos')
  check_eq(Selection1.line, 1, 'F - test_select_text_using_mouse/selection:line')
  check_eq(Selection1.pos, 2, 'F - test_select_text_using_mouse/selection:pos')

Insertion in main.lua at line 199 [5.2]

[3.492]

[4.1486]

        if App.shift_down() then
          Selection1 = {line=Cursor1.line, pos=Cursor1.pos}
        end

Replacement in main.lua at line 204 [5.2]

∅:D[4.1574] → [6.234:292]

B:BD[7.1837] → [6.234:292]

        Selection1 = {line=Cursor1.line, pos=Cursor1.pos}

[4.1574]

[8.361]

        if not App.shift_down() then
          Selection1 = {line=Cursor1.line, pos=Cursor1.pos}
        end

Replacement in main.lua at line 226 [5.2]

∅:D[4.1667] → [6.541:589]

B:BD[6.541] → [6.541:589]

          if Text.eq1(Cursor1, Selection1) then

[4.1667]

[6.589]

          if Text.eq1(Cursor1, Selection1) and not App.shift_down() then

Insertion in main.lua at line 232 [5.2]

[6.661]

--?     print('select:', Selection1.line, Selection1.pos)

Replacement in keychord.lua at line 31 [10.467]
B:BD[9.258] → [9.258:287]
```
function App.modifier_down()
```
[9.258]
[11.186]
```
function App.any_modifier_down()
```

Replacement in keychord.lua at line 36 [10.467]

B:BD[12.35] → [12.35:107]

  return love.keyboard.isDown('lctrl') or love.keyboard.isDown('rctrl')

[12.35]

[12.107]

  return App.modifier_down('lctrl') or App.modifier_down('rctrl')

Replacement in keychord.lua at line 40 [10.467]

B:BD[12.136] → [12.136:206]

  return love.keyboard.isDown('lalt') or love.keyboard.isDown('ralt')

[12.136]

[12.206]

  return App.modifier_down('lalt') or App.modifier_down('ralt')

Replacement in keychord.lua at line 44 [10.467]

B:BD[12.237] → [12.237:311]

  return love.keyboard.isDown('lshift') or love.keyboard.isDown('rshift')

[12.237]

[12.311]

  return App.modifier_down('lshift') or App.modifier_down('rshift')

Replacement in keychord.lua at line 48 [10.467]

∅:D[11.292] → [12.340:410]

B:BD[12.340] → [12.340:410]

  return love.keyboard.isDown('lgui') or love.keyboard.isDown('rgui')

[11.292]

[13.180]

  return App.modifier_down('lgui') or App.modifier_down('rgui')

Insertion in app.lua at line 187 [15.2]

[14.2948]

end
App.modifier_keys = {}
function App.keypress(key)
  App.modifier_keys[key] = true
end
function App.keyrelease(key)
  App.modifier_keys[key] = nil
end
function App.modifier_down(key)
  return App.modifier_keys[key]

Insertion in app.lua at line 282 [15.2]

[16.2712]

[17.7943]

  App.keypress = nil
  App.keyrelease = nil
  App.modifier_keys = nil

Insertion in app.lua at line 293 [15.2]
[14.3061]
[17.8162]
```
  App.modifier_down = love.keyboard.isDown
```