akkartik/wardley.love - Change HIJWP6Q3CXDRIH7PJXN24JVQJF5Y53JKU7NKFPKCATQWI5DHQA3AC

make move/resize more polished+performant

This is a long-standing problem in driver.love as well:

each node requires an edit buffer and various decorations
while the mouse is down during a move/resize it's really helpful to see the decorations change
but to change decorations we have to go all the way back to A(), which is very slow if there's lots of nodes on the surface

Solution: create a variant of A called A1 that only does the work of A for a single node id (index) into Nodes.

This requires tracking for every shape we render in Surface, which id it is part of. That way we can selectively delete just shapes belonging to a single id.

Caveat: id is a scalar, so this approach can't handle any nesting, only a flat array of objects. But that's good enough for both driver.love and this app.

Created by Kartik K. Agaram on April 18, 2023

HIJWP6Q3CXDRIH7PJXN24JVQJF5Y53JKU7NKFPKCATQWI5DHQA3AC

Dependencies

In channels

main

Change contents

File addition: 0040-A1 (----------)

[3.2]

A1 = function(id, preserve_screen_top_of_cursor_node)
	-- like A, but translate a single node in Nodes to Surface
	-- this only works because Nodes is a flat array; we don't support row/col types here yet
	print('A1', id)
	-- delete previously added shapes for this node:
	for i=#Surface,1,-1 do
		local x = Surface[i]
		if x.id == id then
			table.remove(Surface, i)
		end
	end
	-- translate Nodes to Surface
	local node = Nodes[id]
	compute_layout(node, node.x,node.y, Surface, preserve_screen_top_of_cursor_node)
	-- continue the pipeline
	B(preserve_screen_top_of_cursor_node)
end

Replacement in 0036-on_move_bar at line 4 [4.349]

B:BD[4.466] → [4.466:514]

			if sy >= node.y - 40 and sy < node.y-20 then

[4.466]

[5.288]

			if sy >= node.y-15-10 and sy < node.y-15 then

Replacement in 0028-A at line 5 [6.1950]
B:BD[6.2079] → [7.109:142]
```
	for _, node in ipairs(Nodes) do
```
[6.2079]
[7.142]
```
	for i,node in ipairs(Nodes) do
		node.id = i
```
Deletion in 0021-compute_layout at line 2 [9.5777]
B:BD[8.5947] → [4.1051:1076]
```
	print('compute_layout')
```

Replacement in 0021-compute_layout at line 9 [9.5777]

B:BD[4.1123] → [4.1123:1216]

		local move_bar = {type='rectangle', r=0.5,g=0.5,b=0.5, x=node.x-10, y=node.y-10-10-4, h=4}

[4.1123]

[4.1216]

		local move_bar = {type='rectangle', r=0.8,g=0.8,b=0.8, x=node.x-10, y=node.y-10-5-10, h=10, id=node.id}

Replacement in 0021-compute_layout at line 12 [9.5777]

B:BD[4.1283] → [4.1283:1406]

		local bounding_box = {type='rectangle', drawmode='line', r=0.5, g=0.5, b=0.5, x=node.x-10, y=node.y-10, corner_radius=5}

[4.1283]

[4.1406]

		local bounding_box = {type='rectangle', drawmode='line', r=0.5, g=0.5, b=0.5, x=node.x-10, y=node.y-10, corner_radius=5, id=node.id}

Replacement in 0021-compute_layout at line 37 [9.5777]

B:BD[4.1633] → [4.1633:1911]

		table.insert(nodes_to_render, {type='line', r=0.7,g=0.7,b=0.7, data={node.x+node.w+20,node.y, node.x+node.w+20,node.y+buffer_height}})
		table.insert(nodes_to_render, {type='line', r=0.7,g=0.7,b=0.7, data={node.x+node.w+20+4,node.y, node.x+node.w+20+4,node.y+buffer_height}})

[4.1633]

[9.6819]

		table.insert(nodes_to_render, {type='line', r=0.7,g=0.7,b=0.7, data={node.x+node.w+20,node.y, node.x+node.w+20,node.y+buffer_height}, id=node.id})
		table.insert(nodes_to_render, {type='line', r=0.7,g=0.7,b=0.7, data={node.x+node.w+20+4,node.y, node.x+node.w+20+4,node.y+buffer_height}, id=node.id})

Replacement in 0018-on.update at line 13 [11.25]
B:BD[10.121] → [10.121:127]
```
		B()
```
[10.121]
[10.127]
```
		A1(Move_node.id)
```
Replacement in 0018-on.update at line 16 [11.25]
∅:D[2.95] → [10.189:195]
B:BD[10.189] → [10.189:195]
```
		A()
```
[2.95]
[10.195]
```
		A1(Resize_node.id)
```

make move/resize more polished+performant

Dependencies

In channels

Change contents

File addition: 0040-A1 (----------)

Replacement in 0036-on_move_bar at line 4 [4.349]

Replacement in 0028-A at line 5 [6.1950]

Deletion in 0021-compute_layout at line 2 [9.5777]

Replacement in 0021-compute_layout at line 9 [9.5777]

Replacement in 0021-compute_layout at line 12 [9.5777]

Replacement in 0021-compute_layout at line 37 [9.5777]

Replacement in 0018-on.update at line 13 [11.25]

Replacement in 0018-on.update at line 16 [11.25]