CV3S2Z2RTSL5F3RW3CZTGABGF7R6TRTO24LH45V6H2JHOWYZKJUAC
This one is not fixed in the change I just posted:
warning: large size difference between variants
--> src/changestore.rs:22:1
|
22 | / pub enum Error {
23 | | #[error(transparent)]
24 | | Io(#[from] std::io::Error),
25 | | #[error(transparent)]
... |
28 | | Change(#[from] libpijul::change::ChangeError),
| | --------------------------------------------- the second-largest variant contains at least 72 bytes
... |
32 | | Tag(#[from] libpijul::tag::TagError),
| | ------------------------------------ the largest variant contains at least 328 bytes
33 | | #[error(transparent)]
34 | | Persist(#[from] tempfile::PersistError),
35 | | }
| |_^ the entire enum is at least 328 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
32 | Tag(#[from] Box<libpijul::tag::TagError>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
warning: the `Err`-variant returned from this function is very large
--> src/changestore.rs:46:33
|
32 | Tag(#[from] libpijul::tag::TagError),
| ------------------------------------ the largest variant contains at least 328 bytes
...
46 | fn load(&self, h: &Hash) -> Result<(), Error> {
| ^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `changestore::Error`, for example by boxing large elements or replacing it with `Box<changestore::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: `#[warn(clippy::result_large_err)]` on by default
warning: `pijul-export` (bin "pijul-export") generated 2 warnings
And thanks for a great tool btw :-) found it really useful!
5ZSJEED77SE3LHU6S6RMBNRZPDDR3TFNXOM5SI23WIHKS6LHEHAAC
OBOLX2XLBHKQVASZMPVUVSQGQPRBFKYRFS54BIPWP6QXX2GEM2TQC
Cargo clippy produces a lot of warnings that should be easily fixable.