{"header":{"message":"Make history listing with single hostname more efficient","description":null,"timestamp":"2020-09-24T16:23:12Z","authors":[{"email":"alexander.thaller@trivago.com","name":"Alexander Thaller"}]},"hash":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC","authors":[],"deps":{"hashes":[["NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC","Make history listing with single hostname more efficient"],["AA",null],["F6L2P7VTKQUV64O66XPEIRG46ZO36E4FWFN3KNMBPRHQLQWL6HSAC","Prettier printing"],["TXF4WACU3YJSUMTXJ2VZ3K7OXL2Z564R5KGMVMAFIVXPCLYCMD2AC","Simplified storage of history per machine"],["K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC","Added changes from thaller-desktop-linux"],["EEBZMKMLEADO3ODXOQ7VNZNT36L7BYFRQUS2S2HLDVBZI7FHZQFQC","Added autocommit"],["LSRFYRWWQXJ2LVGZ7FWF5O57E4RK45EE6NWLNTRSRO5M7TFW7PZAC","Use comfytable for multiline cell support"],["B2MSSEJB4GIBFA6F2HRMK7FXUHJBZIZFK6NOHY7YZUSHRB53URGQC","Basic client/server model"],["VEN5WJYRT23IT77JAAZ5CJRSW3GUTTNMAECT3WVTHQA34HI4646AC","Implemented adding of command to store"]],"deps":["F6L2P7VTKQUV64O66XPEIRG46ZO36E4FWFN3KNMBPRHQLQWL6HSAC","TXF4WACU3YJSUMTXJ2VZ3K7OXL2Z564R5KGMVMAFIVXPCLYCMD2AC"],"known":["EEBZMKMLEADO3ODXOQ7VNZNT36L7BYFRQUS2S2HLDVBZI7FHZQFQC","K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC","LSRFYRWWQXJ2LVGZ7FWF5O57E4RK45EE6NWLNTRSRO5M7TFW7PZAC"]},"hunks":[{"Replacement":{"inode":{"change":8,"pos":9144},"path":"src/main.rs","line":191,"ins":{"up_context":[{"change":4,"pos":599}],"down_context":[{"change":2,"pos":4013}],"flag":"BLOCK","start":0,"end":78,"inode":{"change":8,"pos":9144}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":599},"to":{"change":2,"start":3941,"end":4013},"introduced_by":2}],"inode":{"change":8,"pos":9144}},"ins_contents":[{"Add":{"text":" let entries = store::new().get_nth_entries(Some(&hostname), 25)?;","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:77"}}],"del_contents":[{"Del":{"text":" let entries = store::new().get_nth_entries(&hostname, 25)?;","pos":"F6L2P7VTKQUV64O66XPEIRG46ZO36E4FWFN3KNMBPRHQLQWL6HSAC:4012"}}]}},{"Replacement":{"inode":{"change":9,"pos":10073},"path":"src/store.rs","line":111,"ins":{"up_context":[{"change":4,"pos":1676}],"down_context":[{"change":4,"pos":1755}],"flag":"BLOCK","start":79,"end":213,"inode":{"change":9,"pos":10073}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1676},"to":{"change":2,"start":5711,"end":5806},"introduced_by":2}],"inode":{"change":9,"pos":10073}},"ins_contents":[{"Add":{"text":" pub fn get_nth_entries(","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:106"}},{"Add":{"text":" &self,","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:121"}},{"Add":{"text":" hostname: Option<&str>,","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:153"}},{"Add":{"text":" count: usize,","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:175"}},{"Add":{"text":" ) -> Result, Error> {","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:212"}}],"del_contents":[{"Del":{"text":" pub fn get_nth_entries(&self, hostname: &str, count: usize) -> Result, Error> {","pos":"F6L2P7VTKQUV64O66XPEIRG46ZO36E4FWFN3KNMBPRHQLQWL6HSAC:5805"}}]}},{"Replacement":{"inode":{"change":9,"pos":10073},"path":"src/store.rs","line":119,"ins":{"up_context":[{"change":4,"pos":1889}],"down_context":[{"change":4,"pos":1973}],"flag":"BLOCK","start":214,"end":480,"inode":{"change":9,"pos":10073}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1889},"to":{"change":3,"start":125,"end":179},"introduced_by":3}],"inode":{"change":9,"pos":10073}},"ins_contents":[{"Add":{"text":" let mut entries: Vec<_> = if let Some(hostname) = hostname {","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:282"}},{"Add":{"text":" let index_path = datadir_path.join(format!(\"{}.csv\", hostname));","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:359"}},{"Add":{"text":" Self::read_log_file(index_path)?","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:404"}},{"Add":{"text":" } else {","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:421"}},{"Add":{"text":" let glob_string = datadir_path.join(\"*.csv\");","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:479"}}],"del_contents":[{"Del":{"text":" let glob_string = datadir_path.join(\"*.csv\");","pos":"TXF4WACU3YJSUMTXJ2VZ3K7OXL2Z564R5KGMVMAFIVXPCLYCMD2AC:178"}}]}},{"Replacement":{"inode":{"change":9,"pos":10073},"path":"src/store.rs","line":125,"ins":{"up_context":[{"change":4,"pos":1974}],"down_context":[{"change":4,"pos":2066}],"flag":"BLOCK","start":481,"end":577,"inode":{"change":9,"pos":10073}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1974},"to":{"change":4,"start":1974,"end":2066},"introduced_by":4}],"inode":{"change":9,"pos":10073}},"ins_contents":[{"Add":{"text":" let glob = glob::glob(&glob_string.to_string_lossy()).map_err(Error::InvalidGlob)?;","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:576"}}],"del_contents":[{"Del":{"text":" let glob = glob::glob(&glob_string.to_string_lossy()).map_err(Error::InvalidGlob)?;","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2065"}}]}},{"Replacement":{"inode":{"change":9,"pos":10073},"path":"src/store.rs","line":127,"ins":{"up_context":[{"change":4,"pos":2067}],"down_context":[{"change":4,"pos":2207}],"flag":"BLOCK","start":578,"end":730,"inode":{"change":9,"pos":10073}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2067},"to":{"change":4,"start":2067,"end":2207},"introduced_by":4}],"inode":{"change":9,"pos":10073}},"ins_contents":[{"Add":{"text":" let index_paths = glob","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:612"}},{"Add":{"text":" .collect::, glob::GlobError>>()","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:680"}},{"Add":{"text":" .map_err(Error::GlobIteration)?;","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:729"}}],"del_contents":[{"Del":{"text":" let index_paths = glob","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2097"}},{"Del":{"text":" .collect::, glob::GlobError>>()","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2161"}},{"Del":{"text":" .map_err(Error::GlobIteration)?;","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2206"}}]}},{"Replacement":{"inode":{"change":9,"pos":10073},"path":"src/store.rs","line":131,"ins":{"up_context":[{"change":4,"pos":2208}],"down_context":[{"change":4,"pos":2448}],"flag":"BLOCK","start":731,"end":978,"inode":{"change":9,"pos":10073}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2208},"to":{"change":4,"start":2208,"end":2279},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2279},"to":{"change":2,"start":5807,"end":5845},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":5845},"to":{"change":4,"start":2322,"end":2424},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2322},"to":{"change":4,"start":2322,"end":2424},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2424},"to":{"change":2,"start":5846,"end":5902},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":5902},"to":{"change":4,"start":2424,"end":2448},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2424},"to":{"change":4,"start":2424,"end":2448},"introduced_by":4}],"inode":{"change":9,"pos":10073}},"ins_contents":[{"Add":{"text":" index_paths","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:754"}},{"Add":{"text":" .into_iter()","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:783"}},{"Add":{"text":" .map(Self::read_log_file)","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:825"}},{"Add":{"text":" .collect::>, Error>>()?","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:883"}},{"Add":{"text":" .into_iter()","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:912"}},{"Add":{"text":" .flatten()","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:939"}},{"Add":{"text":" .collect()","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:966"}},{"Add":{"text":" };","pos":"NXADNFPSCM7ETIGZ676I7X3WENZPRBEZGIOLDWC2FSY652QK2UBAC:977"}}],"del_contents":[{"Del":{"text":" let mut entries: Vec<_> = index_paths","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2253"}},{"Del":{"text":" .into_iter()","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2278"}},{"Del":{"text":" .map(Self::read_log_file)","pos":"F6L2P7VTKQUV64O66XPEIRG46ZO36E4FWFN3KNMBPRHQLQWL6HSAC:5844"}},{"Del":{"text":" .collect::>, Error>>()?","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2375"}},{"Del":{"text":" .into_iter()","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2400"}},{"Del":{"text":" .flatten()","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2423"}},{"Del":{"text":" .filter(|entry| entry.hostname == hostname)","pos":"F6L2P7VTKQUV64O66XPEIRG46ZO36E4FWFN3KNMBPRHQLQWL6HSAC:5901"}},{"Del":{"text":" .collect();","pos":"K7M77GF5ILC4KKKYPTLZRZ2OND7DOQDQNRYKM3N6XV2DMJURYA3QC:2447"}}]}}],"owner":"athaller","repo":"hstdb","token":"c+8Ob30pstY0o+qeqntwzTXQzlqfJckqQMEHkBSgFkU=","login":null}

…

Dependencies

Change contents

Review