{"header":{"message":"Prepare to make external iterator for TimeSeries.","description":null,"timestamp":"2021-06-11T02:55:43.970051316Z","authors":[{"email":"e.findlay@protonmail.ch","full_name":"Eric Findlay","name":"efindlay"}]},"hash":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC","authors":[],"deps":{"hashes":[["XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC","Prepare to make external iterator for TimeSeries."],["AA",null],["QYLGEDIVYSUHAYU7ZLUZDA6OULFDDZYTQN264V3473MEXLFZ4U3AC","First record."]],"deps":["QYLGEDIVYSUHAYU7ZLUZDA6OULFDDZYTQN264V3473MEXLFZ4U3AC"],"known":[]},"hunks":[{"Edit":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":19,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":358}],"down_context":[{"change":2,"pos":358}],"flag":"BLOCK","start":0,"end":24,"inode":{"change":2,"pos":16}}},"contents":[{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:0"}},{"Add":{"text":"use serde::Serializer;","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:23"}}]}},{"Replacement":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":26,"ins":{"up_context":[{"change":2,"pos":522}],"down_context":[{"change":2,"pos":567}],"flag":"BLOCK","start":25,"end":59,"inode":{"change":2,"pos":16}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":522},"to":{"change":2,"start":522,"end":567},"introduced_by":2}],"inode":{"change":2,"pos":16}},"ins_contents":[{"Add":{"text":"#[derive(Clone, Copy, Debug, Eq)]","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:58"}}],"del_contents":[{"Del":{"text":"#[derive(Clone, Copy, Debug, Eq, Serialize)]","pos":"QYLGEDIVYSUHAYU7ZLUZDA6OULFDDZYTQN264V3473MEXLFZ4U3AC:566"}}]}},{"Edit":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":66,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":1487}],"down_context":[{"change":2,"pos":1487}],"flag":"BLOCK","start":60,"end":295,"inode":{"change":2,"pos":16}}},"contents":[{"Add":{"text":"}","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:61"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:62"}},{"Add":{"text":"impl Serialize for MonthlyDate {","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:95"}},{"Add":{"text":" fn serialize(&self, serializer: S) -> Result","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:164"}},{"Add":{"text":" where","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:174"}},{"Add":{"text":" S: Serializer,","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:197"}},{"Add":{"text":" {","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:203"}},{"Add":{"text":" serializer.serialize_str(&format!(\"{}-{:02}-01\", self.year(), self.month()))","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:288"}},{"Add":{"text":" }","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:294"}}]}},{"Edit":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":208,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":5321}],"down_context":[{"change":2,"pos":5321}],"flag":"BLOCK","start":296,"end":327,"inode":{"change":2,"pos":16}}},"contents":[{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:296"}},{"Add":{"text":"impl RegularTimeSeries::<1> {","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:326"}}]}},{"Edit":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":211,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":5322}],"down_context":[{"change":2,"pos":5322}],"flag":"BLOCK","start":328,"end":1549,"inode":{"change":2,"pos":16}}},"contents":[{"Add":{"text":" /// Consume two `RegularTimeSeries<1>` and return a `RegularTimeSeries<2>` over a tuple of the","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:426"}},{"Add":{"text":" /// original values. If the duration of the two time-series' are different then panic. If the","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:524"}},{"Add":{"text":" /// the result is empty, return an empty `RegularTimeSeries`.","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:590"}},{"Add":{"text":" pub fn zip(self, other: RegularTimeSeries<1>) -> RegularTimeSeries<2> {","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:666"}},{"Add":{"text":" ","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:674"}},{"Add":{"text":" // Each TimeSeries is a Vec of DatePoints. We can therefore just do the checks and use a","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:771"}},{"Add":{"text":" // consuming iterator over all the DatePoints.","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:826"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:827"}},{"Add":{"text":" if self.duration() != other.duration() { panic!() };","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:888"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:889"}},{"Add":{"text":" // Find first and last dates, then create iterators with this date range and zip.","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:979"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:980"}},{"Add":{"text":" let first_date = self.first_date().max(other.first_date()); ","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1050"}},{"Add":{"text":" let last_date = self.last_date().min(other.last_date());","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1115"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1116"}},{"Add":{"text":" let date_range = DateRange::new(Some(first_date), Some(last_date));","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1192"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1193"}},{"Add":{"text":" let v: Vec> = Vec::new();","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1240"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1241"}},{"Add":{"text":" let () = self.iter(date_range);","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1281"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1282"}},{"Add":{"text":" for (dp1, dp2) in self.iter(date_range).zip(other.iter(date_range)) {","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1360"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1361"}},{"Add":{"text":" // let () = dp1;","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1390"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1391"}},{"Add":{"text":" v.push(DatePoint::<2>::new(dp1.date(), [ dp1.value(0), dp2.value(0) ]));","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1476"}},{"Add":{"text":" }","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1486"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1487"}},{"Add":{"text":" TimeSeries::<2>::new(v).try_into().unwrap()","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1539"}},{"Add":{"text":" }","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1545"}},{"Add":{"text":"}","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1547"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1548"}}]}},{"Edit":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":244,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":5366}],"down_context":[{"change":2,"pos":5366}],"flag":"BLOCK","start":1550,"end":1551,"inode":{"change":2,"pos":16}}},"contents":[{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1550"}}]}},{"Edit":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":324,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":7602}],"down_context":[{"change":2,"pos":7602}],"flag":"BLOCK","start":1552,"end":1686,"inode":{"change":2,"pos":16}}},"contents":[{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1552"}},{"Add":{"text":"// Shouldn't we make a external RegularTimeSeriesIter ? It points into RegularTimeSeries and has a flag which","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1662"}},{"Add":{"text":"// manages the dates.","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1684"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1685"}}]}},{"Replacement":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":329,"ins":{"up_context":[{"change":2,"pos":7603}],"down_context":[{"change":2,"pos":7650}],"flag":"BLOCK","start":1687,"end":1949,"inode":{"change":2,"pos":16}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":7603},"to":{"change":2,"start":7603,"end":7650},"introduced_by":2}],"inode":{"change":2,"pos":16}},"ins_contents":[{"Add":{"text":"/// A `DateRange` is used to constrain a `TimeSeries` iterator over a range of dates. If","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1775"}},{"Add":{"text":"/// `start_date` or `end_date` are `None` then the iterator will start at the first value in the","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1872"}},{"Add":{"text":"/// `TimeSeries` or end at the last value in the `TimeSeries` respectively.","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1948"}}],"del_contents":[{"Del":{"text":"/// A range of dates with monthly granularity.","pos":"QYLGEDIVYSUHAYU7ZLUZDA6OULFDDZYTQN264V3473MEXLFZ4U3AC:7649"}}]}},{"Edit":{"inode":{"change":2,"pos":16},"path":"src/lib.rs","line":339,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":7790}],"down_context":[{"change":2,"pos":7790}],"flag":"BLOCK","start":1950,"end":2090,"inode":{"change":2,"pos":16}}},"contents":[{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:1950"}},{"Add":{"text":" pub fn new(start_date: Option, end_date: Option) -> Self {","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:2039"}},{"Add":{"text":" DateRange { start_date, end_date }","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:2082"}},{"Add":{"text":" }","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:2088"}},{"Add":{"text":"","pos":"XIWTRGR6SRVSX3TA6YZVMZIETMZNLJBQSJ3BAL3O6ZXURJPTHQZAC:2089"}}]}}],"owner":"currency_engineering","repo":"time_series","token":"4XOyXa7xqIPrr8YjZdiM29kb/XNOpy4ivKZTCCO/dH0=","login":null}

…

Dependencies

Change contents

Review