{"header":{"message":"CarpetX: use uniqe_ptr for strings\n","description":null,"timestamp":"2020-01-01T20:41:36Z","authors":[{"email":"rhaas@tapir.caltech.edu","name":"Roland Haas"}]},"hash":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC","authors":[],"deps":{"hashes":[["BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC","CarpetX: use uniqe_ptr for strings\n"],["AA",null],["HBZVMDSQU5KSMGZXRL67OERWEDNGTSYJVGV4BFDKKSSSHU4X23AAC","CarpetX: Make restriction more flexible\n"],["FS7Q6TUHBK5WSRDC3TM6KV2BPGWATRBLDHFGEJ72BR3FRDEOC3WAC","CarpetX: use nullptr in and unique_ptr to mark invalid groups\n\nboth globals and grid functions have a full CCTK_NumGroups sized vector\nso I mark ones that are of the \"wrong\" type with a nullptr\n"],["G6X2R5HSOTVAF5UMMYILUTUXLOVWZ6Y5Q5KXUJAMRHTD7POWNIHAC","Clean up I/O code\n"],["NGCIZ5F7DNQT7ADLRZ2SRTP7GFZZ6JIASMM5CXMWDRDYF4VZBBDAC","AMReX: add tsv extension to scalar output file\n"],["M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC","AMReX: add support for grid scalars\n\nfirst version that compiles, untested otherwise, has a couple of\nsub-optimal choices\n"],["N42E473LAYAM5NC4UXPM6WD37FLCUM26JCCKCARQEMXM7V6GWYNQC","Rewrite ASCII output\n"],["2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC","AMR evolution should work now\n"],["YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","Staggered grids\n"],["FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","AMR with point charge\n"],["WE6MDRN5SPK3THM4COLQFE3IUWBCQ5ZYUIAUCBJAZVEMMOVTNBOAC","Synchronize in the driver\n"],["5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC","More work on I/O\n"],["OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC","Output all levels into a single file\n"],["RCLGQ2LZMFVPBPTU2G55DJ6HZPOGGTPZRZCY54VGP6YLHANJ2LAQC","Move I/O to driver. WaveToy is now driver-independent.\n"],["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","Set up cctkGH entries\n"]],"deps":["HBZVMDSQU5KSMGZXRL67OERWEDNGTSYJVGV4BFDKKSSSHU4X23AAC"],"known":["WE6MDRN5SPK3THM4COLQFE3IUWBCQ5ZYUIAUCBJAZVEMMOVTNBOAC","OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC","2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC","FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC","G6X2R5HSOTVAF5UMMYILUTUXLOVWZ6Y5Q5KXUJAMRHTD7POWNIHAC","M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC","NGCIZ5F7DNQT7ADLRZ2SRTP7GFZZ6JIASMM5CXMWDRDYF4VZBBDAC","N42E473LAYAM5NC4UXPM6WD37FLCUM26JCCKCARQEMXM7V6GWYNQC","FS7Q6TUHBK5WSRDC3TM6KV2BPGWATRBLDHFGEJ72BR3FRDEOC3WAC"]},"hunks":[{"Replacement":{"inode":{"change":15,"pos":107},"path":"CarpetX/src/io.cxx","line":55,"ins":{"up_context":[{"change":3,"pos":4634}],"down_context":[{"change":3,"pos":4703}],"flag":"BLOCK","start":0,"end":71,"inode":{"change":15,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4634},"to":{"change":3,"start":4634,"end":4703},"introduced_by":3}],"inode":{"change":15,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC:70"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:4702"}}]}},{"Replacement":{"inode":{"change":15,"pos":107},"path":"CarpetX/src/io.cxx","line":184,"ins":{"up_context":[{"change":3,"pos":298}],"down_context":[{"change":3,"pos":367}],"flag":"BLOCK","start":72,"end":143,"inode":{"change":15,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":298},"to":{"change":3,"start":298,"end":367},"introduced_by":3}],"inode":{"change":15,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC:142"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC:366"}}]}},{"Replacement":{"inode":{"change":15,"pos":107},"path":"CarpetX/src/io.cxx","line":304,"ins":{"up_context":[{"change":3,"pos":4367}],"down_context":[{"change":3,"pos":4434}],"flag":"BLOCK","start":144,"end":213,"inode":{"change":15,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4367},"to":{"change":3,"start":4367,"end":4434},"introduced_by":3}],"inode":{"change":15,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC:212"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:4433"}}]}},{"Replacement":{"inode":{"change":16,"pos":531},"path":"CarpetX/src/schedule.cxx","line":1869,"ins":{"up_context":[{"change":3,"pos":17648}],"down_context":[{"change":3,"pos":17712}],"flag":"BLOCK","start":214,"end":281,"inode":{"change":16,"pos":531}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":17648},"to":{"change":2,"start":322,"end":387},"introduced_by":2}],"inode":{"change":16,"pos":531}},"ins_contents":[{"Add":{"text":" buf << unique_ptr(CCTK_GroupName(groups0[n])).get();","pos":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC:280"}}],"del_contents":[{"Del":{"text":" buf << unique_ptr(CCTK_GroupName(groups0[n])).get();","pos":"HBZVMDSQU5KSMGZXRL67OERWEDNGTSYJVGV4BFDKKSSSHU4X23AAC:386"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review