{"header":{"message":"CarpetX: reverted an if...else change\n\nThe else was functionally unnecessary, and the original code did\nnot use else. The reversion makes comparison of changes easier\nfor reviewers. This commit also includes the clang-format changes,\nwhich are purely cosmetic.\n","description":null,"timestamp":"2020-10-21T12:16:37Z","authors":[{"email":"scupp1@my.apsu.edu","name":"Samuel Cupp"}]},"hash":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC","authors":[],"deps":{"hashes":[["E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC","CarpetX: reverted an if...else change\n\nThe else was functionally unnecessary, and the original code did\nnot use else. The reversion makes comparison of changes easier\nfor reviewers. This commit also includes the clang-format changes,\nwhich are purely cosmetic.\n"],["AA",null],["6OFN2SJK2MPLZQWYF4RBKSVAZ6BX3LINXR3OXUJED6CWLDTAU7UQC","CarpetX: Merged scalar and array code\n"],["RNWFZWSK2ZKUVNSKAZVNZFYOT6HIOH3FIGKCVAFFKOTAHCGWECNAC","CarpetX: Removed unnecessary if statements\n"],["5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC","CarpetX: Added support for arrays and DynamicData\n\nThis is specifically for distrib=const arrays, and distributed arrays\nare still not supported. The overloaded function for DynamicData is\nalso included which reproduces the behavior of the Carpet DynamicData\nfunction. Finally, a bug with validity for scalars is fixed.\n"],["3QWZBYJLGJFSLSL2ZG4JVCSUGF73TQJNPHV3MRMIIBUA7XNUU7NAC","CarpetX: Rearrange code for clarity\n"],["722HZ7UFINNE3YKSYKP2NHZ5XEG5QQLQHSKC7PREJZR3EX6RDYUAC","Import initial AMReX driver for Cactus\n"],["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","Set up cctkGH entries\n"]],"deps":["6OFN2SJK2MPLZQWYF4RBKSVAZ6BX3LINXR3OXUJED6CWLDTAU7UQC"],"known":["3QWZBYJLGJFSLSL2ZG4JVCSUGF73TQJNPHV3MRMIIBUA7XNUU7NAC","5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC","RNWFZWSK2ZKUVNSKAZVNZFYOT6HIOH3FIGKCVAFFKOTAHCGWECNAC"]},"hunks":[{"Replacement":{"inode":{"change":7,"pos":15972},"path":"CarpetX/src/driver.cxx","line":638,"ins":{"up_context":[{"change":3,"pos":3504}],"down_context":[{"change":3,"pos":3578}],"flag":"BLOCK","start":0,"end":74,"inode":{"change":7,"pos":15972}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3504},"to":{"change":3,"start":123,"end":199},"introduced_by":3}],"inode":{"change":7,"pos":15972}},"ins_contents":[{"Add":{"text":" if (group.grouptype != CCTK_SCALAR and group.grouptype != CCTK_ARRAY)","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:73"}}],"del_contents":[{"Del":{"text":" if (group.grouptype != CCTK_SCALAR and group.grouptype != CCTK_ARRAY) {","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:198"}}]}},{"Replacement":{"inode":{"change":7,"pos":15972},"path":"CarpetX/src/driver.cxx","line":640,"ins":{"up_context":[{"change":3,"pos":3594}],"down_context":[{"change":3,"pos":2302}],"flag":"BLOCK","start":75,"end":282,"inode":{"change":7,"pos":15972}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2089},"to":{"change":3,"start":2089,"end":2102},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2102},"to":{"change":2,"start":0,"end":79},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":79},"to":{"change":3,"start":2147,"end":2253},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2147},"to":{"change":3,"start":2147,"end":2253},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2253},"to":{"change":2,"start":80,"end":110},"introduced_by":2}],"inode":{"change":7,"pos":15972}},"ins_contents":[{"Add":{"text":" assert(group.grouptype == CCTK_ARRAY || group.grouptype == CCTK_SCALAR);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:151"}},{"Add":{"text":" assert(group.vartype == CCTK_VARIABLE_REAL);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:200"}},{"Add":{"text":" assert(group.disttype == CCTK_DISTRIB_CONSTANT);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:253"}},{"Add":{"text":" assert(group.dim >= 0);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:281"}}],"del_contents":[{"Del":{"text":" } else {","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2101"}},{"Del":{"text":" assert(group.grouptype == CCTK_ARRAY || group.grouptype == CCTK_SCALAR);","pos":"6OFN2SJK2MPLZQWYF4RBKSVAZ6BX3LINXR3OXUJED6CWLDTAU7UQC:78"}},{"Del":{"text":" assert(group.vartype == CCTK_VARIABLE_REAL);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2197"}},{"Del":{"text":" assert(group.disttype == CCTK_DISTRIB_CONSTANT);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2252"}},{"Del":{"text":" assert(group.dim >= 0);","pos":"6OFN2SJK2MPLZQWYF4RBKSVAZ6BX3LINXR3OXUJED6CWLDTAU7UQC:109"}}]}},{"Replacement":{"inode":{"change":7,"pos":15972},"path":"CarpetX/src/driver.cxx","line":645,"ins":{"up_context":[{"change":3,"pos":2303}],"down_context":[{"change":3,"pos":3769}],"flag":"BLOCK","start":283,"end":747,"inode":{"change":7,"pos":15972}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2303},"to":{"change":3,"start":2303,"end":2785},"introduced_by":3}],"inode":{"change":7,"pos":15972}},"ins_contents":[{"Add":{"text":" globaldata.arraygroupdata.at(gi) =","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:321"}},{"Add":{"text":" make_unique();","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:379"}},{"Add":{"text":" GHExt::GlobalData::ArrayGroupData &arraygroupdata =","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:435"}},{"Add":{"text":" *globaldata.arraygroupdata.at(gi);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:478"}},{"Add":{"text":" arraygroupdata.groupindex = gi;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:514"}},{"Add":{"text":" arraygroupdata.firstvarindex = CCTK_FirstVarIndexI(gi);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:574"}},{"Add":{"text":" arraygroupdata.numvars = group.numvars;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:618"}},{"Add":{"text":" arraygroupdata.do_checkpoint = get_group_checkpoint_flag(gi);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:684"}},{"Add":{"text":" arraygroupdata.do_restrict = get_group_restrict_flag(gi);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:746"}}],"del_contents":[{"Del":{"text":" globaldata.arraygroupdata.at(gi) =","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2343"}},{"Del":{"text":" make_unique();","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2403"}},{"Del":{"text":" GHExt::GlobalData::ArrayGroupData &arraygroupdata =","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2461"}},{"Del":{"text":" *globaldata.arraygroupdata.at(gi);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2506"}},{"Del":{"text":" arraygroupdata.groupindex = gi;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2544"}},{"Del":{"text":" arraygroupdata.firstvarindex = CCTK_FirstVarIndexI(gi);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2606"}},{"Del":{"text":" arraygroupdata.numvars = group.numvars;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2652"}},{"Del":{"text":" arraygroupdata.do_checkpoint = get_group_checkpoint_flag(gi);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2720"}},{"Del":{"text":" arraygroupdata.do_restrict = get_group_restrict_flag(gi);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2784"}}]}},{"Replacement":{"inode":{"change":7,"pos":15972},"path":"CarpetX/src/driver.cxx","line":655,"ins":{"up_context":[{"change":3,"pos":3770}],"down_context":[{"change":3,"pos":4244}],"flag":"BLOCK","start":748,"end":961,"inode":{"change":7,"pos":15972}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3770},"to":{"change":3,"start":2786,"end":3009},"introduced_by":3}],"inode":{"change":7,"pos":15972}},"ins_contents":[{"Add":{"text":" CCTK_INT const *const *const sz = CCTK_GroupSizesI(gi);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:807"}},{"Add":{"text":" arraygroupdata.array_size = 1;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:842"}},{"Add":{"text":" for (int d = 0; d < group.dim; ++d) {","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:884"}},{"Add":{"text":" arraygroupdata.array_size = arraygroupdata.array_size * *sz[d];","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:954"}},{"Add":{"text":" }","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:960"}}],"del_contents":[{"Del":{"text":" CCTK_INT const *const *const sz = CCTK_GroupSizesI(gi);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2847"}},{"Del":{"text":" arraygroupdata.array_size = 1;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2884"}},{"Del":{"text":" for (int d = 0; d < group.dim; ++d) {","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:2928"}},{"Del":{"text":" arraygroupdata.array_size = arraygroupdata.array_size * *sz[d];","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3000"}},{"Del":{"text":" }","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3008"}}]}},{"Replacement":{"inode":{"change":7,"pos":15972},"path":"CarpetX/src/driver.cxx","line":661,"ins":{"up_context":[{"change":3,"pos":4245}],"down_context":[{"change":3,"pos":3487}],"flag":"BLOCK","start":962,"end":1415,"inode":{"change":7,"pos":15972}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4245},"to":{"change":3,"start":3010,"end":3487},"introduced_by":3}],"inode":{"change":7,"pos":15972}},"ins_contents":[{"Add":{"text":" // Set up dynamic data","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:988"}},{"Add":{"text":" arraygroupdata.dimension = group.dim;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1030"}},{"Add":{"text":" arraygroupdata.activetimelevels = 1;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1071"}},{"Add":{"text":" for (int d = 0; d < group.dim; ++d) {","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1113"}},{"Add":{"text":" arraygroupdata.lsh[d] = *sz[d];","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1151"}},{"Add":{"text":" arraygroupdata.ash[d] = *sz[d];","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1189"}},{"Add":{"text":" arraygroupdata.gsh[d] = *sz[d];","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1227"}},{"Add":{"text":" arraygroupdata.nghostzones[d] = 0;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1268"}},{"Add":{"text":" arraygroupdata.lbnd[d] = 0;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1302"}},{"Add":{"text":" arraygroupdata.ubnd[d] = *sz[d]-1;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1343"}},{"Add":{"text":" arraygroupdata.bbox[2*d] = arraygroupdata.bbox[2*d+1] = 1;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1408"}},{"Add":{"text":" }","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1414"}}],"del_contents":[{"Del":{"text":" // Set up dynamic data","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3038"}},{"Del":{"text":" arraygroupdata.dimension = group.dim;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3082"}},{"Del":{"text":" arraygroupdata.activetimelevels = 1;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3125"}},{"Del":{"text":" for (int d = 0; d < group.dim; ++d) {","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3169"}},{"Del":{"text":" arraygroupdata.lsh[d] = *sz[d];","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3209"}},{"Del":{"text":" arraygroupdata.ash[d] = *sz[d];","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3249"}},{"Del":{"text":" arraygroupdata.gsh[d] = *sz[d];","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3289"}},{"Del":{"text":" arraygroupdata.nghostzones[d] = 0;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3332"}},{"Del":{"text":" arraygroupdata.lbnd[d] = 0;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3368"}},{"Del":{"text":" arraygroupdata.ubnd[d] = *sz[d]-1;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3411"}},{"Del":{"text":" arraygroupdata.bbox[2*d] = arraygroupdata.bbox[2*d+1] = 1;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3478"}},{"Del":{"text":" }","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3486"}}]}},{"Replacement":{"inode":{"change":7,"pos":15972},"path":"CarpetX/src/driver.cxx","line":674,"ins":{"up_context":[{"change":3,"pos":3488}],"down_context":[{"change":3,"pos":5058}],"flag":"BLOCK","start":1416,"end":2246,"inode":{"change":7,"pos":15972}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3488},"to":{"change":3,"start":3488,"end":4350},"introduced_by":3}],"inode":{"change":7,"pos":15972}},"ins_contents":[{"Add":{"text":" // Allocate data","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1436"}},{"Add":{"text":" arraygroupdata.data.resize(group.numtimelevels);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1489"}},{"Add":{"text":" arraygroupdata.valid.resize(group.numtimelevels);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1543"}},{"Add":{"text":" for (int tl = 0; tl < int(arraygroupdata.data.size()); ++tl) {","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1610"}},{"Add":{"text":" arraygroupdata.data.at(tl).resize(arraygroupdata.numvars*arraygroupdata.array_size);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1701"}},{"Add":{"text":" why_valid_t why([] { return \"SetupGlobals\"; });","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1755"}},{"Add":{"text":" arraygroupdata.valid.at(tl).resize(arraygroupdata.numvars, why);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1826"}},{"Add":{"text":" for (int vi = 0; vi < arraygroupdata.numvars; ++vi) {","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1886"}},{"Add":{"text":" // TODO: decide that valid_bnd == false always and rely on","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1953"}},{"Add":{"text":" // initialization magic?","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:1986"}},{"Add":{"text":" valid_t valid;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2009"}},{"Add":{"text":" valid.valid_int = false;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2042"}},{"Add":{"text":" valid.valid_outer = true;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2076"}},{"Add":{"text":" valid.valid_ghosts = true;","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2111"}},{"Add":{"text":" arraygroupdata.valid.at(tl).at(vi).set(valid,","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2165"}},{"Add":{"text":" [] { return \"SetupGlobals\"; });","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2245"}}],"del_contents":[{"Del":{"text":" // Allocate data","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3510"}},{"Del":{"text":" arraygroupdata.data.resize(group.numtimelevels);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3565"}},{"Del":{"text":" arraygroupdata.valid.resize(group.numtimelevels);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3621"}},{"Del":{"text":" for (int tl = 0; tl < int(arraygroupdata.data.size()); ++tl) {","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3690"}},{"Del":{"text":" arraygroupdata.data.at(tl).resize(arraygroupdata.numvars*arraygroupdata.array_size);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3783"}},{"Del":{"text":" why_valid_t why([] { return \"SetupGlobals\"; });","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3839"}},{"Del":{"text":" arraygroupdata.valid.at(tl).resize(arraygroupdata.numvars, why);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3912"}},{"Del":{"text":" for (int vi = 0; vi < arraygroupdata.numvars; ++vi) {","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:3974"}},{"Del":{"text":" // TODO: decide that valid_bnd == false always and rely on","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4043"}},{"Del":{"text":" // initialization magic?","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4078"}},{"Del":{"text":" valid_t valid;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4103"}},{"Del":{"text":" valid.valid_int = false;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4138"}},{"Del":{"text":" valid.valid_outer = true;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4174"}},{"Del":{"text":" valid.valid_ghosts = true;","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4211"}},{"Del":{"text":" arraygroupdata.valid.at(tl).at(vi).set(valid,","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4267"}},{"Del":{"text":" [] { return \"SetupGlobals\"; });","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4349"}}]}},{"Replacement":{"inode":{"change":7,"pos":15972},"path":"CarpetX/src/driver.cxx","line":691,"ins":{"up_context":[{"change":3,"pos":5059}],"down_context":[{"change":3,"pos":5286}],"flag":"BLOCK","start":2247,"end":2472,"inode":{"change":7,"pos":15972}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":5059},"to":{"change":3,"start":4351,"end":4594},"introduced_by":3}],"inode":{"change":7,"pos":15972}},"ins_contents":[{"Add":{"text":" // TODO: make poison_invalid and check_invalid virtual members of","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2320"}},{"Add":{"text":" // CommonGroupData","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2347"}},{"Add":{"text":" poison_invalid(arraygroupdata, vi, tl);","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2395"}},{"Add":{"text":" check_valid(arraygroupdata, vi, tl, [] { return \"SetupGlobals\"; });","pos":"E7WUAZCMU5IUJMF4SPNX3CDXGZACKOJDQBH2DHVJXWUQH3ULQGJQC:2471"}}],"del_contents":[{"Del":{"text":" // TODO: make poison_invalid and check_invalid virtual members of","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4426"}},{"Del":{"text":" // CommonGroupData","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4455"}},{"Del":{"text":" poison_invalid(arraygroupdata, vi, tl);","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4505"}},{"Del":{"text":" check_valid(arraygroupdata, vi, tl, [] { return \"SetupGlobals\"; });","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4583"}},{"Del":{"text":" }","pos":"5B6D6UREX556XOAM75B3WOIGE6DT43HIS6JOVJYNXUT3FSZDUPBAC:4593"}}]}},{"Edit":{"inode":{"change":8,"pos":531},"path":"CarpetX/src/schedule.cxx","line":522,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1196},"to":{"change":2,"start":1196,"end":1229},"introduced_by":2}],"inode":{"change":8,"pos":531}}},"contents":[{"Del":{"text":" atomic nan_count{0};","pos":"6OFN2SJK2MPLZQWYF4RBKSVAZ6BX3LINXR3OXUJED6CWLDTAU7UQC:1228"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review