{"header":{"message":"Clean up I/O code\n","description":null,"timestamp":"2019-08-22T18:40:04Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"G6X2R5HSOTVAF5UMMYILUTUXLOVWZ6Y5Q5KXUJAMRHTD7POWNIHAC","authors":[],"deps":{"hashes":[["G6X2R5HSOTVAF5UMMYILUTUXLOVWZ6Y5Q5KXUJAMRHTD7POWNIHAC","Clean up I/O code\n"],["AA",null],["5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC","More work on I/O\n"],["OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC","Output all levels into a single file\n"],["YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","Staggered grids\n"],["FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","AMR with point charge\n"],["2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC","AMR evolution should work now\n"],["RCLGQ2LZMFVPBPTU2G55DJ6HZPOGGTPZRZCY54VGP6YLHANJ2LAQC","Move I/O to driver. WaveToy is now driver-independent.\n"]],"deps":["5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC"],"known":["RCLGQ2LZMFVPBPTU2G55DJ6HZPOGGTPZRZCY54VGP6YLHANJ2LAQC","OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC","2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC","FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":107},"path":"AMReX/src/io.cxx","line":46,"ins":{"up_context":[{"change":3,"pos":4821}],"down_context":[{"change":2,"pos":337}],"flag":"BLOCK","start":0,"end":38,"inode":{"change":3,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4821},"to":{"change":2,"start":305,"end":337},"introduced_by":2}],"inode":{"change":3,"pos":107}},"ins_contents":[{"Add":{"text":" const string filename = [&]() {","pos":"G6X2R5HSOTVAF5UMMYILUTUXLOVWZ6Y5Q5KXUJAMRHTD7POWNIHAC:37"}}],"del_contents":[{"Del":{"text":" string filename = [&]() {","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:336"}}]}},{"Replacement":{"inode":{"change":3,"pos":107},"path":"AMReX/src/io.cxx","line":79,"ins":{"up_context":[{"change":2,"pos":588}],"down_context":[{"change":2,"pos":623}],"flag":"BLOCK","start":39,"end":80,"inode":{"change":3,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":588},"to":{"change":2,"start":588,"end":623},"introduced_by":2}],"inode":{"change":3,"pos":107}},"ins_contents":[{"Add":{"text":" const string visitname = [&]() {","pos":"G6X2R5HSOTVAF5UMMYILUTUXLOVWZ6Y5Q5KXUJAMRHTD7POWNIHAC:79"}}],"del_contents":[{"Del":{"text":" string visitname = [&]() {","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:622"}}]}},{"Edit":{"inode":{"change":3,"pos":107},"path":"AMReX/src/io.cxx","line":90,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1005},"to":{"change":2,"start":1005,"end":1013},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":1013},"to":{"change":3,"start":6038,"end":6051},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":6038},"to":{"change":3,"start":6038,"end":6051},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":6051},"to":{"change":3,"start":3680,"end":3835},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3680},"to":{"change":3,"start":3680,"end":3835},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3835},"to":{"change":3,"start":4553,"end":4595},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":4595},"to":{"change":3,"start":4026,"end":4307},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4026},"to":{"change":3,"start":4026,"end":4307},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4307},"to":{"change":3,"start":4596,"end":4732},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":4732},"to":{"change":3,"start":4443,"end":4472},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4443},"to":{"change":3,"start":4443,"end":4472},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4472},"to":{"change":3,"start":4733,"end":4803},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":4803},"to":{"change":3,"start":4532,"end":4533},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4532},"to":{"change":3,"start":4532,"end":4533},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4533},"to":{"change":3,"start":4804,"end":4936},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":4936},"to":{"change":3,"start":4650,"end":4852},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4650},"to":{"change":3,"start":4650,"end":4852},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4852},"to":{"change":3,"start":4937,"end":5087},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":5087},"to":{"change":3,"start":4987,"end":5062},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4987},"to":{"change":3,"start":4987,"end":5062},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":5062},"to":{"change":3,"start":5088,"end":5283},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":5283},"to":{"change":3,"start":5242,"end":5333},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":5242},"to":{"change":3,"start":5242,"end":5333},"introduced_by":3}],"inode":{"change":3,"pos":107}}},"contents":[{"Del":{"text":" }","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:1012"}},{"Del":{"text":" }","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:6043"}},{"Del":{"text":" }","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:6047"}},{"Del":{"text":"}","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:6049"}},{"Del":{"text":"","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:6050"}},{"Del":{"text":"template ","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:3701"}},{"Del":{"text":"void write_arrays(ostream &os, const cGH *restrict cctkGH, int level,","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:3771"}},{"Del":{"text":" int component, const vector ptrs,","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:3834"}},{"Del":{"text":" const GridDesc &grid) {","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4594"}},{"Del":{"text":" DECLARE_CCTK_ARGUMENTS;","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4051"}},{"Del":{"text":"","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4052"}},{"Del":{"text":" const int levfac = 1 << level;","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4085"}},{"Del":{"text":" CCTK_REAL x0[dim], dx[dim];","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4115"}},{"Del":{"text":" for (int d = 0; d < dim; ++d) {","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4149"}},{"Del":{"text":" dx[d] = cctk_delta_space[d] / levfac;","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4191"}},{"Del":{"text":" x0[d] = cctk_origin_space[d] + 0.5 * dx[d];","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4239"}},{"Del":{"text":" }","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4243"}},{"Del":{"text":"","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4244"}},{"Del":{"text":" int imin[dim], imax[dim];","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4272"}},{"Del":{"text":" for (int d = 0; d < dim; ++d) {","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4306"}},{"Del":{"text":" imin[d] = grid.bbox[2 * d] ? 0 : grid.nghostzones[d];","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4653"}},{"Del":{"text":" imax[d] = grid.lsh[d] - (grid.bbox[2 * d + 1] ? 0 : grid.nghostzones[d]);","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4731"}},{"Del":{"text":" }","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4446"}},{"Del":{"text":"","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4447"}},{"Del":{"text":" constexpr int di = 1;","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4471"}},{"Del":{"text":" const int dj = di * grid.ash[0];","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4767"}},{"Del":{"text":" const int dk = dj * grid.ash[1];","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4802"}},{"Del":{"text":"","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4532"}},{"Del":{"text":" for (int k = 0; k < grid.lsh[2]; ++k) {","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4845"}},{"Del":{"text":" for (int j = 0; j < grid.lsh[1]; ++j) {","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4889"}},{"Del":{"text":" for (int i = 0; i < grid.lsh[0]; ++i) {","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4935"}},{"Del":{"text":" const int idx = di * i + dj * j + dk * k;","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4699"}},{"Del":{"text":" const int isghost = !(i >= imin[0] && i < imax[0] && j >= imin[1] &&","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4776"}},{"Del":{"text":" j < imax[1] && k >= imin[2] && k < imax[2]);","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:4851"}},{"Del":{"text":" T x = x0[0] + (grid.lbnd[0] + i) * dx[0];","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:4986"}},{"Del":{"text":" T y = x0[1] + (grid.lbnd[1] + j) * dx[1];","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:5036"}},{"Del":{"text":" T z = x0[2] + (grid.lbnd[2] + k) * dx[2];","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:5086"}},{"Del":{"text":" os << cctk_iteration << \"\\t\" << cctk_time << \"\\t\" << level << \"\\t\"","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:5061"}},{"Del":{"text":" << component << \"\\t\" << isghost << \"\\t\" << (grid.lbnd[0] + i) << \"\\t\"","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:5168"}},{"Del":{"text":" << (grid.lbnd[1] + j) << \"\\t\" << (grid.lbnd[2] + k) << \"\\t\" << x","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:5244"}},{"Del":{"text":" << \"\\t\" << y << \"\\t\" << z;","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:5282"}},{"Del":{"text":" for (const auto &ptr : ptrs)","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:5278"}},{"Del":{"text":" os << \"\\t\" << ptr[idx];","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:5312"}},{"Del":{"text":" os << \"\\n\";","pos":"2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC:5332"}}]}},{"Edit":{"inode":{"change":3,"pos":107},"path":"AMReX/src/io.cxx","line":126,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":5694},"to":{"change":3,"start":6800,"end":6841},"introduced_by":3}],"inode":{"change":3,"pos":107}}},"contents":[{"Del":{"text":" // << \"\\t\"","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:6817"}},{"Del":{"text":" // << \"isghost\"","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:6840"}}]}},{"Replacement":{"inode":{"change":3,"pos":107},"path":"AMReX/src/io.cxx","line":199,"ins":{"up_context":[{"change":3,"pos":8083}],"down_context":[{"change":3,"pos":751}],"flag":"BLOCK","start":81,"end":122,"inode":{"change":3,"pos":107}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":8083},"to":{"change":3,"start":613,"end":648},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":613},"to":{"change":3,"start":613,"end":648},"introduced_by":3}],"inode":{"change":3,"pos":107}},"ins_contents":[{"Add":{"text":" const string filename = buf.str();","pos":"G6X2R5HSOTVAF5UMMYILUTUXLOVWZ6Y5Q5KXUJAMRHTD7POWNIHAC:121"}}],"del_contents":[{"Del":{"text":" string filename = buf.str();","pos":"OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC:647"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review