{"header":{"message":"Correct reduction operators\n","description":null,"timestamp":"2019-11-06T15:23:55Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC","authors":[],"deps":{"hashes":[["I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC","Correct reduction operators\n"],["AA",null],["BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC","Disable ghost zones for fluxes\n"],["JD6PQOJ6YYNQYEEWEXO2NM7NVYNBUI6V7ZU6Q3FNHGAT2VYOF5WAC","Output regridding statistics\n"],["BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC","Keep track of which regions of which variables have valid data.\n\nAlso correct all respective bugs.\n"],["2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC","AMR evolution should work now\n"],["YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","Staggered grids\n"],["FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","AMR with point charge\n"],["5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC","More work on I/O\n"],["VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC","Implement reduction operations\n"],["KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC","AMR works\n"]],"deps":["BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC"],"known":["VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC","KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC","2DKSL6DKZAIYQUJGDULORCKU5K4Z5Z3W4RIKQYDSLKMCNQNDZFBAC","FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC","JD6PQOJ6YYNQYEEWEXO2NM7NVYNBUI6V7ZU6Q3FNHGAT2VYOF5WAC","BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":11,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2232}],"down_context":[{"change":3,"pos":950}],"flag":"BLOCK","start":0,"end":78,"inode":{"change":3,"pos":870}}},"contents":[{"Add":{"text":"#include ","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:18"}},{"Add":{"text":"#include ","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:36"}},{"Add":{"text":"#include ","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:59"}},{"Add":{"text":"#include ","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:77"}}]}},{"Edit":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":20,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2234}],"down_context":[{"change":3,"pos":2234}],"flag":"BLOCK","start":79,"end":669,"inode":{"change":3,"pos":870}}},"contents":[{"Add":{"text":"template MPI_Datatype reduction_mpi_datatype() {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:140"}},{"Add":{"text":" static MPI_Datatype datatype = MPI_DATATYPE_NULL;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:192"}},{"Add":{"text":" if (datatype == MPI_DATATYPE_NULL) {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:231"}},{"Add":{"text":" MPI_Type_contiguous(sizeof(reduction) / sizeof(T),","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:289"}},{"Add":{"text":" mpi_datatype::value, &datatype);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:349"}},{"Add":{"text":" char name[MPI_MAX_OBJECT_NAME];","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:385"}},{"Add":{"text":" int namelen;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:402"}},{"Add":{"text":" MPI_Type_get_name(mpi_datatype::value, name, &namelen);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:465"}},{"Add":{"text":" ostringstream buf;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:488"}},{"Add":{"text":" buf << \"reduction<\" << name << \">\";","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:528"}},{"Add":{"text":" string newname = buf.str();","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:560"}},{"Add":{"text":" MPI_Type_set_name(datatype, newname.c_str());","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:610"}},{"Add":{"text":" MPI_Type_commit(&datatype);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:642"}},{"Add":{"text":" }","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:646"}},{"Add":{"text":" return datatype;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:665"}},{"Add":{"text":"}","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:667"}},{"Add":{"text":"","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:668"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":50,"ins":{"up_context":[{"change":3,"pos":2677}],"down_context":[{"change":3,"pos":2931}],"flag":"BLOCK","start":670,"end":1652,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2677},"to":{"change":3,"start":2677,"end":2931},"introduced_by":3}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":" // Analyze MPI datatype","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:695"}},{"Add":{"text":" int num_integers, num_addresses, num_datatypes, combiner;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:755"}},{"Add":{"text":" MPI_Type_get_envelope(*datatype, &num_integers, &num_addresses,","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:821"}},{"Add":{"text":" &num_datatypes, &combiner);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:873"}},{"Add":{"text":" assert(combiner == MPI_COMBINER_CONTIGUOUS);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:920"}},{"Add":{"text":" assert(num_integers == 1);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:949"}},{"Add":{"text":" assert(num_addresses = 1);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:978"}},{"Add":{"text":" assert(num_datatypes == 1);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1008"}},{"Add":{"text":" vector integers(num_integers);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1046"}},{"Add":{"text":" vector addresses(num_addresses);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1091"}},{"Add":{"text":" vector datatypes(num_datatypes);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1140"}},{"Add":{"text":" MPI_Type_get_contents(*datatype, num_integers, num_addresses, num_datatypes,","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1219"}},{"Add":{"text":" integers.data(), addresses.data(), datatypes.data());","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1297"}},{"Add":{"text":" MPI_Datatype inner_datatype = datatypes.at(0);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1346"}},{"Add":{"text":" if (inner_datatype == MPI_FLOAT)","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1381"}},{"Add":{"text":" return mpi_reduce_typed >(x, y, length);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1443"}},{"Add":{"text":" if (inner_datatype == MPI_DOUBLE)","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1479"}},{"Add":{"text":" return mpi_reduce_typed >(x, y, length);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1542"}},{"Add":{"text":" if (inner_datatype == MPI_LONG_DOUBLE)","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1583"}},{"Add":{"text":" return mpi_reduce_typed >(x, y, length);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1651"}}],"del_contents":[{"Del":{"text":" if (*datatype == MPI_FLOAT)","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:2706"}},{"Del":{"text":" return mpi_reduce_typed(x, y, length);","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:2756"}},{"Del":{"text":" if (*datatype == MPI_DOUBLE)","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:2787"}},{"Del":{"text":" return mpi_reduce_typed(x, y, length);","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:2838"}},{"Del":{"text":" if (*datatype == MPI_LONG_DOUBLE)","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:2874"}},{"Del":{"text":" return mpi_reduce_typed(x, y, length);","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:2930"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":77,"ins":{"up_context":[{"change":3,"pos":3047}],"down_context":[{"change":3,"pos":3086}],"flag":"BLOCK","start":1653,"end":1705,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3047},"to":{"change":3,"start":3047,"end":3086},"introduced_by":3}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":" MPI_Op_create(mpi_reduce, 1 /*commutes*/, &op);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1704"}}],"del_contents":[{"Del":{"text":" MPI_Op_create(mpi_reduce, 1, &op);","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:3085"}}]}},{"Edit":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":83,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":1186}],"down_context":[{"change":3,"pos":1186}],"flag":"BLOCK","start":1706,"end":1718,"inode":{"change":3,"pos":870}}},"contents":[{"Add":{"text":"namespace {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1717"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":85,"ins":{"up_context":[{"change":3,"pos":1208}],"down_context":[{"change":3,"pos":1335}],"flag":"BLOCK","start":1719,"end":1978,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1208},"to":{"change":3,"start":15146,"end":15266},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":15266},"to":{"change":2,"start":9133,"end":9212},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":9212},"to":{"change":3,"start":3258,"end":3337},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3258},"to":{"change":3,"start":3258,"end":3337},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":3337},"to":{"change":3,"start":4011,"end":4132},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":15339},"to":{"change":3,"start":4011,"end":4132},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":9638},"to":{"change":3,"start":4011,"end":4132},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4011},"to":{"change":3,"start":4011,"end":4132},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4132},"to":{"change":3,"start":9639,"end":9640},"introduced_by":3}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":"reduction reduce_array(const Array4 &restrict vars, int n,","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1789"}},{"Add":{"text":" const array &imin,","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1844"}},{"Add":{"text":" const array &imax,","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1899"}},{"Add":{"text":" const Array4 *restrict finemask, T dV) {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:1977"}}],"del_contents":[{"Del":{"text":"reduction reduce_array(const Geometry &geom,","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:15193"}},{"Del":{"text":" const GHExt::LevelData::GroupData &groupdata,","pos":"YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC:15265"}},{"Del":{"text":" const GridPtrDesc1 &grid, const GF3D1 ptr_,","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9211"}},{"Del":{"text":" const Array4 *restrict finemask_array4) {","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:3336"}},{"Del":{"text":" const CCTK_REAL *restrict dx = geom.CellSize();","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4060"}},{"Del":{"text":" CCTK_REAL dV = 1.0;","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4082"}},{"Del":{"text":" for (int d = 0; d < dim; ++d)","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4114"}},{"Del":{"text":" dV *= dx[d];","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4131"}},{"Del":{"text":"","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:9639"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":90,"ins":{"up_context":[{"change":3,"pos":1355}],"down_context":[{"change":3,"pos":1692}],"flag":"BLOCK","start":1979,"end":2334,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1355},"to":{"change":2,"start":9213,"end":9623},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":9623},"to":{"change":3,"start":9756,"end":9757},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":9756},"to":{"change":3,"start":9756,"end":9757},"introduced_by":3}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":" for (int k = imin[2]; k < imax[2]; ++k) {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2022"}},{"Add":{"text":" for (int j = imin[1]; j < imax[1]; ++j) {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2068"}},{"Add":{"text":" // #pragma omp simd reduction(red : reduction_CCTK_REAL)","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2131"}},{"Add":{"text":" for (int i = imin[0]; i < imax[0]; ++i) {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2179"}},{"Add":{"text":" bool is_masked = finemask && (*finemask)(i, j, k);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2238"}},{"Add":{"text":" if (!is_masked)","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2262"}},{"Add":{"text":" red += reduction(dV, vars(i, j, k, n));","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2315"}},{"Add":{"text":" }","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2323"}},{"Add":{"text":" }","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2329"}},{"Add":{"text":" }","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2333"}}],"del_contents":[{"Del":{"text":" grid.loop_idx(","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9229"}},{"Del":{"text":" where_t::interior, groupdata.indextype, [&](const Loop::PointDesc &p) {","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9307"}},{"Del":{"text":" if (!finemask_array4 || !(*finemask_array4)(grid.cactus_offset.x + p.i,","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9387"}},{"Del":{"text":" grid.cactus_offset.y + p.j,","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9467"}},{"Del":{"text":" grid.cactus_offset.z + p.k))","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9548"}},{"Del":{"text":" red = reduction(red, reduction(dV, ptr_(p.I)));","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9612"}},{"Del":{"text":" });","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9622"}},{"Del":{"text":"","pos":"FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC:9756"}}]}},{"Edit":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":102,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":1708}],"down_context":[{"change":3,"pos":1708}],"flag":"BLOCK","start":2335,"end":2350,"inode":{"change":3,"pos":870}}},"contents":[{"Add":{"text":"} // namespace","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2349"}}]}},{"Edit":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":114,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3683},"to":{"change":3,"start":3683,"end":3754},"introduced_by":3}],"inode":{"change":3,"pos":870}}},"contents":[{"Del":{"text":" const auto &restrict geom = ghext->amrcore->Geom(leveldata.level);","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:3753"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":116,"ins":{"up_context":[{"change":3,"pos":3870}],"down_context":[{"change":3,"pos":2241}],"flag":"BLOCK","start":2351,"end":2393,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3870},"to":{"change":3,"start":3870,"end":3906},"introduced_by":3}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":" unique_ptr finemask_imfab;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2392"}}],"del_contents":[{"Del":{"text":" unique_ptr finemask;","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:3905"}}]}},{"Edit":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":123,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":3467}],"down_context":[{"change":3,"pos":3473}],"flag":"BLOCK","start":2394,"end":2595,"inode":{"change":3,"pos":870}}},"contents":[{"Add":{"text":"","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2394"}},{"Add":{"text":" const auto &restrict geom = ghext->amrcore->Geom(leveldata.level);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2465"}},{"Add":{"text":" const CCTK_REAL *restrict dx = geom.CellSize();","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2517"}},{"Add":{"text":" CCTK_REAL dV = 1.0;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2541"}},{"Add":{"text":" for (int d = 0; d < dim; ++d)","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2575"}},{"Add":{"text":" dV *= dx[d];","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2594"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":137,"ins":{"up_context":[{"change":3,"pos":4264}],"down_context":[{"change":3,"pos":4305}],"flag":"BLOCK","start":2596,"end":2643,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4264},"to":{"change":3,"start":4264,"end":4305},"introduced_by":3}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":" finemask_imfab = make_unique(","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2642"}}],"del_contents":[{"Del":{"text":" finemask = make_unique(","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:4304"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":144,"ins":{"up_context":[{"change":3,"pos":4546}],"down_context":[{"change":3,"pos":4814}],"flag":"BLOCK","start":2644,"end":3014,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4546},"to":{"change":3,"start":4546,"end":4619},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4619},"to":{"change":2,"start":9675,"end":9727},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":9727},"to":{"change":3,"start":4659,"end":4814},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4659},"to":{"change":3,"start":4659,"end":4814},"introduced_by":3}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":" for (MFIter mfi(mfab, mfitinfo); mfi.isValid(); ++mfi) {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2704"}},{"Add":{"text":" const Box &bx = mfi.tilebox(); // current region (without ghosts)","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2776"}},{"Add":{"text":" const array imin{bx.smallEnd(0), bx.smallEnd(1),","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2841"}},{"Add":{"text":" bx.smallEnd(2)};","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2891"}},{"Add":{"text":" const array imax{bx.bigEnd(0) + 1, bx.bigEnd(1) + 1,","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:2960"}},{"Add":{"text":" bx.bigEnd(2) + 1};","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3012"}},{"Add":{"text":"","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3013"}}],"del_contents":[{"Del":{"text":" for (MFIter mfi(*leveldata.mfab0, mfitinfo); mfi.isValid(); ++mfi) {","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:4618"}},{"Del":{"text":" GridPtrDesc1 grid(leveldata, groupdata, mfi);","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9726"}},{"Del":{"text":" unique_ptr > finemask_array4;","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:4712"}},{"Del":{"text":" if (finemask)","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:4732"}},{"Del":{"text":" finemask_array4 = make_unique >(finemask->array(mfi));","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:4813"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":152,"ins":{"up_context":[{"change":3,"pos":4875}],"down_context":[{"change":3,"pos":2713}],"flag":"BLOCK","start":3015,"end":3239,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4875},"to":{"change":2,"start":9728,"end":9870},"introduced_by":2}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":"","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3015"}},{"Add":{"text":" unique_ptr > finemask;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3062"}},{"Add":{"text":" if (finemask_imfab)","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3088"}},{"Add":{"text":" finemask = make_unique >(finemask_imfab->array(mfi));","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3168"}},{"Add":{"text":"","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3169"}},{"Add":{"text":" red += reduce_array(vars, vi, imin, imax, finemask.get(), dV);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3238"}}],"del_contents":[{"Del":{"text":" const GF3D1 ptr_ = grid.gf3d(vars, vi);","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9790"}},{"Del":{"text":" red += reduce_array(geom, groupdata, grid, ptr_, finemask_array4.get());","pos":"BJDGFYBMECTJG7BHLNHLSCUCBVYHAY6OGY37FIJP6JDGNDXQNQVAC:9869"}}]}},{"Edit":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":161,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":5013}],"down_context":[{"change":3,"pos":5013}],"flag":"BLOCK","start":3240,"end":3303,"inode":{"change":3,"pos":870}}},"contents":[{"Add":{"text":" MPI_Datatype datatype = reduction_mpi_datatype();","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3302"}}]}},{"Replacement":{"inode":{"change":3,"pos":870},"path":"CarpetX/src/reduction.cxx","line":163,"ins":{"up_context":[{"change":3,"pos":5047}],"down_context":[{"change":3,"pos":5119}],"flag":"BLOCK","start":3304,"end":3374,"inode":{"change":3,"pos":870}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":5047},"to":{"change":3,"start":5047,"end":5119},"introduced_by":3}],"inode":{"change":3,"pos":870}},"ins_contents":[{"Add":{"text":" MPI_Allreduce(MPI_IN_PLACE, &red, 1, datatype, op, MPI_COMM_WORLD);","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3373"}}],"del_contents":[{"Del":{"text":" MPI_Allreduce(MPI_IN_PLACE, &red, 1, MPI_DOUBLE, op, MPI_COMM_WORLD);","pos":"5XGIB7XMEZNBLA5ZLQTXRTC3AZ5CTRGMXWBPVMWXG4DPHKWDF4ZAC:5118"}}]}},{"Edit":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":16,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2859}],"down_context":[{"change":3,"pos":2859}],"flag":"BLOCK","start":3375,"end":3394,"inode":{"change":3,"pos":2777}}},"contents":[{"Add":{"text":"#include ","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3393"}}]}},{"Edit":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":20,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2899}],"down_context":[{"change":3,"pos":2899}],"flag":"BLOCK","start":3395,"end":3738,"inode":{"change":3,"pos":2777}}},"contents":[{"Add":{"text":"","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3395"}},{"Add":{"text":"template struct mpi_datatype;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3438"}},{"Add":{"text":"template <> struct mpi_datatype {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3479"}},{"Add":{"text":" static constexpr MPI_Datatype value = MPI_FLOAT;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3530"}},{"Add":{"text":"};","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3533"}},{"Add":{"text":"template <> struct mpi_datatype {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3575"}},{"Add":{"text":" static constexpr MPI_Datatype value = MPI_DOUBLE;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3627"}},{"Add":{"text":"};","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3630"}},{"Add":{"text":"template <> struct mpi_datatype {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3677"}},{"Add":{"text":" static constexpr MPI_Datatype value = MPI_LONG_DOUBLE;","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3734"}},{"Add":{"text":"};","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3737"}}]}},{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":33,"ins":{"up_context":[{"change":3,"pos":42}],"down_context":[{"change":3,"pos":63}],"flag":"BLOCK","start":3739,"end":3771,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":42},"to":{"change":3,"start":42,"end":63},"introduced_by":3}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":" if (CCTK_isnan(CCTK_REAL(x)))","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3770"}}],"del_contents":[{"Del":{"text":" if (CCTK_isnan(x))","pos":"JD6PQOJ6YYNQYEEWEXO2NM7NVYNBUI6V7ZU6Q3FNHGAT2VYOF5WAC:62"}}]}},{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":35,"ins":{"up_context":[{"change":3,"pos":77}],"down_context":[{"change":3,"pos":98}],"flag":"BLOCK","start":3772,"end":3804,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":77},"to":{"change":3,"start":77,"end":98},"introduced_by":3}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":" if (CCTK_isnan(CCTK_REAL(y)))","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3803"}}],"del_contents":[{"Del":{"text":" if (CCTK_isnan(y))","pos":"JD6PQOJ6YYNQYEEWEXO2NM7NVYNBUI6V7ZU6Q3FNHGAT2VYOF5WAC:97"}}]}},{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":40,"ins":{"up_context":[{"change":3,"pos":177}],"down_context":[{"change":3,"pos":198}],"flag":"BLOCK","start":3805,"end":3837,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":177},"to":{"change":3,"start":177,"end":198},"introduced_by":3}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":" if (CCTK_isnan(CCTK_REAL(x)))","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3836"}}],"del_contents":[{"Del":{"text":" if (CCTK_isnan(x))","pos":"JD6PQOJ6YYNQYEEWEXO2NM7NVYNBUI6V7ZU6Q3FNHGAT2VYOF5WAC:197"}}]}},{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":42,"ins":{"up_context":[{"change":3,"pos":212}],"down_context":[{"change":3,"pos":233}],"flag":"BLOCK","start":3838,"end":3870,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":212},"to":{"change":3,"start":212,"end":233},"introduced_by":3}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":" if (CCTK_isnan(CCTK_REAL(y)))","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3869"}}],"del_contents":[{"Del":{"text":" if (CCTK_isnan(y))","pos":"JD6PQOJ6YYNQYEEWEXO2NM7NVYNBUI6V7ZU6Q3FNHGAT2VYOF5WAC:232"}}]}},{"Edit":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":64,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":4670}],"down_context":[{"change":3,"pos":3249}],"flag":"BLOCK","start":3871,"end":4213,"inode":{"change":3,"pos":2777}}},"contents":[{"Add":{"text":"","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3871"}},{"Add":{"text":" friend ostream &operator<<(ostream &os, const reduction &red) {","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:3937"}},{"Add":{"text":" return os << \"reduction{min:\" << red.min << \",max:\" << red.max","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:4004"}},{"Add":{"text":" << \",sum:\" << red.sum << \",sum2:\" << red.sum2","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:4064"}},{"Add":{"text":" << \",vol:\" << red.vol << \",maxabs:\" << red.maxabs","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:4128"}},{"Add":{"text":" << \",sumabs:\" << red.sumabs << \",sum2abs:\" << red.sum2abs << \"}\";","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:4208"}},{"Add":{"text":" }","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:4212"}}]}},{"Edit":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":93,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":5141}],"down_context":[{"change":3,"pos":5141}],"flag":"BLOCK","start":4214,"end":4263,"inode":{"change":3,"pos":2777}}},"contents":[{"Add":{"text":"MPI_Datatype reduction_mpi_datatype_CCTK_REAL();","pos":"I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC:4262"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review