{"header":{"message":"CarpetX: Add constexpr to reduction functions\n","description":null,"timestamp":"2020-06-05T13:48:54Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC","authors":[],"deps":{"hashes":[["IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC","CarpetX: Add constexpr to reduction functions\n"],["AA",null],["NUOLOGCKMF5UOBGBYEOX4O7NQ5AEVVLCH6KRBQRJQXIRDNJ2C2ZQC","Significant development. Add Silo I/O format.\n"],["FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","AMR with point charge\n"],["I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC","Correct reduction operators\n"],["VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC","Implement reduction operations\n"],["OXDROTMRIJ42WSAJSZAZSDM2LDRDIBQH62VUGNAIID5BMWN3VETQC","CarpetX: Correct L2 norm (ouch)\n"],["KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC","AMR works\n"]],"deps":["NUOLOGCKMF5UOBGBYEOX4O7NQ5AEVVLCH6KRBQRJQXIRDNJ2C2ZQC"],"known":["VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC","KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC","FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","I4P6OKQG6OD3JX2KV23QLKMG7DSNYMTYUZCIOKNPTHOFHOFLMSNAC","OXDROTMRIJ42WSAJSZAZSDM2LDRDIBQH62VUGNAIID5BMWN3VETQC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":35,"ins":{"up_context":[{"change":3,"pos":1}],"down_context":[{"change":3,"pos":2899}],"flag":"BLOCK","start":0,"end":72,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1},"to":{"change":3,"start":1,"end":54},"introduced_by":3}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":"template constexpr T pow21(T x) noexcept { return x * x; }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:71"}}],"del_contents":[{"Del":{"text":"template T pow21(T x) { return x * x; }","pos":"OXDROTMRIJ42WSAJSZAZSDM2LDRDIBQH62VUGNAIID5BMWN3VETQC:53"}}]}},{"Edit":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":57,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":4354},"to":{"change":3,"start":3002,"end":3017},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":2,"pos":29478},"to":{"change":3,"start":3002,"end":3017},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3002},"to":{"change":3,"start":3002,"end":3017},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3017},"to":{"change":2,"start":29479,"end":29537},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":3,"pos":4392},"to":{"change":3,"start":3042,"end":3249},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":2,"pos":29537},"to":{"change":3,"start":3042,"end":3249},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3042},"to":{"change":3,"start":3042,"end":3249},"introduced_by":3}],"inode":{"change":3,"pos":2777}}},"contents":[{"Del":{"text":" reduction();","pos":"VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC:3016"}},{"Del":{"text":" reduction(const vect &p, const T &V, const T &x);","pos":"NUOLOGCKMF5UOBGBYEOX4O7NQ5AEVVLCH6KRBQRJQXIRDNJ2C2ZQC:29536"}},{"Del":{"text":" reduction(const reduction &x, const reduction &y);","pos":"VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC:3094"}},{"Del":{"text":" reduction operator+(const reduction &y) const { return reduction(*this, y); }","pos":"VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC:3174"}},{"Del":{"text":" reduction &operator+=(const reduction &y) { return *this = *this + y; }","pos":"VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC:3248"}}]}},{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":58,"ins":{"up_context":[{"change":3,"pos":4394}],"down_context":[{"change":3,"pos":3871}],"flag":"BLOCK","start":73,"end":424,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4394},"to":{"change":3,"start":4394,"end":4432},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4432},"to":{"change":3,"start":55,"end":126},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":126},"to":{"change":3,"start":4503,"end":4670},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":10239},"to":{"change":3,"start":4503,"end":4670},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4503},"to":{"change":3,"start":4503,"end":4670},"introduced_by":3}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":" constexpr reduction();","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:97"}},{"Add":{"text":" constexpr reduction(const vect &p, const T &V, const T &x);","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:165"}},{"Add":{"text":" constexpr reduction(const reduction &x, const reduction &y);","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:228"}},{"Add":{"text":" constexpr reduction operator+(const reduction &y) const {","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:288"}},{"Add":{"text":" return reduction(*this, y);","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:320"}},{"Add":{"text":" }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:324"}},{"Add":{"text":" constexpr reduction &operator+=(const reduction &y) noexcept {","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:389"}},{"Add":{"text":" return *this = *this + y;","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:419"}},{"Add":{"text":" }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:423"}}],"del_contents":[{"Del":{"text":" T avg() const { return sum / vol; }","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4431"}},{"Del":{"text":" T sdv() const { return sqrt(fmax1(T(0), vol * sum2 - pow21(sum))); }","pos":"OXDROTMRIJ42WSAJSZAZSDM2LDRDIBQH62VUGNAIID5BMWN3VETQC:125"}},{"Del":{"text":" T norm0() const { return vol; }","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4536"}},{"Del":{"text":" T norm1() const { return sumabs / vol; }","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4579"}},{"Del":{"text":" T norm2() const { return sqrt(sum2abs / vol); }","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4629"}},{"Del":{"text":" T norm_inf() const { return maxabs; }","pos":"KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC:4669"}}]}},{"Edit":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":68,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":3872}],"down_context":[{"change":2,"pos":29538}],"flag":"BLOCK","start":425,"end":822,"inode":{"change":3,"pos":2777}}},"contents":[{"Add":{"text":" constexpr T avg() const noexcept { return sum / vol; }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:481"}},{"Add":{"text":" constexpr T sdv() const noexcept {","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:518"}},{"Add":{"text":" return sqrt(fmax1(T(0), vol * sum2 - pow21(sum)));","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:573"}},{"Add":{"text":" }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:577"}},{"Add":{"text":" constexpr T norm0() const noexcept { return vol; }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:630"}},{"Add":{"text":" constexpr T norm1() const noexcept { return sumabs / vol; }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:692"}},{"Add":{"text":" constexpr T norm2() const noexcept { return sqrt(sum2abs / vol); }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:761"}},{"Add":{"text":" constexpr T norm_inf() const noexcept { return maxabs; }","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:820"}},{"Add":{"text":"","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:821"}}]}},{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":82,"ins":{"up_context":[{"change":2,"pos":29674}],"down_context":[{"change":3,"pos":4671}],"flag":"BLOCK","start":823,"end":862,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":29674},"to":{"change":2,"start":29674,"end":29703},"introduced_by":2}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":"constexpr reduction::reduction()","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:861"}}],"del_contents":[{"Del":{"text":"reduction::reduction()","pos":"NUOLOGCKMF5UOBGBYEOX4O7NQ5AEVVLCH6KRBQRJQXIRDNJ2C2ZQC:29702"}}]}},{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":89,"ins":{"up_context":[{"change":2,"pos":29863}],"down_context":[{"change":3,"pos":127}],"flag":"BLOCK","start":863,"end":982,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":29863},"to":{"change":2,"start":29863,"end":29935},"introduced_by":2}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":"constexpr reduction::reduction(const vect &p, const T &V,","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:932"}},{"Add":{"text":" const T &x)","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:981"}}],"del_contents":[{"Del":{"text":"reduction::reduction(const vect &p, const T &V, const T &x)","pos":"NUOLOGCKMF5UOBGBYEOX4O7NQ5AEVVLCH6KRBQRJQXIRDNJ2C2ZQC:29934"}}]}},{"Replacement":{"inode":{"change":3,"pos":2777},"path":"CarpetX/src/reduction.hxx","line":95,"ins":{"up_context":[{"change":2,"pos":30046}],"down_context":[{"change":3,"pos":10380}],"flag":"BLOCK","start":983,"end":1060,"inode":{"change":3,"pos":2777}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":30046},"to":{"change":2,"start":30046,"end":30113},"introduced_by":2}],"inode":{"change":3,"pos":2777}},"ins_contents":[{"Add":{"text":"constexpr reduction::reduction(const reduction &x, const reduction &y)","pos":"IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC:1059"}}],"del_contents":[{"Del":{"text":"reduction::reduction(const reduction &x, const reduction &y)","pos":"NUOLOGCKMF5UOBGBYEOX4O7NQ5AEVVLCH6KRBQRJQXIRDNJ2C2ZQC:30112"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review