{"header":{"message":"CarpetX: fix using unique_ptr with free()\n","description":null,"timestamp":"2020-01-01T21:13:38Z","authors":[{"email":"rhaas@tapir.caltech.edu","name":"Roland Haas"}]},"hash":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC","authors":[],"deps":{"hashes":[["KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC","CarpetX: fix using unique_ptr with free()\n"],["AA",null],["BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC","CarpetX: use uniqe_ptr for strings\n"],["OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC","Output all levels into a single file\n"],["FS7Q6TUHBK5WSRDC3TM6KV2BPGWATRBLDHFGEJ72BR3FRDEOC3WAC","CarpetX: use nullptr in and unique_ptr to mark invalid groups\n\nboth globals and grid functions have a full CCTK_NumGroups sized vector\nso I mark ones that are of the \"wrong\" type with a nullptr\n"],["M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC","AMReX: add support for grid scalars\n\nfirst version that compiles, untested otherwise, has a couple of\nsub-optimal choices\n"],["HBZVMDSQU5KSMGZXRL67OERWEDNGTSYJVGV4BFDKKSSSHU4X23AAC","CarpetX: Make restriction more flexible\n"],["WE6MDRN5SPK3THM4COLQFE3IUWBCQ5ZYUIAUCBJAZVEMMOVTNBOAC","Synchronize in the driver\n"],["YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","Staggered grids\n"],["FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","AMR with point charge\n"],["N42E473LAYAM5NC4UXPM6WD37FLCUM26JCCKCARQEMXM7V6GWYNQC","Rewrite ASCII output\n"],["RCLGQ2LZMFVPBPTU2G55DJ6HZPOGGTPZRZCY54VGP6YLHANJ2LAQC","Move I/O to driver. WaveToy is now driver-independent.\n"],["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","Set up cctkGH entries\n"]],"deps":["BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC"],"known":["WE6MDRN5SPK3THM4COLQFE3IUWBCQ5ZYUIAUCBJAZVEMMOVTNBOAC","OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC","FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC","N42E473LAYAM5NC4UXPM6WD37FLCUM26JCCKCARQEMXM7V6GWYNQC","HBZVMDSQU5KSMGZXRL67OERWEDNGTSYJVGV4BFDKKSSSHU4X23AAC","FS7Q6TUHBK5WSRDC3TM6KV2BPGWATRBLDHFGEJ72BR3FRDEOC3WAC"]},"hunks":[{"Replacement":{"inode":{"change":12,"pos":107},"path":"CarpetX/src/io.cxx","line":55,"ins":{"up_context":[{"change":3,"pos":4634}],"down_context":[{"change":3,"pos":4703}],"flag":"BLOCK","start":0,"end":103,"inode":{"change":12,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4634},"to":{"change":2,"start":0,"end":71},"introduced_by":2}],"inode":{"change":12,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi), std::free).get();","pos":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC:102"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC:70"}}]}},{"Replacement":{"inode":{"change":12,"pos":107},"path":"CarpetX/src/io.cxx","line":184,"ins":{"up_context":[{"change":3,"pos":298}],"down_context":[{"change":3,"pos":367}],"flag":"BLOCK","start":104,"end":207,"inode":{"change":12,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":298},"to":{"change":2,"start":72,"end":143},"introduced_by":2}],"inode":{"change":12,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi), std::free).get();","pos":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC:206"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC:142"}}]}},{"Replacement":{"inode":{"change":12,"pos":107},"path":"CarpetX/src/io.cxx","line":304,"ins":{"up_context":[{"change":3,"pos":4367}],"down_context":[{"change":3,"pos":4434}],"flag":"BLOCK","start":208,"end":308,"inode":{"change":12,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4367},"to":{"change":2,"start":144,"end":213},"introduced_by":2}],"inode":{"change":12,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi),std::free).get();","pos":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC:307"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi)).get();","pos":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC:212"}}]}},{"Replacement":{"inode":{"change":13,"pos":531},"path":"CarpetX/src/schedule.cxx","line":1869,"ins":{"up_context":[{"change":3,"pos":17648}],"down_context":[{"change":3,"pos":17712}],"flag":"BLOCK","start":309,"end":407,"inode":{"change":13,"pos":531}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":17648},"to":{"change":2,"start":214,"end":281},"introduced_by":2}],"inode":{"change":13,"pos":531}},"ins_contents":[{"Add":{"text":" buf << unique_ptr(CCTK_GroupName(groups0[n]),std::free).get();","pos":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC:406"}}],"del_contents":[{"Del":{"text":" buf << unique_ptr(CCTK_GroupName(groups0[n])).get();","pos":"BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC:280"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review