{"header":{"message":"AMReX: Simplify comparison operators\n","description":null,"timestamp":"2019-10-18T19:26:46Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC","authors":[],"deps":{"hashes":[["KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC","AMReX: Simplify comparison operators\n"],["AA",null],["OHAARXLBTFOIV5FOTY7IDMOIAE275CKXCE6XQMWV3EC63YCSMIWAC","AMReX: Introduce multi-vector data type\n"],["XRNTOOZ6ARR4XK7GNGUZKHFKB5NDW3WU4I32QKJH6ADFHZQG55CAC","AMReX: Correct operator< for clause_t\n\nThis might have affected correctness.\n"],["TOBGHRPKEPSXDN56WGSZNWOMCBVJ4KUSLWYWI56MC2RR3MM3KLZAC","Restrict during evolution\n"],["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","Set up cctkGH entries\n"],["BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC","Keep track of which regions of which variables have valid data.\n\nAlso correct all respective bugs.\n"],["KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC","AMR works\n"],["IL5XPFSWQX3OWZHEUSDP3R2IKVWHHOI6MNNBKU3P6MNBT6MVYJ2QC","AMReX: Remove parser for schedule clauses\n"],["722HZ7UFINNE3YKSYKP2NHZ5XEG5QQLQHSKC7PREJZR3EX6RDYUAC","Import initial AMReX driver for Cactus\n"],["RCLGQ2LZMFVPBPTU2G55DJ6HZPOGGTPZRZCY54VGP6YLHANJ2LAQC","Move I/O to driver. WaveToy is now driver-independent.\n"],["FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","AMR with point charge\n"]],"deps":["OHAARXLBTFOIV5FOTY7IDMOIAE275CKXCE6XQMWV3EC63YCSMIWAC","XRNTOOZ6ARR4XK7GNGUZKHFKB5NDW3WU4I32QKJH6ADFHZQG55CAC"],"known":["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","KG47IF4CPCUT3BHS34WDRHTH5HYMBTY4OSTB3X7APR2E5ZJ32IYQC","TOBGHRPKEPSXDN56WGSZNWOMCBVJ4KUSLWYWI56MC2RR3MM3KLZAC","BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC","IL5XPFSWQX3OWZHEUSDP3R2IKVWHHOI6MNNBKU3P6MNBT6MVYJ2QC"]},"hunks":[{"Edit":{"inode":{"change":10,"pos":15275},"path":"AMReX/src/driver.hxx","line":22,"atom":{"NewVertex":{"up_context":[{"change":10,"pos":15516}],"down_context":[{"change":11,"pos":0}],"flag":"BLOCK","start":0,"end":17,"inode":{"change":10,"pos":15275}}},"contents":[{"Add":{"text":"#include ","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:16"}}]}},{"Edit":{"inode":{"change":10,"pos":15275},"path":"AMReX/src/driver.hxx","line":69,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":2292}],"down_context":[{"change":4,"pos":2292}],"flag":"BLOCK","start":18,"end":185,"inode":{"change":10,"pos":15275}}},"contents":[{"Add":{"text":" friend bool operator==(const valid_t &x, const valid_t &y) {","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:80"}},{"Add":{"text":" return make_tuple(x.valid_int, x.valid_bnd) ==","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:131"}},{"Add":{"text":" make_tuple(y.valid_int, y.valid_bnd);","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:180"}},{"Add":{"text":" }","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:184"}}]}},{"Replacement":{"inode":{"change":10,"pos":15275},"path":"AMReX/src/driver.hxx","line":74,"ins":{"up_context":[{"change":4,"pos":2354}],"down_context":[{"change":4,"pos":2446}],"flag":"BLOCK","start":186,"end":285,"inode":{"change":10,"pos":15275}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2354},"to":{"change":4,"start":2354,"end":2446},"introduced_by":4}],"inode":{"change":10,"pos":15275}},"ins_contents":[{"Add":{"text":" return make_tuple(x.valid_int, x.valid_bnd) <","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:235"}},{"Add":{"text":" make_tuple(y.valid_int, y.valid_bnd);","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:284"}}],"del_contents":[{"Del":{"text":" if (x.valid_int < y.valid_int)","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:2388"}},{"Del":{"text":" return true;","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:2407"}},{"Del":{"text":" return x.valid_bnd < y.valid_bnd;","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:2445"}}]}},{"Edit":{"inode":{"change":12,"pos":5481},"path":"AMReX/src/loop.hxx","line":16,"atom":{"NewVertex":{"up_context":[{"change":12,"pos":5591}],"down_context":[{"change":12,"pos":5591}],"flag":"BLOCK","start":286,"end":303,"inode":{"change":12,"pos":5481}}},"contents":[{"Add":{"text":"#include ","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:302"}}]}},{"Edit":{"inode":{"change":12,"pos":5481},"path":"AMReX/src/loop.hxx","line":82,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":1263}],"down_context":[{"change":2,"pos":1263}],"flag":"BLOCK","start":304,"end":483,"inode":{"change":12,"pos":5481}}},"contents":[{"Add":{"text":" }","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:307"}},{"Add":{"text":"","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:308"}},{"Add":{"text":" friend bool operator==(const vect &x, const vect &y) {","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:365"}},{"Add":{"text":" return x.elts == y.elts;","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:394"}},{"Add":{"text":" }","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:398"}},{"Add":{"text":" friend bool operator<(const vect &x, const vect &y) {","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:454"}},{"Add":{"text":" return x.elts < y.elts;","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:482"}}]}},{"Edit":{"inode":{"change":4,"pos":531},"path":"AMReX/src/schedule.cxx","line":35,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":785}],"down_context":[{"change":4,"pos":785}],"flag":"BLOCK","start":484,"end":501,"inode":{"change":4,"pos":531}}},"contents":[{"Add":{"text":"#include ","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:500"}}]}},{"Edit":{"inode":{"change":4,"pos":531},"path":"AMReX/src/schedule.cxx","line":568,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":3620}],"down_context":[{"change":4,"pos":3620}],"flag":"BLOCK","start":502,"end":673,"inode":{"change":4,"pos":531}}},"contents":[{"Add":{"text":" friend bool operator==(const clause_t &x, const clause_t &y) {","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:566"}},{"Add":{"text":" return make_tuple(x.gi, x.vi, x.tl, x.valid) ==","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:618"}},{"Add":{"text":" make_tuple(y.gi, y.vi, y.tl, y.valid);","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:668"}},{"Add":{"text":" }","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:672"}}]}},{"Replacement":{"inode":{"change":4,"pos":531},"path":"AMReX/src/schedule.cxx","line":573,"ins":{"up_context":[{"change":4,"pos":3684}],"down_context":[{"change":4,"pos":3834}],"flag":"BLOCK","start":674,"end":775,"inode":{"change":4,"pos":531}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3684},"to":{"change":4,"start":3684,"end":3724},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3724},"to":{"change":3,"start":0,"end":41},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":41},"to":{"change":4,"start":3724,"end":3764},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3724},"to":{"change":4,"start":3724,"end":3764},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3764},"to":{"change":3,"start":42,"end":83},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":83},"to":{"change":4,"start":3764,"end":3804},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3764},"to":{"change":4,"start":3764,"end":3804},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3804},"to":{"change":3,"start":84,"end":125},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":125},"to":{"change":4,"start":3804,"end":3834},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3804},"to":{"change":4,"start":3804,"end":3834},"introduced_by":4}],"inode":{"change":4,"pos":531}},"ins_contents":[{"Add":{"text":" return make_tuple(x.gi, x.vi, x.tl, x.valid) <","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:724"}},{"Add":{"text":" make_tuple(y.gi, y.vi, y.tl, y.valid);","pos":"KOOPA77MHDMNHAKH7YXUD2POVQCT3R2HHDHEFBW3G7MVM7QJQVYAC:774"}}],"del_contents":[{"Del":{"text":" if (x.gi < y.gi)","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:3704"}},{"Del":{"text":" return true;","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:3723"}},{"Del":{"text":" if (x.gi > y.gi)","pos":"XRNTOOZ6ARR4XK7GNGUZKHFKB5NDW3WU4I32QKJH6ADFHZQG55CAC:20"}},{"Del":{"text":" return false;","pos":"XRNTOOZ6ARR4XK7GNGUZKHFKB5NDW3WU4I32QKJH6ADFHZQG55CAC:40"}},{"Del":{"text":" if (x.vi < y.vi)","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:3744"}},{"Del":{"text":" return true;","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:3763"}},{"Del":{"text":" if (x.vi > y.vi)","pos":"XRNTOOZ6ARR4XK7GNGUZKHFKB5NDW3WU4I32QKJH6ADFHZQG55CAC:62"}},{"Del":{"text":" return false;","pos":"XRNTOOZ6ARR4XK7GNGUZKHFKB5NDW3WU4I32QKJH6ADFHZQG55CAC:82"}},{"Del":{"text":" if (x.tl < y.tl)","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:3784"}},{"Del":{"text":" return true;","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:3803"}},{"Del":{"text":" if (x.tl > y.tl)","pos":"XRNTOOZ6ARR4XK7GNGUZKHFKB5NDW3WU4I32QKJH6ADFHZQG55CAC:104"}},{"Del":{"text":" return false;","pos":"XRNTOOZ6ARR4XK7GNGUZKHFKB5NDW3WU4I32QKJH6ADFHZQG55CAC:124"}},{"Del":{"text":" return x.valid < y.valid;","pos":"BPRNUTY7MHK7LK4EY5MY5OFFG3ABOL7LWXD574L35M74YSQPULFAC:3833"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review