{"header":{"message":"CarpetX: introduce unique_C_ptr\n","description":null,"timestamp":"2020-01-01T22:25:20Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC","authors":[],"deps":{"hashes":[["M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC","CarpetX: introduce unique_C_ptr\n"],["AA",null],["KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC","CarpetX: fix using unique_ptr with free()\n"],["OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC","Output all levels into a single file\n"],["FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","AMR with point charge\n"],["YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","Staggered grids\n"],["N42E473LAYAM5NC4UXPM6WD37FLCUM26JCCKCARQEMXM7V6GWYNQC","Rewrite ASCII output\n"],["M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC","AMReX: add support for grid scalars\n\nfirst version that compiles, untested otherwise, has a couple of\nsub-optimal choices\n"],["FS7Q6TUHBK5WSRDC3TM6KV2BPGWATRBLDHFGEJ72BR3FRDEOC3WAC","CarpetX: use nullptr in and unique_ptr to mark invalid groups\n\nboth globals and grid functions have a full CCTK_NumGroups sized vector\nso I mark ones that are of the \"wrong\" type with a nullptr\n"],["WE6MDRN5SPK3THM4COLQFE3IUWBCQ5ZYUIAUCBJAZVEMMOVTNBOAC","Synchronize in the driver\n"],["HBZVMDSQU5KSMGZXRL67OERWEDNGTSYJVGV4BFDKKSSSHU4X23AAC","CarpetX: Make restriction more flexible\n"],["BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC","CarpetX: use uniqe_ptr for strings\n"],["722HZ7UFINNE3YKSYKP2NHZ5XEG5QQLQHSKC7PREJZR3EX6RDYUAC","Import initial AMReX driver for Cactus\n"],["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","Set up cctkGH entries\n"],["RCLGQ2LZMFVPBPTU2G55DJ6HZPOGGTPZRZCY54VGP6YLHANJ2LAQC","Move I/O to driver. WaveToy is now driver-independent.\n"]],"deps":["KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC"],"known":["WE6MDRN5SPK3THM4COLQFE3IUWBCQ5ZYUIAUCBJAZVEMMOVTNBOAC","OJZWEAJRLOA5FZAC6FMGBQ6XFQFDNO55IRWLFWDAYWM54MUIU5LAC","FEMASUBNU32NSG4DNXZX54CGCA57PVRGYO46L3A6F2EJ4BCSJ3SAC","YIQN7NJTGEVKW7JZHL6CTH6EPCIXCNBYNURIGXPYZAOUX3VAJQMAC","M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC","N42E473LAYAM5NC4UXPM6WD37FLCUM26JCCKCARQEMXM7V6GWYNQC","HBZVMDSQU5KSMGZXRL67OERWEDNGTSYJVGV4BFDKKSSSHU4X23AAC","FS7Q6TUHBK5WSRDC3TM6KV2BPGWATRBLDHFGEJ72BR3FRDEOC3WAC","BQW37JNPOOQ5E3J5BSTIB4SIUNFCD5KM36LSEU2EBCLOEWZBESVQC"]},"hunks":[{"Edit":{"inode":{"change":13,"pos":15275},"path":"CarpetX/src/driver.hxx","line":32,"atom":{"NewVertex":{"up_context":[{"change":14,"pos":1}],"down_context":[{"change":14,"pos":1}],"flag":"BLOCK","start":0,"end":427,"inode":{"change":13,"pos":15275}}},"contents":[{"Add":{"text":"// Taken from","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:13"}},{"Add":{"text":"// ","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:108"}},{"Add":{"text":"struct free_deleter {","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:130"}},{"Add":{"text":" template void operator()(T *p) const {","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:184"}},{"Add":{"text":" std::free(const_cast *>(p));","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:240"}},{"Add":{"text":" }","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:244"}},{"Add":{"text":"};","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:247"}},{"Add":{"text":"template using unique_C_ptr = std::unique_ptr;","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:324"}},{"Add":{"text":"static_assert(sizeof(char *) == sizeof(unique_C_ptr),","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:384"}},{"Add":{"text":" \"\"); // ensure no overhead","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:425"}},{"Add":{"text":"","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:426"}}]}},{"Replacement":{"inode":{"change":15,"pos":107},"path":"CarpetX/src/io.cxx","line":55,"ins":{"up_context":[{"change":3,"pos":4634}],"down_context":[{"change":3,"pos":4703}],"flag":"BLOCK","start":428,"end":499,"inode":{"change":15,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4634},"to":{"change":2,"start":0,"end":103},"introduced_by":2}],"inode":{"change":15,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_C_ptr(CCTK_GroupName(gi)).get();","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:498"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi), std::free).get();","pos":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC:102"}}]}},{"Replacement":{"inode":{"change":15,"pos":107},"path":"CarpetX/src/io.cxx","line":184,"ins":{"up_context":[{"change":3,"pos":298}],"down_context":[{"change":3,"pos":367}],"flag":"BLOCK","start":500,"end":571,"inode":{"change":15,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":298},"to":{"change":2,"start":104,"end":207},"introduced_by":2}],"inode":{"change":15,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_C_ptr(CCTK_GroupName(gi)).get();","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:570"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi), std::free).get();","pos":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC:206"}}]}},{"Replacement":{"inode":{"change":15,"pos":107},"path":"CarpetX/src/io.cxx","line":304,"ins":{"up_context":[{"change":3,"pos":4367}],"down_context":[{"change":3,"pos":4434}],"flag":"BLOCK","start":572,"end":641,"inode":{"change":15,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4367},"to":{"change":2,"start":208,"end":308},"introduced_by":2}],"inode":{"change":15,"pos":107}},"ins_contents":[{"Add":{"text":" string groupname = unique_C_ptr(CCTK_GroupName(gi)).get();","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:640"}}],"del_contents":[{"Del":{"text":" string groupname = unique_ptr(CCTK_GroupName(gi),std::free).get();","pos":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC:307"}}]}},{"Replacement":{"inode":{"change":14,"pos":531},"path":"CarpetX/src/schedule.cxx","line":1869,"ins":{"up_context":[{"change":3,"pos":17648}],"down_context":[{"change":3,"pos":17712}],"flag":"BLOCK","start":642,"end":709,"inode":{"change":14,"pos":531}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":17648},"to":{"change":2,"start":309,"end":407},"introduced_by":2}],"inode":{"change":14,"pos":531}},"ins_contents":[{"Add":{"text":" buf << unique_C_ptr(CCTK_GroupName(groups0[n])).get();","pos":"M7FZ5YH4U6TXWMCSM6A5GDXXUH636DROLQJPZV5SG52IR7227VJQC:708"}}],"del_contents":[{"Del":{"text":" buf << unique_ptr(CCTK_GroupName(groups0[n]),std::free).get();","pos":"KJSF54YTAY3FMPYFLPRFP3Y7LQWLQKSUO7JARUPHLJJMXRVXSRGAC:406"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review