{"header":{"message":"ODESolvers: Don't \"using namespace amrex\"\n","description":null,"timestamp":"2020-06-06T00:59:00Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC","authors":[],"deps":{"hashes":[["NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC","ODESolvers: Don't \"using namespace amrex\"\n"],["AA",null],["NUOLOGCKMF5UOBGBYEOX4O7NQ5AEVVLCH6KRBQRJQXIRDNJ2C2ZQC","Significant development. Add Silo I/O format.\n"],["P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC","ODESolvers: Implement Euler and RK2 ODE integrators\n"],["C5HNSRT5Y5MZXF7LXXRXLI7743BRK57JNHOJZPQ77WMVRCXA5MLAC","ODESolvers: Correct thorn name\n"],["V37ACC7MAD57VQOKAT5FBO2ITNX73AWD2DUEIHMF7UPKV63YRTQAC","ODESolvers: Read RHS variables from interface.ccl\n"],["2BSBB53DVGURXHAIBJQI2YO6V42HYBLMF5IULSCYMZQPN4EH7IMQC","ODESolvers: Check whether state vector and RHS contain valid data\n"],["3BFBGMNXEPJUUTSJDJ222PQATNDNX4GGRJA2PZBPMWFMG2ZRGH2AC","ODESolvers: Correct severe looping buf\n"]],"deps":["NUOLOGCKMF5UOBGBYEOX4O7NQ5AEVVLCH6KRBQRJQXIRDNJ2C2ZQC"],"known":["P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC","C5HNSRT5Y5MZXF7LXXRXLI7743BRK57JNHOJZPQ77WMVRCXA5MLAC","V37ACC7MAD57VQOKAT5FBO2ITNX73AWD2DUEIHMF7UPKV63YRTQAC","2BSBB53DVGURXHAIBJQI2YO6V42HYBLMF5IULSCYMZQPN4EH7IMQC","3BFBGMNXEPJUUTSJDJ222PQATNDNX4GGRJA2PZBPMWFMG2ZRGH2AC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":541},"path":"ODESolvers/src/solve.cxx","line":1,"ins":{"up_context":[{"change":3,"pos":541}],"down_context":[{"change":3,"pos":582}],"flag":"BLOCK","start":0,"end":82,"inode":{"change":3,"pos":541}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":541},"to":{"change":3,"start":542,"end":582},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":582},"to":{"change":3,"start":71,"end":113},"introduced_by":3}],"inode":{"change":3,"pos":541}},"ins_contents":[{"Add":{"text":"#include \"../../CarpetX/src/driver.hxx\"","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:39"}},{"Add":{"text":"#include \"../../CarpetX/src/schedule.hxx\"","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:81"}}],"del_contents":[{"Del":{"text":"#include <../../CarpetX/src/driver.hxx>","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:581"}},{"Del":{"text":"#include <../../CarpetX/src/schedule.hxx>","pos":"2BSBB53DVGURXHAIBJQI2YO6V42HYBLMF5IULSCYMZQPN4EH7IMQC:112"}}]}},{"Edit":{"inode":{"change":3,"pos":541},"path":"ODESolvers/src/solve.cxx","line":19,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":815},"to":{"change":3,"start":815,"end":838},"introduced_by":3}],"inode":{"change":3,"pos":541}}},"contents":[{"Del":{"text":"using namespace amrex;","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:837"}}]}},{"Replacement":{"inode":{"change":3,"pos":541},"path":"ODESolvers/src/solve.cxx","line":28,"ins":{"up_context":[{"change":3,"pos":53}],"down_context":[{"change":3,"pos":1067}],"flag":"BLOCK","start":83,"end":118,"inode":{"change":3,"pos":541}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":204},"to":{"change":3,"start":1039,"end":1067},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":53},"to":{"change":3,"start":1039,"end":1067},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":185},"to":{"change":3,"start":1039,"end":1067},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1039},"to":{"change":3,"start":1039,"end":1067},"introduced_by":3}],"inode":{"change":3,"pos":541}},"ins_contents":[{"Add":{"text":" vector mfabs;","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:117"}}],"del_contents":[{"Del":{"text":" vector mfabs;","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:1066"}}]}},{"Replacement":{"inode":{"change":3,"pos":541},"path":"ODESolvers/src/solve.cxx","line":32,"ins":{"up_context":[{"change":3,"pos":1148}],"down_context":[{"change":3,"pos":1193}],"flag":"BLOCK","start":119,"end":171,"inode":{"change":3,"pos":541}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1148},"to":{"change":3,"start":1148,"end":1193},"introduced_by":3}],"inode":{"change":3,"pos":541}},"ins_contents":[{"Add":{"text":" vector > owned_stuff;","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:170"}}],"del_contents":[{"Del":{"text":" vector > owned_stuff;","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:1192"}}]}},{"Replacement":{"inode":{"change":3,"pos":541},"path":"ODESolvers/src/solve.cxx","line":80,"ins":{"up_context":[{"change":2,"pos":44853}],"down_context":[{"change":2,"pos":44854}],"flag":"BLOCK","start":172,"end":391,"inode":{"change":3,"pos":541}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":2,"pos":44853},"to":{"change":3,"start":1847,"end":2045},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":3,"pos":608},"to":{"change":3,"start":1847,"end":2045},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":355},"to":{"change":3,"start":1847,"end":2045},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1847},"to":{"change":3,"start":1847,"end":2045},"introduced_by":3}],"inode":{"change":3,"pos":541}},"ins_contents":[{"Add":{"text":" auto y = make_unique(x->boxArray(), x->DistributionMap(),","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:250"}},{"Add":{"text":" x->nComp(), x->nGrowVect());","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:321"}},{"Add":{"text":" amrex::MultiFab::Copy(*y, *x, 0, 0, y->nComp(), y->nGrowVect());","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:390"}}],"del_contents":[{"Del":{"text":" auto y = make_unique(x->boxArray(), x->DistributionMap(),","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:1918"}},{"Del":{"text":" x->nComp(), x->nGrowVect());","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:1982"}},{"Del":{"text":" MultiFab::Copy(*y, *x, 0, 0, y->nComp(), y->nGrowVect());","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:2044"}}]}},{"Replacement":{"inode":{"change":3,"pos":541},"path":"ODESolvers/src/solve.cxx","line":109,"ins":{"up_context":[{"change":2,"pos":44907}],"down_context":[{"change":2,"pos":44908}],"flag":"BLOCK","start":392,"end":544,"inode":{"change":3,"pos":541}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":2,"pos":44907},"to":{"change":3,"start":2574,"end":2639},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":3,"pos":908},"to":{"change":3,"start":2574,"end":2639},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":724},"to":{"change":3,"start":2574,"end":2639},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2574},"to":{"change":3,"start":2574,"end":2639},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2639},"to":{"change":3,"start":725,"end":798},"introduced_by":3}],"inode":{"change":3,"pos":541}},"ins_contents":[{"Add":{"text":" amrex::MultiFab::Saxpy(*y.mfabs.at(n), alpha, *x.mfabs.at(n), 0, 0,","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:463"}},{"Add":{"text":" y.mfabs.at(n)->nComp(), y.mfabs.at(n)->nGrowVect());","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:543"}}],"del_contents":[{"Del":{"text":" MultiFab::Saxpy(*y.mfabs.at(n), alpha, *x.mfabs.at(n), 0, 0,","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:2638"}},{"Del":{"text":" y.mfabs.at(n)->nComp(), y.mfabs.at(n)->nGrowVect());","pos":"V37ACC7MAD57VQOKAT5FBO2ITNX73AWD2DUEIHMF7UPKV63YRTQAC:797"}}]}},{"Replacement":{"inode":{"change":3,"pos":541},"path":"ODESolvers/src/solve.cxx","line":140,"ins":{"up_context":[{"change":2,"pos":44961}],"down_context":[{"change":2,"pos":44962}],"flag":"BLOCK","start":545,"end":755,"inode":{"change":3,"pos":541}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":2,"pos":44961},"to":{"change":3,"start":3244,"end":3314},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":3,"pos":1395},"to":{"change":3,"start":3244,"end":3314},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":1401},"to":{"change":3,"start":3244,"end":3314},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3244},"to":{"change":3,"start":3244,"end":3314},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3314},"to":{"change":3,"start":1402,"end":1521},"introduced_by":3}],"inode":{"change":3,"pos":541}},"ins_contents":[{"Add":{"text":" amrex::MultiFab::LinComb(*z.mfabs.at(n), alpha, *x.mfabs.at(n), 0, beta,","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:621"}},{"Add":{"text":" *y.mfabs.at(n), 0, 0, z.mfabs.at(n)->nComp(),","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:696"}},{"Add":{"text":" z.mfabs.at(n)->nGrowVect());","pos":"NQMRA4BTFFGDH4NOUKAJISL5KBURT3D5E2B6B5GSG5ZU6VAGHAAQC:754"}}],"del_contents":[{"Del":{"text":" MultiFab::LinComb(*z.mfabs.at(n), alpha, *x.mfabs.at(n), 0, beta,","pos":"P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC:3313"}},{"Del":{"text":" *y.mfabs.at(n), 0, 0, z.mfabs.at(n)->nComp(),","pos":"V37ACC7MAD57VQOKAT5FBO2ITNX73AWD2DUEIHMF7UPKV63YRTQAC:1469"}},{"Del":{"text":" z.mfabs.at(n)->nGrowVect());","pos":"V37ACC7MAD57VQOKAT5FBO2ITNX73AWD2DUEIHMF7UPKV63YRTQAC:1520"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review