{"header":{"message":"ODESolvers: Don't special-case first RHS evaluation\n","description":null,"timestamp":"2020-07-04T19:41:12Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC","authors":[],"deps":{"hashes":[["QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC","ODESolvers: Don't special-case first RHS evaluation\n"],["AA",null],["3NWSBBMPHW3XOWLAMWI2AXX5VQDRHYT7CKGHL32RD6AUAUH67SVAC","ODESolvers: Reduce default verbosity\n"],["LZFLSXT42KHYV4QTY6QCDURY6MD4JX7MXJYU2STJ354WADWI4CCAC","ODESolvers: Implement Kutta's third-order method\n"],["P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC","ODESolvers: Implement RKF78 and DP87 integrators\n"],["V37ACC7MAD57VQOKAT5FBO2ITNX73AWD2DUEIHMF7UPKV63YRTQAC","ODESolvers: Read RHS variables from interface.ccl\n"],["VLYBJZ6OP2XOVYCQIQOE2VHMX3DTWXYIPGZNYNME6F2H2EXXI2BQC","ODESolvers: Introduce ODESolvers_PostStep schedule group\n"],["P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC","ODESolvers: Implement Euler and RK2 ODE integrators\n"],["75DPHH3IRB65ARCIQXSFGMU25R43IPMTZ2N4X54BBA75EJ2CX66QC","ODESolvers: Implement classic RK4\n"],["WY5ZXJAAJJE47NWWJ22EKT2G5A3Z7WXR6754EZVKBSD7GPJITGSAC","ODESolvers: Implement SSPRK3\n"]],"deps":["3NWSBBMPHW3XOWLAMWI2AXX5VQDRHYT7CKGHL32RD6AUAUH67SVAC","LZFLSXT42KHYV4QTY6QCDURY6MD4JX7MXJYU2STJ354WADWI4CCAC","P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC"],"known":["P2M2LDDITHKC7HC6RMWQDTS5CT6CCH4LSIN37HQUA3NTC6SFNZOQC","V37ACC7MAD57VQOKAT5FBO2ITNX73AWD2DUEIHMF7UPKV63YRTQAC","VLYBJZ6OP2XOVYCQIQOE2VHMX3DTWXYIPGZNYNME6F2H2EXXI2BQC","75DPHH3IRB65ARCIQXSFGMU25R43IPMTZ2N4X54BBA75EJ2CX66QC"]},"hunks":[{"Edit":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":263,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":191},"to":{"change":5,"start":191,"end":250},"introduced_by":5},{"previous":"","flag":"DELETED","from":{"change":5,"pos":250},"to":{"change":5,"start":239,"end":264},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":4334},"to":{"change":5,"start":239,"end":264},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":264},"to":{"change":2,"start":260,"end":348},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":348},"to":{"change":5,"start":335,"end":382},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":335},"to":{"change":5,"start":335,"end":382},"introduced_by":5}],"inode":{"change":5,"pos":541}}},"contents":[{"Del":{"text":" *const_cast(&cctkGH->cctk_time) = old_time;","pos":"75DPHH3IRB65ARCIQXSFGMU25R43IPMTZ2N4X54BBA75EJ2CX66QC:249"}},{"Del":{"text":" // Calculate first RHS","pos":"VLYBJZ6OP2XOVYCQIQOE2VHMX3DTWXYIPGZNYNME6F2H2EXXI2BQC:263"}},{"Del":{"text":" if (verbose)","pos":"3NWSBBMPHW3XOWLAMWI2AXX5VQDRHYT7CKGHL32RD6AUAUH67SVAC:274"}},{"Del":{"text":" CCTK_VINFO(\"Calculating RHS #1 at t=%g\", double(cctkGH->cctk_time));","pos":"3NWSBBMPHW3XOWLAMWI2AXX5VQDRHYT7CKGHL32RD6AUAUH67SVAC:347"}},{"Del":{"text":" CallScheduleGroup(cctkGH, \"ODESolvers_RHS\");","pos":"VLYBJZ6OP2XOVYCQIQOE2VHMX3DTWXYIPGZNYNME6F2H2EXXI2BQC:381"}}]}},{"Edit":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":274,"atom":{"NewVertex":{"up_context":[{"change":10,"pos":172}],"down_context":[{"change":5,"pos":4491}],"flag":"BLOCK","start":0,"end":230,"inode":{"change":5,"pos":541}}},"contents":[{"Add":{"text":"","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:0"}},{"Add":{"text":" // Calculate first RHS","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:27"}},{"Add":{"text":" *const_cast(&cctkGH->cctk_time) = old_time;","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:88"}},{"Add":{"text":" if (verbose)","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:105"}},{"Add":{"text":" CCTK_VINFO(\"Calculating RHS #1 at t=%g\", double(cctkGH->cctk_time));","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:180"}},{"Add":{"text":" CallScheduleGroup(cctkGH, \"ODESolvers_RHS\");","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:229"}}]}},{"Edit":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":291,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":4645}],"down_context":[{"change":5,"pos":4645}],"flag":"BLOCK","start":231,"end":292,"inode":{"change":5,"pos":541}}},"contents":[{"Add":{"text":" *const_cast(&cctkGH->cctk_time) = old_time;","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:291"}}]}},{"Edit":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":293,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":4646}],"down_context":[{"change":5,"pos":4696}],"flag":"BLOCK","start":293,"end":449,"inode":{"change":5,"pos":541}}},"contents":[{"Add":{"text":" // Step 1","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:306"}},{"Add":{"text":" if (verbose)","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:323"}},{"Add":{"text":" CCTK_VINFO(\"Calculating RHS #1 at t=%g\", double(cctkGH->cctk_time));","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:398"}},{"Add":{"text":" CallScheduleGroup(cctkGH, \"ODESolvers_RHS\");","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:447"}},{"Add":{"text":"","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:448"}}]}},{"Edit":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":303,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":4836}],"down_context":[{"change":2,"pos":349}],"flag":"BLOCK","start":450,"end":464,"inode":{"change":5,"pos":541}}},"contents":[{"Add":{"text":" // Step 2","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:463"}}]}},{"Edit":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":319,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":243}],"down_context":[{"change":3,"pos":243}],"flag":"BLOCK","start":465,"end":682,"inode":{"change":5,"pos":541}}},"contents":[{"Add":{"text":" *const_cast(&cctkGH->cctk_time) = old_time;","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:525"}},{"Add":{"text":"","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:526"}},{"Add":{"text":" // Step 1","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:540"}},{"Add":{"text":" if (verbose)","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:557"}},{"Add":{"text":" CCTK_VINFO(\"Calculating RHS #1 at t=%g\", double(cctkGH->cctk_time));","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:632"}},{"Add":{"text":" CallScheduleGroup(cctkGH, \"ODESolvers_RHS\");","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:681"}}]}},{"Edit":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":367,"atom":{"NewVertex":{"up_context":[{"change":10,"pos":447}],"down_context":[{"change":10,"pos":447}],"flag":"BLOCK","start":683,"end":900,"inode":{"change":5,"pos":541}}},"contents":[{"Add":{"text":" *const_cast(&cctkGH->cctk_time) = old_time;","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:743"}},{"Add":{"text":"","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:744"}},{"Add":{"text":" // Step 1","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:758"}},{"Add":{"text":" if (verbose)","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:775"}},{"Add":{"text":" CCTK_VINFO(\"Calculating RHS #1 at t=%g\", double(cctkGH->cctk_time));","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:850"}},{"Add":{"text":" CallScheduleGroup(cctkGH, \"ODESolvers_RHS\");","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:899"}}]}},{"Edit":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":416,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":377}],"down_context":[{"change":5,"pos":377}],"flag":"BLOCK","start":901,"end":1118,"inode":{"change":5,"pos":541}}},"contents":[{"Add":{"text":" *const_cast(&cctkGH->cctk_time) = old_time;","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:961"}},{"Add":{"text":"","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:962"}},{"Add":{"text":" // Step 1","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:976"}},{"Add":{"text":" if (verbose)","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:993"}},{"Add":{"text":" CCTK_VINFO(\"Calculating RHS #1 at t=%g\", double(cctkGH->cctk_time));","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:1068"}},{"Add":{"text":" CallScheduleGroup(cctkGH, \"ODESolvers_RHS\");","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:1117"}}]}},{"Replacement":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":534,"ins":{"up_context":[{"change":4,"pos":3847}],"down_context":[{"change":4,"pos":3962}],"flag":"BLOCK","start":1119,"end":1170,"inode":{"change":5,"pos":541}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3847},"to":{"change":4,"start":3847,"end":3962},"introduced_by":4}],"inode":{"change":5,"pos":541}},"ins_contents":[{"Add":{"text":" for (size_t step = 0; step < nsteps; ++step) {","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:1169"}}],"del_contents":[{"Del":{"text":" // Special-case step 1 (why?)","pos":"P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC:3880"}},{"Del":{"text":" ks.push_back(rhs.copy());","pos":"P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC:3910"}},{"Del":{"text":" for (size_t step = 1; step < nsteps; ++step) {","pos":"P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC:3961"}}]}},{"Replacement":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":626,"ins":{"up_context":[{"change":4,"pos":8273}],"down_context":[{"change":4,"pos":8388}],"flag":"BLOCK","start":1171,"end":1222,"inode":{"change":5,"pos":541}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":8273},"to":{"change":4,"start":8273,"end":8388},"introduced_by":4}],"inode":{"change":5,"pos":541}},"ins_contents":[{"Add":{"text":" for (size_t step = 0; step < nsteps; ++step) {","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:1221"}}],"del_contents":[{"Del":{"text":" // Special-case step 1 (why?)","pos":"P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC:8306"}},{"Del":{"text":" ks.push_back(rhs.copy());","pos":"P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC:8336"}},{"Del":{"text":" for (size_t step = 1; step < nsteps; ++step) {","pos":"P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC:8387"}}]}},{"Replacement":{"inode":{"change":5,"pos":541},"path":"ODESolvers/src/solve.cxx","line":665,"ins":{"up_context":[{"change":5,"pos":5163}],"down_context":[{"change":5,"pos":5165}],"flag":"BLOCK","start":1223,"end":1225,"inode":{"change":5,"pos":541}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":5163},"to":{"change":4,"start":9339,"end":9364},"introduced_by":4}],"inode":{"change":5,"pos":541}},"ins_contents":[{"Add":{"text":"}","pos":"QGS6SF4SPCD2A7EINWQPICO4YXIM5YL5KIENFPF6KG77AB7KRJSQC:1224"}}],"del_contents":[{"Del":{"text":"} // namespace ODESolver","pos":"P2MXPV6QGEX37BSXN4IKHNSS6TIA5T3TKV4CCP7TBCKLHC6L6SXAC:9363"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review