{"header":{"message":"AMReX: Allocate grid scalars as vector, not as vector of pointers\n","description":null,"timestamp":"2019-10-18T21:02:59Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC","authors":[],"deps":{"hashes":[["WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC","AMReX: Allocate grid scalars as vector, not as vector of pointers\n"],["AA",null],["W4XMGPEHBCV6AAPJBI4SSEMCDB6KKCGRUC2X2F5YLBY22OR3ICPAC","AMReX: Check and invalidate grid scalars only once, not once per level\n\nAlso poison invalid input data.\n"],["NGCIZ5F7DNQT7ADLRZ2SRTP7GFZZ6JIASMM5CXMWDRDYF4VZBBDAC","AMReX: add tsv extension to scalar output file\n"],["QN2UTSQP4IMCMVXZNR24J22N24ASGXF6EWXQ2P3VWVQERUPFAFDQC","Use AmrMesh class\n"],["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","Set up cctkGH entries\n"],["GECUITHDXKCWB7HBCM7EA5Q56JDDWUVUWHMW2K6OM7UW36DFAZ3QC","AMReX: Emit real error messages when nan checking fails\n"],["EHF2P5PKVTMAUL5R5QSZ3DS3VLE7Z6SHJTCZAGRBTQ66Y7HZKNYQC","Merge commit 'f8f1d61' into rhaas/gridscalars\n"],["IV3MLV677VWS7GLESBQZ4HRFNW5TBFBIGIBWXTCHAER3FQ7VG3GQC","Merge remote-tracking branch 'origin/rhaas/gridscalars'\n"],["NZTFEMGJPN53J34S3MVUCL7TTRB4UG7JQM2R563OAHIRM4QPZOWAC","AMReX: bugfixes for grid scalar support\n"],["2DD222JSYRPHTXKSRXLSOMSCQPZUORNFLLO2P3GMIDELAAMD5MEQC","Rename some ghext variables\n"],["M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC","AMReX: add support for grid scalars\n\nfirst version that compiles, untested otherwise, has a couple of\nsub-optimal choices\n"],["2A7Y7KPC7JW6QTW6DD7A7APXF4JIULFUNWONQXY667JCUXATJHXAC","AMReX: support vectors of grid scalars\n"],["UEZKNPXXK5WU6B5LYRKGGYGBZ6T6TAZI26CWTJFUBUW2SJJOMV2AC","AMReX: Reformat\n"],["RTNZAS3UPI6GG3KY4Z5WVXJ4R2YF5427BB6WAV3GHRS5W7XPOSUQC","Initialize coordinates in the driver\n"],["WASO7G5FJXRXWNH2U2FLUNEKU6VE63OI3HUYP64BVD4LMD6KE7OQC","Begin to support multiple refinement levels\n"],["722HZ7UFINNE3YKSYKP2NHZ5XEG5QQLQHSKC7PREJZR3EX6RDYUAC","Import initial AMReX driver for Cactus\n"],["RCLGQ2LZMFVPBPTU2G55DJ6HZPOGGTPZRZCY54VGP6YLHANJ2LAQC","Move I/O to driver. WaveToy is now driver-independent.\n"]],"deps":["W4XMGPEHBCV6AAPJBI4SSEMCDB6KKCGRUC2X2F5YLBY22OR3ICPAC"],"known":["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","RTNZAS3UPI6GG3KY4Z5WVXJ4R2YF5427BB6WAV3GHRS5W7XPOSUQC","WASO7G5FJXRXWNH2U2FLUNEKU6VE63OI3HUYP64BVD4LMD6KE7OQC","2DD222JSYRPHTXKSRXLSOMSCQPZUORNFLLO2P3GMIDELAAMD5MEQC","QN2UTSQP4IMCMVXZNR24J22N24ASGXF6EWXQ2P3VWVQERUPFAFDQC","GECUITHDXKCWB7HBCM7EA5Q56JDDWUVUWHMW2K6OM7UW36DFAZ3QC","M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC","NZTFEMGJPN53J34S3MVUCL7TTRB4UG7JQM2R563OAHIRM4QPZOWAC","2A7Y7KPC7JW6QTW6DD7A7APXF4JIULFUNWONQXY667JCUXATJHXAC","EHF2P5PKVTMAUL5R5QSZ3DS3VLE7Z6SHJTCZAGRBTQ66Y7HZKNYQC","IV3MLV677VWS7GLESBQZ4HRFNW5TBFBIGIBWXTCHAER3FQ7VG3GQC","NGCIZ5F7DNQT7ADLRZ2SRTP7GFZZ6JIASMM5CXMWDRDYF4VZBBDAC","UEZKNPXXK5WU6B5LYRKGGYGBZ6T6TAZI26CWTJFUBUW2SJJOMV2AC"]},"hunks":[{"Edit":{"inode":{"change":17,"pos":15972},"path":"AMReX/src/driver.cxx","line":160,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":206},"to":{"change":3,"start":177,"end":269},"introduced_by":3}],"inode":{"change":17,"pos":15972}}},"contents":[{"Del":{"text":" scalargroupdata.data.at(tl).at(0) =","pos":"UEZKNPXXK5WU6B5LYRKGGYGBZ6T6TAZI26CWTJFUBUW2SJJOMV2AC:218"}},{"Del":{"text":" new CCTK_REAL[scalargroupdata.numvars];","pos":"UEZKNPXXK5WU6B5LYRKGGYGBZ6T6TAZI26CWTJFUBUW2SJJOMV2AC:268"}}]}},{"Edit":{"inode":{"change":17,"pos":15972},"path":"AMReX/src/driver.cxx","line":161,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1610},"to":{"change":3,"start":1610,"end":1663},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1663},"to":{"change":3,"start":270,"end":367},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":367},"to":{"change":3,"start":1723,"end":1724},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":168},"to":{"change":3,"start":1723,"end":1724},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1723},"to":{"change":3,"start":1723,"end":1724},"introduced_by":3}],"inode":{"change":17,"pos":15972}}},"contents":[{"Del":{"text":" // TODO: find out something that avoid new ?","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:1662"}},{"Del":{"text":" scalargroupdata.data.at(tl).at(vi) =","pos":"UEZKNPXXK5WU6B5LYRKGGYGBZ6T6TAZI26CWTJFUBUW2SJJOMV2AC:314"}},{"Del":{"text":" scalargroupdata.data.at(tl).at(0) + vi;","pos":"UEZKNPXXK5WU6B5LYRKGGYGBZ6T6TAZI26CWTJFUBUW2SJJOMV2AC:366"}},{"Del":{"text":"","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:1723"}}]}},{"Replacement":{"inode":{"change":17,"pos":15275},"path":"AMReX/src/driver.hxx","line":109,"ins":{"up_context":[{"change":3,"pos":2887}],"down_context":[{"change":3,"pos":3095}],"flag":"BLOCK","start":0,"end":66,"inode":{"change":17,"pos":15275}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2887},"to":{"change":3,"start":2887,"end":3027},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3027},"to":{"change":2,"start":0,"end":30},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":30},"to":{"change":3,"start":3027,"end":3095},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3027},"to":{"change":3,"start":3027,"end":3095},"introduced_by":3}],"inode":{"change":17,"pos":15275}},"ins_contents":[{"Add":{"text":" vector > data; // [time level][var index]","pos":"WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC:65"}}],"del_contents":[{"Del":{"text":" // TODO: find out how to do this without a pointer to a single double but","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:2966"}},{"Del":{"text":" // also working around const vector issues","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:3026"}},{"Del":{"text":" // TODO: use unique_ptr","pos":"W4XMGPEHBCV6AAPJBI4SSEMCDB6KKCGRUC2X2F5YLBY22OR3ICPAC:29"}},{"Del":{"text":" vector > data; // [time level][var index]","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:3094"}}]}},{"Replacement":{"inode":{"change":18,"pos":107},"path":"AMReX/src/io.cxx","line":344,"ins":{"up_context":[{"change":3,"pos":5381}],"down_context":[{"change":3,"pos":2278}],"flag":"BLOCK","start":67,"end":125,"inode":{"change":18,"pos":107}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":5381},"to":{"change":3,"start":5381,"end":5440},"introduced_by":3}],"inode":{"change":18,"pos":107}},"ins_contents":[{"Add":{"text":" file << \"\\t\" << scalargroupdata.data.at(tl).at(vi);","pos":"WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC:124"}}],"del_contents":[{"Del":{"text":" file << \"\\t\" << *scalargroupdata.data.at(tl).at(vi);","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:5439"}}]}},{"Replacement":{"inode":{"change":3,"pos":531},"path":"AMReX/src/schedule.cxx","line":345,"ins":{"up_context":[{"change":3,"pos":6059}],"down_context":[{"change":3,"pos":6131}],"flag":"BLOCK","start":126,"end":232,"inode":{"change":3,"pos":531}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":6059},"to":{"change":3,"start":6059,"end":6131},"introduced_by":3}],"inode":{"change":3,"pos":531}},"ins_contents":[{"Add":{"text":" CCTK_REAL *restrict const ptr =","pos":"WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC:161"}},{"Add":{"text":" const_cast(&scalargroupdata.data.at(tl).at(vi));","pos":"WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC:231"}}],"del_contents":[{"Del":{"text":" CCTK_REAL *restrict const ptr = scalargroupdata.data.at(tl).at(vi);","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:6130"}}]}},{"Replacement":{"inode":{"change":3,"pos":531},"path":"AMReX/src/schedule.cxx","line":367,"ins":{"up_context":[{"change":3,"pos":6643}],"down_context":[{"change":3,"pos":6715}],"flag":"BLOCK","start":233,"end":312,"inode":{"change":3,"pos":531}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":6643},"to":{"change":3,"start":6643,"end":6715},"introduced_by":3}],"inode":{"change":3,"pos":531}},"ins_contents":[{"Add":{"text":" const CCTK_REAL *restrict const ptr = &scalargroupdata.data.at(tl).at(vi);","pos":"WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC:311"}}],"del_contents":[{"Del":{"text":" CCTK_REAL *restrict const ptr = scalargroupdata.data.at(tl).at(vi);","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:6714"}}]}},{"Replacement":{"inode":{"change":3,"pos":531},"path":"AMReX/src/schedule.cxx","line":525,"ins":{"up_context":[{"change":3,"pos":7813}],"down_context":[{"change":3,"pos":7891}],"flag":"BLOCK","start":313,"end":431,"inode":{"change":3,"pos":531}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":7813},"to":{"change":3,"start":7813,"end":7891},"introduced_by":3}],"inode":{"change":3,"pos":531}},"ins_contents":[{"Add":{"text":" cctkGH->data[scalargroupdata.firstvarindex + vi][tl] =","pos":"WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC:377"}},{"Add":{"text":" const_cast(&vars.at(vi));","pos":"WV2J4VRLSW42SGIRDLF326LLC7L2ABAMSZ3YKABS532K27U3X3CAC:430"}}],"del_contents":[{"Del":{"text":" cctkGH->data[scalargroupdata.firstvarindex + vi][tl] = vars.at(vi);","pos":"M5R6KQLXLGYSVKHVAX5AJKD6NYE6IM5Z6WVTR3BTKPJDNNKF3ARAC:7890"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review