{"header":{"message":"CarpetX: Begin to calculate checkpoints to detect unintended modifications\n","description":null,"timestamp":"2019-12-18T17:13:12Z","authors":[{"email":"schnetter@gmail.com","name":"Erik Schnetter"}]},"hash":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC","authors":[],"deps":{"hashes":[["X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC","CarpetX: Begin to calculate checkpoints to detect unintended modifications\n"],["AA",null],["W4XMGPEHBCV6AAPJBI4SSEMCDB6KKCGRUC2X2F5YLBY22OR3ICPAC","AMReX: Check and invalidate grid scalars only once, not once per level\n\nAlso poison invalid input data.\n"],["HVV73EHEMEFVCPS75XZAFUGWOY7LBYOJOIDNHJUK4MB5QTS3CTJQC","CarpetX: Export function CallScheduleGroup\n"],["N63EBGITKHCIQFNOEZI6XBKOBPM6ZA5FR2BALK6OAYQJLZMOF7XAC","Move AMReX external library handling into its own thorn\n"],["GKKJ75HX2ERLVBZVE2CUB6T3J2SUT7R3UKEKTEYNOG43ZKX6X5MQC","The big rename: AMReX -> CarpetX\n"],["722HZ7UFINNE3YKSYKP2NHZ5XEG5QQLQHSKC7PREJZR3EX6RDYUAC","Import initial AMReX driver for Cactus\n"],["BVR7DVINVPQG7PA6Z7QYVYNQ43YZL7XCC6AOMSMWMGAAB2Q43STAC","Set up cctkGH entries\n"],["UUGQGVC4WEKN64WAP7F5QPS2UHGQB5ZLMFRIYNWKMIEBDO3QRX4AC","Overload evolution manager\n"],["KCIWCVZOHG44WBOLKI2XK33WPHPRI5FWCETF4AOGTPZISKCW3CLQC","More work on poisoning\n"]],"deps":["W4XMGPEHBCV6AAPJBI4SSEMCDB6KKCGRUC2X2F5YLBY22OR3ICPAC","HVV73EHEMEFVCPS75XZAFUGWOY7LBYOJOIDNHJUK4MB5QTS3CTJQC"],"known":["722HZ7UFINNE3YKSYKP2NHZ5XEG5QQLQHSKC7PREJZR3EX6RDYUAC","GKKJ75HX2ERLVBZVE2CUB6T3J2SUT7R3UKEKTEYNOG43ZKX6X5MQC","N63EBGITKHCIQFNOEZI6XBKOBPM6ZA5FR2BALK6OAYQJLZMOF7XAC"]},"hunks":[{"Replacement":{"inode":{"change":4,"pos":19462},"path":"CarpetX/configuration.ccl","line":3,"ins":{"up_context":[{"change":4,"pos":19508}],"down_context":[{"change":3,"pos":0}],"flag":"BLOCK","start":0,"end":24,"inode":{"change":4,"pos":19462}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":19508},"to":{"change":4,"start":858,"end":877},"introduced_by":4}],"inode":{"change":4,"pos":19462}},"ins_contents":[{"Add":{"text":"REQUIRES AMReX MPI zlib","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:23"}}],"del_contents":[{"Del":{"text":"REQUIRES AMReX MPI","pos":"N63EBGITKHCIQFNOEZI6XBKOBPM6ZA5FR2BALK6OAYQJLZMOF7XAC:876"}}]}},{"Edit":{"inode":{"change":8,"pos":531},"path":"CarpetX/src/schedule.cxx","line":23,"atom":{"NewVertex":{"up_context":[{"change":8,"pos":766}],"down_context":[{"change":9,"pos":1303}],"flag":"BLOCK","start":25,"end":43,"inode":{"change":8,"pos":531}}},"contents":[{"Add":{"text":"#include ","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:42"}}]}},{"Edit":{"inode":{"change":8,"pos":531},"path":"CarpetX/src/schedule.cxx","line":1370,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":3396}],"down_context":[{"change":10,"pos":7733}],"flag":"BLOCK","start":44,"end":2626,"inode":{"change":8,"pos":531}}},"contents":[{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:51"}},{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:57"}},{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:61"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:62"}},{"Add":{"text":" // Calculate checksum over all variables that are not written","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:126"}},{"Add":{"text":" if (poison_undefined_values) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:159"}},{"Add":{"text":" const vector &writes = decode_clauses(attribute, rdwr_t::write);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:238"}},{"Add":{"text":" const int numgroups = CCTK_NumGroups();","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:282"}},{"Add":{"text":" vector > > gfs(numgroups);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:336"}},{"Add":{"text":" for (int gi = 0; gi < numgroups; ++gi) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:381"}},{"Add":{"text":" const int numvars = CCTK_NumVarsInGroupI(gi);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:433"}},{"Add":{"text":" gfs.at(gi).resize(numvars);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:467"}},{"Add":{"text":" for (int vi = 0; vi < numvars; ++vi) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:512"}},{"Add":{"text":" const int numtimelevels = 1; // TODO","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:557"}},{"Add":{"text":" gfs.at(gi).at(vi).resize(numtimelevels);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:606"}},{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:614"}},{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:620"}},{"Add":{"text":" for (const auto &wr : writes)","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:654"}},{"Add":{"text":" gfs.at(wr.gi).at(wr.vi).at(wr.tl) |= wr.valid;","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:707"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:708"}},{"Add":{"text":" uLong crc = crc32_z(0, nullptr, 0);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:748"}},{"Add":{"text":" for (int level = min_level; level < max_level; ++level) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:810"}},{"Add":{"text":" auto &restrict leveldata = ghext->leveldata.at(level);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:871"}},{"Add":{"text":" auto mfitinfo = MFItInfo().SetDynamic(true).EnableTiling(","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:935"}},{"Add":{"text":" {max_tile_size_x, max_tile_size_y, max_tile_size_z});","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:999"}},{"Add":{"text":" for (MFIter mfi(*leveldata.mfab0, mfitinfo); mfi.isValid(); ++mfi) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1074"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1075"}},{"Add":{"text":" for (const auto &groupdataptr : leveldata.groupdata) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1138"}},{"Add":{"text":" auto &restrict groupdata = *groupdataptr;","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1190"}},{"Add":{"text":" const GridPtrDesc1 grid(leveldata, groupdata, mfi);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1252"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1253"}},{"Add":{"text":" for (int vi = 0; vi < groupdata.numvars; ++vi) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1312"}},{"Add":{"text":" for (int tl = 0; tl < int(groupdata.valid.size()); ++tl) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1383"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1384"}},{"Add":{"text":" const auto &gf = gfs.at(groupdata.groupindex).at(vi).at(tl);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1459"}},{"Add":{"text":" // Check only those variables where some part is written","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1530"}},{"Add":{"text":" if (gf.any()) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1560"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1561"}},{"Add":{"text":" const Array4 &vars =","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1615"}},{"Add":{"text":" groupdata.mfab.at(tl)->array(mfi);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1670"}},{"Add":{"text":" const GF3D1 var_ = grid.gf3d(vars, vi);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1743"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1744"}},{"Add":{"text":" const auto addcrc{[&](const Loop::PointDesc &p) {","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1810"}},{"Add":{"text":" crc = crc32_z(crc,","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1847"}},{"Add":{"text":" static_cast(","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1907"}},{"Add":{"text":" static_cast(&var_(p.I))),","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:1983"}},{"Add":{"text":" sizeof var_(p.I));","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2034"}},{"Add":{"text":" }};","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2054"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2055"}},{"Add":{"text":" if (!gf.valid_int)","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2090"}},{"Add":{"text":" grid.loop_idx(where_t::interior, groupdata.indextype,","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2162"}},{"Add":{"text":" groupdata.nghostzones, addcrc);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2226"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2227"}},{"Add":{"text":" if (!gf.valid_outer)","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2264"}},{"Add":{"text":" grid.loop_idx(where_t::boundary, groupdata.indextype,","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2336"}},{"Add":{"text":" groupdata.nghostzones, addcrc);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2400"}},{"Add":{"text":"","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2401"}},{"Add":{"text":" if (!gf.valid_ghosts)","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2439"}},{"Add":{"text":" grid.loop_idx(where_t::ghosts, groupdata.indextype,","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2509"}},{"Add":{"text":" groupdata.nghostzones, addcrc);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2573"}},{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2589"}},{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2603"}},{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2615"}},{"Add":{"text":" }","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2625"}}]}},{"Edit":{"inode":{"change":8,"pos":531},"path":"CarpetX/src/schedule.cxx","line":1436,"atom":{"NewVertex":{"up_context":[{"change":10,"pos":7747}],"down_context":[{"change":10,"pos":7747}],"flag":"BLOCK","start":2627,"end":2682,"inode":{"change":8,"pos":531}}},"contents":[{"Add":{"text":" CCTK_VINFO(\"CRC-32: 0x%08lx\", (unsigned long)crc);","pos":"X7A7HYGU2NPWCZCG5SYFD4NINYDP6UYWFFE3WP6YNLSDIABG2KJAC:2681"}}]}}],"owner":"eschnett","repo":"cactusamrex","login":null}

…

Dependencies

Change contents

Review