eschnett/cactusamrex - Change D6H2FWRX5NTSSGXL2263KT7DHM3BXQBAYXTNKNJTSMRPD7VEJYHAC

CarpetX: Fixed iteration over array elements

Created by Samuel Cupp on October 12, 2020

D6H2FWRX5NTSSGXL2263KT7DHM3BXQBAYXTNKNJTSMRPD7VEJYHAC

Dependencies

In channels

main

Change contents

Replacement in CarpetX/src/schedule.cxx at line 593 [4.531]

B:BD[3.10509] → [2.0:35]

∅:D[2.35] → [3.10581:10712]

B:BD[3.10581] → [3.10581:10712]

B:BD[3.10712] → [2.36:99]

  int ubnd = *arraygroupdata.ubnd;
  if (!valid.valid_int) {
    CCTK_REAL *restrict const ptr =
        const_cast<CCTK_REAL *>(&arraygroupdata.data.at(tl).at(vi));
    for (int i = 0; i < ubnd; i++) {
      ptr[i] = 0.0 / 0.0;

[3.10509]

[2.99]

  int dimension = arraygroupdata.dimension;
  atomic<size_t> nan_count{0};
  if (dimension == 0) {
    return;
  } else {
    const int *gsh = arraygroupdata.gsh;
    int n_elems = 1;
    for (int i = 0; i < dimension; i++) n_elems *= gsh[i];
  
    if (valid.valid_int) {
      CCTK_REAL *restrict const ptr =
          const_cast<CCTK_REAL *>(&arraygroupdata.data.at(tl).at(vi));
      for (int i = 0; i < n_elems; i++) {
        ptr[i] = 0.0 / 0.0;
      }

Replacement in CarpetX/src/schedule.cxx at line 625 [4.531]
B:BD[3.11209] → [2.106:141]
```
  int ubnd = *arraygroupdata.ubnd;
```
[3.11209]
[3.11315]
```
  int dimension = arraygroupdata.dimension;
```

Replacement in CarpetX/src/schedule.cxx at line 628 [4.531]

B:BD[3.11346] → [3.11346:11449]

B:BD[3.11449] → [2.142:243]

∅:D[2.243] → [3.11550:11571]

B:BD[3.11550] → [3.11550:11571]

  if (valid.valid_int) {
    const CCTK_REAL *restrict const ptr = &arraygroupdata.data.at(tl).at(vi);
    for (int i = 0; i < ubnd; i++) {
      if (CCTK_BUILTIN_EXPECT(!CCTK_isfinite(ptr[i]), false)) {
        ++nan_count;

[3.11346]

[3.11571]

  if (dimension == 0) {
    return;
  } else {
    const int *gsh = arraygroupdata.gsh;
    int n_elems = 1;
    for (int i = 0; i < dimension; i++) n_elems *= gsh[i];
  
    if (valid.valid_int) {
      const CCTK_REAL *restrict const ptr = &arraygroupdata.data.at(tl).at(vi);
      for (int i = 0; i < n_elems; i++) {
        if (CCTK_BUILTIN_EXPECT(!CCTK_isfinite(ptr[i]), false)) {
          ++nan_count;
        }