eschnett/cactusamrex - Change GVDNXZ5F2YHS3N2BQUMOAUMJVWIVETALDA24HCGYL5CVAJWSFF5QC

BaikalX: split ADM_to_BSSN into two scheduled functions, fix reads a single scheduled functions must not contain multiple loops that depend on each other's results unless the loops are pointwise

Created by Roland Haas on December 17, 2019

GVDNXZ5F2YHS3N2BQUMOAUMJVWIVETALDA24HCGYL5CVAJWSFF5QC

Dependencies

In channels

master

main

Change contents

Replacement in BaikalX/doc/BaikalX.ipynb at line 672 [3.16]

B:BD[3.46527] → [3.46527:46609]

    "schedule BaikalETK_ADM_to_BSSN at CCTK_INITIAL after ADMBase_PostInitial\n",

[3.46313]

[3.46609]

    "schedule BaikalX_ADM_to_BSSN_all_but_lambdaU at CCTK_INITIAL after ADMBase_PostInitial\n",

Replacement in BaikalX/doc/BaikalX.ipynb at line 675 [3.16]

B:BD[3.46639] → [2.3032:3126]

    "  SYNC: BaikalX::evol_variables\n",
    "  WRITES: BaikalX::evol_variables(interior)\n",

[3.46639]

[4.98]

    "  WRITES: aDD00GF(everywhere) aDD01GF(everywhere) aDD02GF(everywhere) aDD11GF(everywhere) aDD12GF(everywhere) aDD22GF(everywhere) \n",
    "  WRITES: alphaGF(everywhere) betU0GF(everywhere) betU1GF(everywhere) betU2GF(everywhere) cfGF(everywhere)\n",
    "  WRITES: hDD00GF(everywhere) hDD01GF(everywhere) hDD02GF(everywhere) hDD11GF(everywhere) hDD12GF(everywhere) hDD22GF(everywhere)\n",
    "  WRITES: trKGF(everywhere) vetU0GF(everywhere) vetU1GF(everywhere) vetU2GF(everywhere)\n",
    "\n",

Insertion in BaikalX/doc/BaikalX.ipynb at line 688 [3.16]

[3.46763]

[3.47151]

    "schedule BaikalX_ADM_to_BSSN_lambdaU at CCTK_INITIAL after ADMBase_PostInitial after BaikalX_ADM_to_BSSN_all_but_lambdaU\n",
    "{\n",
    "  LANG: C\n",
    "  SYNC: BaikalX::evol_variables\n",
    "  WRITES: lambdaU0GF(interior) lambdaU1GF(interior) lambdaU2GF(interior)\n",
    "  READS: hDD00GF(everywhere) hDD01GF(everywhere) hDD02GF(everywhere) hDD11GF(everywhere) hDD12GF(everywhere) hDD22GF(everywhere)\n",
    "} \"Convert initial data into BSSN variables\"\n",
    "\n",

Replacement in BaikalX/doc/BaikalX.ipynb at line 701 [3.16]

∅:D[2.3278] → [4.429:697]

B:BD[4.429] → [4.429:697]

    "  WRITES: ADMBase::metric(interior)\n",
    "  WRITES: ADMBase::curv(interior)\n",
    "  WRITES: ADMBASE::shift(interior)\n",
    "  WRITES: ADMBASE::lapse(interior)\n",
    "  WRITES: ADMBase::dtshift(interior)\n",
    "  WRITES: ADMBase::dtlapse(interior)\n",

[2.3278]

[3.47615]

    "  WRITES: ADMBase::metric(everywhere)\n",
    "  WRITES: ADMBase::curv(everywhere)\n",
    "  WRITES: ADMBASE::shift(everywhere)\n",
    "  WRITES: ADMBASE::lapse(everywhere)\n",

Replacement in BaikalX/doc/BaikalX.ipynb at line 740 [3.16]

B:BD[3.49113] → [2.4002:4057]

∅:D[2.4057] → [5.68:402]

B:BD[5.68] → [5.68:402]

    "  WRITES: BaikalX::evol_variables(everywhere)\n",
    "  READS: ADMBase::metric(everywhere)\n",
    "  READS: ADMBase::curv(everywhere)\n",
    "  READS: ADMBASE::shift(everywhere)\n",
    "  READS: ADMBASE::lapse(everywhere)\n",
    "  READS: ADMBASE::dtlapse(everywhere)\n",
    "  # these run everywhere so thy cannot set dtshift since vet and beta differ by an advection term\n",

[3.49113]

[3.49139]

    "  READS: BaikalX::evol_variables(everywhere)\n",
    "  WRITES: ADMBase::metric(everywhere)\n",
    "  WRITES: ADMBase::curv(everywhere)\n",
    "  WRITES: ADMBASE::shift(everywhere)\n",
    "  WRITES: ADMBASE::dtshift(everywhere)\n",
    "  WRITES: ADMBASE::lapse(everywhere)\n",

Replacement in BaikalX/doc/BaikalX.ipynb at line 903 [3.16]

B:BD[2.4847] → [2.4847:4904]

    "    DECLARE_CCTK_ARGUMENTS_BaikalX_ADM_to_BSSN;\n",

[2.4847]

[3.65922]

    "    DECLARE_CCTK_ARGUMENTS_BaikalX_ADM_to_BSSN_all_but_lambdaU;\n",

Deletion in BaikalX/doc/BaikalX.ipynb at line 906 [3.16]

B:BD[3.65974] → [6.864:2553]

    "\"\"\")\n",
    "#   \"\"\"    // make copies of ADMBase variables where we expect them\"\"\"    \n",
    "#    copy_admbase_vars = []\n",
    "#    copy_admbase_vars.append(\"alphaSphorCartGF[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)] = alp[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)];\\n\")\n",
    "#    # It's ugly if we output code in the following ordering, so we'll first\n",
    "#    #   output to a string and then sort the string to beautify the code a bit.\n",
    "#    for i in range(DIM):\n",
    "#        copy_admbase_vars.append(\"betaSphorCartU\"+str(i)+\"GF[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)] = beta\"+chr(ord('x')+i)+\"[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)];\\n\")\n",
    "#        copy_admbase_vars.append(\"BSphorCartU\"+str(i)+\"GF[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)] = dtbeta\"+chr(ord('x')+i)+\"[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)];\\n\")\n",
    "#        for j in range(i,DIM):\n",
    "#            copy_admbase_vars.append(\"gammaSphorCartDD\"+str(i)+str(j)+\"GF[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)] = g\"+chr(ord('x')+i)+chr(ord('x')+j)+\"[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)];\\n\")\n",
    "#            copy_admbase_vars.append(\"KSphorCartDD\"+str(i)+str(j)+\"GF[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)] = k\"+chr(ord('x')+i)+chr(ord('x')+j)+\"[CCTK_GFINDEX3D(cctkGH,i0,i1,i2)];\\n\")\n",
    "#    copy_admbase_vars.sort()\n",
    "#    file.write(lp.loop([\"i2\",\"i1\",\"i0\"],[\"0\", \"0\", \"0\"],\n",
    "#                       [\"cctk_lsh[2]\",\"cctk_lsh[1]\",\"cctk_lsh[0]\"],\n",
    "#                       [\"1\",\"1\",\"1\"],\n",
    "#                        [\"#pragma omp parallel for\",\"\",\"\",],\"\",\"\".join(copy_admbase_vars)))\n",
    "\n",
    "    file.write(\"\"\"\n",

Deletion in BaikalX/doc/BaikalX.ipynb at line 931 [3.16]
B:BD[7.2596] → [7.2596:2663]
```
    "        adm_to_bssn_gfs.append(\"lambdaU\"+str(i)+\"GF\")\n",
```

Deletion in BaikalX/doc/BaikalX.ipynb at line 941 [3.16]

B:BD[3.66932] → [3.66932:67121]

    "    const CCTK_REAL invdx0 = 1.0/CCTK_DELTA_SPACE(0);\n",
    "    const CCTK_REAL invdx1 = 1.0/CCTK_DELTA_SPACE(1);\n",
    "    const CCTK_REAL invdx2 = 1.0/CCTK_DELTA_SPACE(2);\n",

Insertion in BaikalX/doc/BaikalX.ipynb at line 969 [3.16]

[7.3253]

[3.69316]

    "    \n",
    "    file.write(\"\"\"\n",
    "}\n",
    "\"\"\")\n",
    "    file.write(\"\"\"\n",
    "void BaikalX_ADM_to_BSSN_lambdaU(CCTK_ARGUMENTS) {\n",
    "    DECLARE_CCTK_ARGUMENTS_BaikalX_ADM_to_BSSN_lambdaU;\n",
    "    DECLARE_CCTK_PARAMETERS;\n",
    "    \n",
    "\n",
    "\"\"\")\n",
    "    adm_to_bssn_gfs = []\n",
    "    for i in range(DIM):\n",
    "        adm_to_bssn_gfs.append(\"lambdaU\"+str(i)+\"GF\")\n",
    "        for j in range(i,DIM):\n",
    "            adm_to_bssn_gfs.append(\"hDD\"+str(i)+str(j)+\"GF\")\n",
    "    for gf in adm_to_bssn_gfs:\n",
    "        file.write(\"Loop::GF3D<CCTK_REAL,0,0,0> \"+gf+\"_(cctkGH,\"+gf+\");\\n\")\n",
    "    file.write(\"\\n\")\n",

Insertion in BaikalX/doc/BaikalX.ipynb at line 989 [3.16]

[3.69326]

    "    file.write(\"\"\"\n",
    "    const CCTK_REAL invdx0 = 1.0/CCTK_DELTA_SPACE(0);\n",
    "    const CCTK_REAL invdx1 = 1.0/CCTK_DELTA_SPACE(1);\n",
    "    const CCTK_REAL invdx2 = 1.0/CCTK_DELTA_SPACE(2);\n",
    "\"\"\")\n",
    "\n",