fiddlerwoaroof/crawl - Change ZBTD5R4OOQ5D4W6ZRK2XEGLI3AWI37Z2G5X2EQ6IYPXDYKCKWMFAC

Moving from snprintf() to std::ostringstream, slowly but surely.

git-svn-id: https://crawl-ref.svn.sourceforge.net/svnroot/crawl-ref/trunk@1356 c06c8d41-db1a-0410-9941-cceddc491573

Created by haranp on April 24, 2007

ZBTD5R4OOQ5D4W6ZRK2XEGLI3AWI37Z2G5X2EQ6IYPXDYKCKWMFAC

Dependencies

In channels

main

Change contents

Insertion in crawl-ref/source/direct.cc at line 24 [4.3697945]
[3.450881]
[4.3698555]
```
#include <sstream>
```

Replacement in crawl-ref/source/direct.cc at line 1488 [4.3697945]

B:BD[4.3719199] → [2.27843:28033]

            snprintf( info, INFO_SIZE, "%s is wielding %s",
                      mons_pronoun( menv[i].type, PRONOUN_CAP ),
                      mitm[mon_wep].name(DESC_NOCAP_A).c_str());

[4.3719199]

[4.3719451]

            std::ostringstream msg;
            msg << mons_pronoun( menv[i].type, PRONOUN_CAP )
                << " is wielding "
                << mitm[mon_wep].name(DESC_NOCAP_A);

Replacement in crawl-ref/source/direct.cc at line 1498 [4.3697945]

B:BD[4.3719681] → [2.28137:28268]

∅:D[2.28268] → [4.3719839:3719874]

B:BD[4.3719839] → [4.3719839:3719874]

B:BD[4.3719875] → [4.3719875:3720009]

                strcat(info, " and " );
                strcat(info, mitm[menv[i].inv[MSLOT_MISSILE]].name(DESC_NOCAP_A).c_str());
                strcat(info, ".");
                mpr(info);
            }
            else
            {
                strcat(info, ".");
                mpr(info);

[4.3719681]

[4.3720009]

                msg << " and "
                    <<  mitm[menv[i].inv[MSLOT_MISSILE]].name(DESC_NOCAP_A);

Insertion in crawl-ref/source/direct.cc at line 1501 [4.3697945]
[4.3720023]
[4.3720023]
```
            msg << ".";
            mpr(msg.str().c_str());
```
Insertion in crawl-ref/source/abl-show.cc at line 27 [4.4494389]
[4.4495073]
[4.4495073]
```
#include <sstream>
```

Replacement in crawl-ref/source/abl-show.cc at line 331 [4.4494389]

B:BD[4.4504239] → [4.4504239:4504342]

    char         tmp_buff[80];  // avoiding string steams for portability 
    std::string  ret = "";

[4.4504239]

[4.4504342]

    std::ostringstream ret;

Replacement in crawl-ref/source/abl-show.cc at line 334 [4.4494389]

B:BD[4.4504370] → [4.4504370:4504563]

        snprintf( tmp_buff, sizeof(tmp_buff), "%d%s MP", 
                  abil.mp_cost, 
                  (abil.flags & ABFLAG_PERMANENT_MP) ? " Permanent" : "" );
        ret += tmp_buff;

[4.4504370]

[4.4504563]

        ret << abil.mp_cost;
        if (abil.flags & ABFLAG_PERMANENT_MP)
            ret << " Permanent";
        ret << " MP";

Replacement in crawl-ref/source/abl-show.cc at line 342 [4.4494389]

B:BD[4.4504598] → [4.4504598:4504816]

        if (ret.length())
            ret += ", ";
        snprintf( tmp_buff, sizeof(tmp_buff), "%d%s HP", 
                  abil.hp_cost,
                  (abil.flags & ABFLAG_PERMANENT_HP) ? " Permanent" : "" );

[4.4504598]

[4.4504816]

        if (ret.str().length())
            ret << ", ";

Replacement in crawl-ref/source/abl-show.cc at line 345 [4.4494389]

B:BD[4.4504817] → [4.4504817:4504842]

        ret += tmp_buff;

[4.4504817]

[4.4504842]

        ret << abil.hp_cost;
        if (abil.flags & ABFLAG_PERMANENT_HP)
            ret << " Permanent";
        ret << " HP";

Replacement in crawl-ref/source/abl-show.cc at line 353 [4.4494389]

B:BD[4.4504879] → [4.4504879:4504930]

        if (ret.length())
            ret += ", ";

[4.4504879]

[4.4504930]

        if (ret.str().length())
            ret << ", ";

Replacement in crawl-ref/source/abl-show.cc at line 356 [4.4494389]

B:BD[4.4504931] → [4.4504931:4505000]

        ret += "Food";   // randomized and amount hidden from player

[4.4504931]

[4.4505000]

        ret << "Food";   // randomized and amount hidden from player

Replacement in crawl-ref/source/abl-show.cc at line 361 [4.4494389]

B:BD[4.4505038] → [4.4505038:4505089]

        if (ret.length())
            ret += ", ";

[4.4505038]

[4.4505089]

        if (ret.str().length())
            ret << ", ";

Replacement in crawl-ref/source/abl-show.cc at line 364 [4.4494389]

B:BD[4.4505090] → [4.4505090:4505159]

        ret += "Piety";  // randomized and amount hidden from player

[4.4505090]

[4.4505159]

        ret << "Piety";  // randomized and amount hidden from player

Replacement in crawl-ref/source/abl-show.cc at line 369 [4.4494389]

B:BD[4.4505208] → [4.4505208:4505259]

        if (ret.length())
            ret += ", ";

[4.4505208]

[4.4505259]

        if (ret.str().length())
            ret << ", ";

Replacement in crawl-ref/source/abl-show.cc at line 372 [4.4494389]
B:BD[4.4505260] → [4.4505260:4505286]
```
        ret += "Breath"; 
```
[4.4505260]
[4.4505286]
```
        ret << "Breath"; 
```

Replacement in crawl-ref/source/abl-show.cc at line 377 [4.4494389]

B:BD[4.4505334] → [4.4505334:4505385]

        if (ret.length())
            ret += ", ";

[4.4505334]

[4.4505385]

        if (ret.str().length())
            ret << ", ";

Replacement in crawl-ref/source/abl-show.cc at line 380 [4.4494389]
B:BD[4.4505386] → [4.4505386:4505410]
```
        ret += "Delay";
```
[4.4505386]
[4.4505410]
```
        ret << "Delay";
```

Replacement in crawl-ref/source/abl-show.cc at line 385 [4.4494389]

B:BD[4.4505457] → [4.4505457:4505508]

        if (ret.length())
            ret += ", ";

[4.4505457]

[4.4505508]

        if (ret.str().length())
            ret << ", ";

Replacement in crawl-ref/source/abl-show.cc at line 388 [4.4494389]
B:BD[4.4505509] → [4.4505509:4505532]
```
        ret += "Pain";
```
[4.4505509]
[4.4505532]
```
        ret << "Pain";
```

Replacement in crawl-ref/source/abl-show.cc at line 393 [4.4494389]

B:BD[4.4505585] → [4.4505585:4505636]

        if (ret.length())
            ret += ", ";

[4.4505585]

[4.4505636]

        if (ret.str().length())
            ret << ", ";

Replacement in crawl-ref/source/abl-show.cc at line 396 [4.4494389]
B:BD[4.4505637] → [4.4505637:4505666]
```
        ret += "Exhaustion";
```
[4.4505637]
[4.4505666]
```
        ret << "Exhaustion";
```

Replacement in crawl-ref/source/abl-show.cc at line 401 [4.4494389]

B:BD[4.4505716] → [4.4505716:4505767]

        if (ret.length())
            ret += ", ";

[4.4505716]

[4.4505767]

        if (ret.str().length())
            ret << ", ";

Replacement in crawl-ref/source/abl-show.cc at line 404 [4.4494389]

B:BD[4.4505768] → [4.4505768:4505837]

        ret += "Instant"; // not really a cost, more of a bonus -bwr

[4.4505768]

[4.4505837]

        ret << "Instant"; // not really a cost, more of a bonus -bwr

Replacement in crawl-ref/source/abl-show.cc at line 408 [4.4494389]
B:BD[4.4505917] → [4.4505917:4505963]
```
    if (!ret.length())
        ret += "None";
```
[4.4505917]
[4.4505963]
```
    if (!ret.str().length())
        ret << "None";
```
Replacement in crawl-ref/source/abl-show.cc at line 411 [4.4494389]
B:BD[4.4505964] → [4.4505964:4505982]
```
    return (ret);
```
[4.4505964]
[4.4505982]
```
    return (ret.str());
```

Moving from snprintf() to std::ostringstream, slowly but surely.

Dependencies

In channels

Change contents

Insertion in crawl-ref/source/direct.cc at line 24 [4.3697945]

Replacement in crawl-ref/source/direct.cc at line 1488 [4.3697945]

Replacement in crawl-ref/source/direct.cc at line 1498 [4.3697945]

Insertion in crawl-ref/source/direct.cc at line 1501 [4.3697945]

Insertion in crawl-ref/source/abl-show.cc at line 27 [4.4494389]