finchie/cli_framework - Change EMXNTYAMGWISSMAFQDBVGZ67OLM2SKZFH23J4ZWC5YSEAFAFL2JQC

Require `Locale` to be passed as a parameter to `localize()`

Still not an ideal solution, as it implicity relies on icu_plurals being imported by the user, but at least now the locale is controlled by the caller, which is much cleaner and removes duplicated code/work.

Created by finchie on February 14, 2024

EMXNTYAMGWISSMAFQDBVGZ67OLM2SKZFH23J4ZWC5YSEAFAFL2JQC

Dependencies

In channels

main

Change contents

Replacement in fluent_embed/src/lib.rs at line 95 [4.74]

B:BD[3.889] → [3.889:936]

                fn localize(&self) -> String {

[3.889]

[3.936]

                fn localize(&self, plural_rules: &::icu_plurals::PluralRules) -> String {

Replacement in fluent_embed/src/lib.rs at line 134 [4.74]

B:BD[5.583] → [5.583:974]

                {
                    // FIXME: this is a hack and should be cleaned up later
                    use icu_locid::locale;
                    use icu_plurals::{PluralCategory, PluralRuleType, PluralRules};
                    let plural_rules = PluralRules::try_new(&locale!("en").into(), PluralRuleType::Cardinal)
                        .expect("locale should be present");

[5.583]

[5.974]

                match plural_rules.category_for(*#match_target) {
                    #(#match_arms),*
                }

Deletion in fluent_embed/src/lib.rs at line 138 [4.74]

B:BD[5.975] → [2.644:714]

∅:D[2.714] → [5.1044:1125]

B:BD[5.1044] → [5.1044:1125]

                    match plural_rules.category_for(*#match_target) {
                        #(#match_arms),*
                    }
                }

Replacement in fluent_embed/src/lib.rs at line 190 [4.74]

B:BD[5.2124] → [5.2124:2173]

            parse_quote!(PluralCategory::#ident)

[5.2124]

[5.2173]

            parse_quote!(::icu_plurals::PluralCategory::#ident)