finchie/cli_framework - Change MIHGKLMEPO5O6KSXEBOLEPWGUUL3YBNKJC75G34J23EM55BDX2XQC

Fix generated `format!` macro call

Thanks to adding prettyplease, it was obvious that strings were being treated as literals when they shouldn't. The fix was to use a String and Vec instead of two TokenStreams, which seems to work much better.

Created by finchie on February 11, 2024

MIHGKLMEPO5O6KSXEBOLEPWGUUL3YBNKJC75G34J23EM55BDX2XQC

Dependencies

In channels

main

Change contents

Replacement in fluent_embed/src/lib.rs at line 50 [4.74]

B:BD[3.578] → [3.578:639]

    // TODO: turn this into a well-formed `match expression`

[3.578]

[3.639]

    // TODO: turn this into a well-formed `match` expression

Replacement in fluent_embed/src/lib.rs at line 60 [4.74]

B:BD[2.384] → [2.384:507]

    let mut format_body = proc_macro2::TokenStream::new();
    let mut format_arguments = proc_macro2::TokenStream::new();

[2.384]

[2.507]

    let mut format_body = String::new();
    let mut format_arguments = Vec::new();

Replacement in fluent_embed/src/lib.rs at line 65 [4.74]

B:BD[2.571] → [2.571:660]

            PatternElement::TextElement { value } => format_body.extend(quote!(#value)),

[2.571]

[2.660]

            PatternElement::TextElement { value } => format_body.push_str(value),

Replacement in fluent_embed/src/lib.rs at line 68 [4.74]

B:BD[2.792] → [2.792:902]

                format_body.extend(quote!({}));
                format_arguments.extend(quote!(#expression));

[2.792]

[2.902]

                format_body.push_str("{}");
                format_arguments.push(quote!(#expression));

Replacement in fluent_embed/src/lib.rs at line 76 [4.74]

B:BD[2.1028] → [2.1028:1095]

    parse_quote!(format!(#format_body_literal, #format_arguments))

[2.1028]

[2.1095]

    parse_quote!(format!(#format_body_literal, #(#format_arguments),*))