{"header":{"message":"Implement `to_syn` for groups containing simple text messages","description":"This will not work on anything more complicated than the simple text-only string used in the example, as selectors and placeables are not yet handled.","timestamp":"2024-02-11T06:23:32.663237204Z","authors":[{}]},"hash":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC","authors":[{"login":"finchie","key":"6WCsL9cxQoPBLLwR1PUvmFBJi6wGTGFAxcxMovPQCwTZ"}],"deps":{"hashes":[["3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC","Implement `to_syn` for groups containing simple text messages"],["AA",null],["O77KA6C4UJGZXVGPEA7WCRQH6XYQJPWETSPDXI3VOKOSRQND7JEQC","Create `fluent_embed` crate"]],"deps":["O77KA6C4UJGZXVGPEA7WCRQH6XYQJPWETSPDXI3VOKOSRQND7JEQC"],"known":[]},"hunks":[{"Replacement":{"inode":{"change":2,"pos":74},"path":"fluent_embed/src/lib.rs","line":1,"ins":{"up_context":[{"change":2,"pos":74}],"down_context":[{"change":2,"pos":127}],"flag":"BLOCK","start":0,"end":90,"inode":{"change":2,"pos":74}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":74},"to":{"change":2,"start":75,"end":127},"introduced_by":2}],"inode":{"change":2,"pos":74}},"ins_contents":[{"Add":{"text":"use fluent_syntax::ast::{Entry, Message, PatternElement, Resource};","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:67"}},{"Add":{"text":"use syn::parse_quote;","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:89"}}],"del_contents":[{"Del":{"text":"use fluent_syntax::ast::{Entry, Message, Resource};","pos":"O77KA6C4UJGZXVGPEA7WCRQH6XYQJPWETSPDXI3VOKOSRQND7JEQC:126"}}]}},{"Replacement":{"inode":{"change":2,"pos":74},"path":"fluent_embed/src/lib.rs","line":5,"ins":{"up_context":[{"change":2,"pos":145}],"down_context":[{"change":2,"pos":174}],"flag":"BLOCK","start":91,"end":124,"inode":{"change":2,"pos":74}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":145},"to":{"change":2,"start":145,"end":174},"introduced_by":2}],"inode":{"change":2,"pos":74}},"ins_contents":[{"Add":{"text":"pub enum GroupEntry<'resource> {","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:123"}}],"del_contents":[{"Del":{"text":"enum GroupEntry<'resource> {","pos":"O77KA6C4UJGZXVGPEA7WCRQH6XYQJPWETSPDXI3VOKOSRQND7JEQC:173"}}]}},{"Edit":{"inode":{"change":2,"pos":74},"path":"fluent_embed/src/lib.rs","line":12,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":315}],"down_context":[{"change":2,"pos":315}],"flag":"BLOCK","start":125,"end":570,"inode":{"change":2,"pos":74}}},"contents":[{"Add":{"text":"}","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:126"}},{"Add":{"text":"","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:127"}},{"Add":{"text":"impl<'resource> GroupEntry<'resource> {","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:167"}},{"Add":{"text":" fn to_syn(&self) -> syn::Expr {","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:203"}},{"Add":{"text":" match self {","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:224"}},{"Add":{"text":" Self::Message(message) => message.value.as_ref().map_or_else(","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:298"}},{"Add":{"text":" || parse_quote! { () },","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:338"}},{"Add":{"text":" |pattern| {","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:366"}},{"Add":{"text":" let parsed_patterns = pattern.elements.iter().map(match_pattern_element);","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:460"}},{"Add":{"text":" parse_quote! { #(#parsed_patterns)+* }","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:519"}},{"Add":{"text":" },","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:538"}},{"Add":{"text":" ),","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:553"}},{"Add":{"text":" }","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:563"}},{"Add":{"text":" }","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:569"}}]}},{"Edit":{"inode":{"change":2,"pos":74},"path":"fluent_embed/src/lib.rs","line":48,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":991}],"down_context":[{"change":2,"pos":991}],"flag":"BLOCK","start":571,"end":796,"inode":{"change":2,"pos":74}}},"contents":[{"Add":{"text":" }","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:576"}},{"Add":{"text":"","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:577"}},{"Add":{"text":" // TODO: turn this into a well-formed `match expression`","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:638"}},{"Add":{"text":" pub fn to_syn(&self) -> Vec {","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:683"}},{"Add":{"text":" self.children","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:705"}},{"Add":{"text":" .iter()","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:725"}},{"Add":{"text":" .map(GroupEntry::to_syn)","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:762"}},{"Add":{"text":" .collect::>()","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:795"}}]}},{"Edit":{"inode":{"change":2,"pos":74},"path":"fluent_embed/src/lib.rs","line":58,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":999}],"down_context":[],"flag":"BLOCK","start":797,"end":1048,"inode":{"change":2,"pos":74}}},"contents":[{"Add":{"text":"","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:797"}},{"Add":{"text":"fn match_pattern_element<'resource>(","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:834"}},{"Add":{"text":" pattern_element: &'resource PatternElement<&'resource str>,","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:898"}},{"Add":{"text":") -> syn::Expr {","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:915"}},{"Add":{"text":" match pattern_element {","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:943"}},{"Add":{"text":" PatternElement::TextElement { value } => parse_quote! { #value },","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1017"}},{"Add":{"text":" _ => todo!(),","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1039"}},{"Add":{"text":" }","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1045"}},{"Add":{"text":"}","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1047"}}]}},{"Edit":{"inode":{"change":2,"pos":1056},"path":"fluent_embed/examples/groups.rs","line":2,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":1082}],"down_context":[{"change":2,"pos":1082}],"flag":"BLOCK","start":1049,"end":1067,"inode":{"change":2,"pos":1056}}},"contents":[{"Add":{"text":"use quote::quote;","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1066"}}]}},{"Edit":{"inode":{"change":2,"pos":1056},"path":"fluent_embed/examples/groups.rs","line":9,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":1244}],"down_context":[{"change":2,"pos":1244}],"flag":"BLOCK","start":1068,"end":1200,"inode":{"change":2,"pos":1056}}},"contents":[{"Add":{"text":" let syn_expressions = group","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1099"}},{"Add":{"text":" .to_syn()","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1117"}},{"Add":{"text":" .iter()","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1133"}},{"Add":{"text":" .map(|expr| quote! {#expr})","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1169"}},{"Add":{"text":" .collect::>();","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1199"}}]}},{"Replacement":{"inode":{"change":2,"pos":1056},"path":"fluent_embed/examples/groups.rs","line":15,"ins":{"up_context":[{"change":2,"pos":1245}],"down_context":[{"change":2,"pos":1262}],"flag":"BLOCK","start":1201,"end":1228,"inode":{"change":2,"pos":1056}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1245},"to":{"change":2,"start":1245,"end":1262},"introduced_by":2}],"inode":{"change":2,"pos":1056}},"ins_contents":[{"Add":{"text":" dbg!(syn_expressions);","pos":"3C3CHSY5FETUIE7W2VQ5V62GJNE3MW2WUM7GJDUFWSDB4WKNFR2AC:1227"}}],"del_contents":[{"Del":{"text":" dbg!(group);","pos":"O77KA6C4UJGZXVGPEA7WCRQH6XYQJPWETSPDXI3VOKOSRQND7JEQC:1261"}}]}}],"owner":"finchie","repo":"l10n_embed","token":"sGBF13ukitGVH4bK6HmFEqhGSIslF63jBJpRBUDdE/k=","login":null}

…

Dependencies

Change contents

Review