{"header":{"message":"Move interaction constructors back to individual types","description":"Reverting earlier change, interactions still carry a reference to the environment but are constructed by calling `Self::new()` directly.","timestamp":"2025-08-08T07:11:07.746278211Z","authors":[{}]},"hash":"BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC","authors":[{"login":"finchie","key":"6WCsL9cxQoPBLLwR1PUvmFBJi6wGTGFAxcxMovPQCwTZ"}],"deps":{"hashes":[["BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC","Move interaction constructors back to individual types"],["AA",null],["IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC","Move prompt message to initial constructor"],["JUV7C6ET4ZQJNLO7B4JB7XMLV2YUBZB4ARJHN4JEPHDGGBWGLEVAC","Create initial prototype of `fluent_embed_interaction`"],["EKXWNEPK4FTYKT2RJL2L7HTM64VQGDD3DYD6NZIDGMMV6ITHUVZAC","Rename `Localize::message_for_locale` to `Localize::localize_for`"],["NEBSVXIASWSJO2CVU3VWRONIWJJDLL3VDS6WNKQBWQBRUUI7RSYAC","Apply Clippy fixes"],["BAH2JCJPTDXAE6XGSLIPBQZU4GQY65HI66Q4XTFNL65MV6VSNF2QC","Add progress bar to `fluent_embed_interaction`"],["IXBE5Q6TIJTOYDJMGBQKIT6B45567KFV3CYW6PJII2ZLW7CXNEJAC","Implement `InteractionEnvironment::print_message`"],["KFFAQIZUWCJGRHOPDYXZNZM5DESD6XYU4PK3YH7T25OIMRR6O2MQC","Rename `InteractionEnvironment::print_message` to `emit_message`"],["7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC","Move interaction constructors from individual types to implementations on `InteractionEnvironment`"]],"deps":["IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC"],"known":["JUV7C6ET4ZQJNLO7B4JB7XMLV2YUBZB4ARJHN4JEPHDGGBWGLEVAC","BAH2JCJPTDXAE6XGSLIPBQZU4GQY65HI66Q4XTFNL65MV6VSNF2QC","NEBSVXIASWSJO2CVU3VWRONIWJJDLL3VDS6WNKQBWQBRUUI7RSYAC","IXBE5Q6TIJTOYDJMGBQKIT6B45567KFV3CYW6PJII2ZLW7CXNEJAC","KFFAQIZUWCJGRHOPDYXZNZM5DESD6XYU4PK3YH7T25OIMRR6O2MQC","7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC","EKXWNEPK4FTYKT2RJL2L7HTM64VQGDD3DYD6NZIDGMMV6ITHUVZAC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":109},"path":"l10n_embed_interaction/src/prompt/select.rs","line":15,"ins":{"up_context":[{"change":3,"pos":207}],"down_context":[{"change":2,"pos":217}],"flag":"BLOCK","start":0,"end":100,"inode":{"change":3,"pos":109}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":207},"to":{"change":2,"start":70,"end":217},"introduced_by":2}],"inode":{"change":3,"pos":109}},"ins_contents":[{"Add":{"text":" pub fn new(environment: &'environment InteractionEnvironment, prompt: L) -> Self {","pos":"BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC:99"}}],"del_contents":[{"Del":{"text":" pub(crate) fn new_from_environment(","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:122"}},{"Del":{"text":" environment: &'environment InteractionEnvironment,","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:181"}},{"Del":{"text":" prompt: L,","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:200"}},{"Del":{"text":" ) -> Self {","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:216"}}]}},{"Replacement":{"inode":{"change":3,"pos":2012},"path":"l10n_embed_interaction/src/prompt/password.rs","line":20,"ins":{"up_context":[{"change":3,"pos":829}],"down_context":[{"change":2,"pos":611}],"flag":"BLOCK","start":101,"end":130,"inode":{"change":3,"pos":2012}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":829},"to":{"change":2,"start":558,"end":611},"introduced_by":2}],"inode":{"change":3,"pos":2012}},"ins_contents":[{"Add":{"text":" pub fn new(","pos":"BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC:129"}}],"del_contents":[{"Del":{"text":" pub(crate) fn new_from_environment(","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:610"}}]}},{"Replacement":{"inode":{"change":3,"pos":6488},"path":"l10n_embed_interaction/src/prompt/input.rs","line":15,"ins":{"up_context":[{"change":3,"pos":2129}],"down_context":[{"change":2,"pos":1367}],"flag":"BLOCK","start":131,"end":160,"inode":{"change":3,"pos":6488}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2129},"to":{"change":2,"start":1314,"end":1367},"introduced_by":2}],"inode":{"change":3,"pos":6488}},"ins_contents":[{"Add":{"text":" pub fn new(","pos":"BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC:159"}}],"del_contents":[{"Del":{"text":" pub(crate) fn new_from_environment(","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:1366"}}]}},{"Replacement":{"inode":{"change":3,"pos":8140},"path":"l10n_embed_interaction/src/prompt/confirm.rs","line":15,"ins":{"up_context":[{"change":3,"pos":2760}],"down_context":[{"change":2,"pos":1947}],"flag":"BLOCK","start":161,"end":261,"inode":{"change":3,"pos":8140}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2760},"to":{"change":2,"start":1800,"end":1947},"introduced_by":2}],"inode":{"change":3,"pos":8140}},"ins_contents":[{"Add":{"text":" pub fn new(environment: &'environment InteractionEnvironment, prompt: L) -> Self {","pos":"BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC:260"}}],"del_contents":[{"Del":{"text":" pub(crate) fn new_from_environment(","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:1852"}},{"Del":{"text":" environment: &'environment InteractionEnvironment,","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:1911"}},{"Del":{"text":" prompt: L,","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:1930"}},{"Del":{"text":" ) -> Self {","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:1946"}}]}},{"Replacement":{"inode":{"change":3,"pos":513},"path":"l10n_embed_interaction/src/progress.rs","line":18,"ins":{"up_context":[{"change":3,"pos":3142}],"down_context":[{"change":3,"pos":3195}],"flag":"BLOCK","start":262,"end":291,"inode":{"change":3,"pos":513}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3142},"to":{"change":3,"start":3142,"end":3195},"introduced_by":3}],"inode":{"change":3,"pos":513}},"ins_contents":[{"Add":{"text":" pub fn new(","pos":"BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC:290"}}],"del_contents":[{"Del":{"text":" pub(crate) fn new_from_environment(","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:3194"}}]}},{"Edit":{"inode":{"change":3,"pos":9269},"path":"l10n_embed_interaction/src/lib.rs","line":55,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":602},"to":{"change":3,"start":3796,"end":3949},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3796},"to":{"change":3,"start":3796,"end":3949},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3949},"to":{"change":2,"start":2296,"end":2530},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":2530},"to":{"change":3,"start":4104,"end":4138},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4104},"to":{"change":3,"start":4104,"end":4138},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4138},"to":{"change":2,"start":2531,"end":2607},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":2607},"to":{"change":3,"start":4219,"end":4260},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4219},"to":{"change":3,"start":4219,"end":4260},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4299},"to":{"change":3,"start":4299,"end":4418},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4418},"to":{"change":2,"start":2608,"end":2864},"introduced_by":2}],"inode":{"change":3,"pos":9269}}},"contents":[{"Del":{"text":" }","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:3801"}},{"Del":{"text":"}","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:3803"}},{"Del":{"text":"","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:3804"}},{"Del":{"text":"macro_rules! impl_constructor {","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:3836"}},{"Del":{"text":" ($prompt_name:ident, $prompt_type:ident) => {","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:3886"}},{"Del":{"text":" impl InteractionEnvironment {","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:3924"}},{"Del":{"text":" #[must_use]","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:3948"}},{"Del":{"text":" pub fn $prompt_name<'environment, L: Localize>(","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2355"}},{"Del":{"text":" &'environment self,","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2391"}},{"Del":{"text":" prompt: L,","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2418"}},{"Del":{"text":" ) -> $prompt_type<'environment> {","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2464"}},{"Del":{"text":" $prompt_type::new_from_environment(self, prompt)","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2529"}},{"Del":{"text":" }","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4117"}},{"Del":{"text":" }","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4127"}},{"Del":{"text":" };","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4134"}},{"Del":{"text":"}","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4136"}},{"Del":{"text":"","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4137"}},{"Del":{"text":"// Create constructors on InteractionEnvironment for different prompt types","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2606"}},{"Del":{"text":"impl_constructor!(new_confirm, Confirm);","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4259"}},{"Del":{"text":"impl_constructor!(new_input, Input);","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4335"}},{"Del":{"text":"impl_constructor!(new_password, Password);","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4378"}},{"Del":{"text":"impl_constructor!(new_select, Select);","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4417"}},{"Del":{"text":"","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2608"}},{"Del":{"text":"// Special implementation for text editor as the signature is different","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2680"}},{"Del":{"text":"impl InteractionEnvironment {","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2710"}},{"Del":{"text":" pub fn new_editor<'environment>(&'environment self, extension: &str) -> Editor<'environment> {","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2809"}},{"Del":{"text":" Editor::new_from_environment(self, extension)","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2863"}}]}},{"Edit":{"inode":{"change":3,"pos":9269},"path":"l10n_embed_interaction/src/lib.rs","line":57,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":2,"pos":2872},"to":{"change":3,"start":4418,"end":4732},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4418},"to":{"change":3,"start":4418,"end":4732},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":151},"to":{"change":3,"start":10328,"end":10336},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":4732},"to":{"change":3,"start":10328,"end":10336},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":10328},"to":{"change":3,"start":10328,"end":10336},"introduced_by":3}],"inode":{"change":3,"pos":9269}}},"contents":[{"Del":{"text":"","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4418"}},{"Del":{"text":"// Special implementation for progress bars as the signature is different","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4492"}},{"Del":{"text":"impl InteractionEnvironment {","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4522"}},{"Del":{"text":" pub fn new_progress<'environment, L: Localize>(","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4574"}},{"Del":{"text":" &'environment self,","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4602"}},{"Del":{"text":" message: L,","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4622"}},{"Del":{"text":" length: u64,","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4643"}},{"Del":{"text":" ) -> ProgressBar {","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4666"}},{"Del":{"text":" ProgressBar::new_from_environment(self, message, length)","pos":"7YOM2QEFZ5HWVEISP3VIR2GKF2NNH4KKTLTWEMYMMWNYKICXWTZAC:4731"}},{"Del":{"text":" }","pos":"JUV7C6ET4ZQJNLO7B4JB7XMLV2YUBZB4ARJHN4JEPHDGGBWGLEVAC:10333"}},{"Del":{"text":"}","pos":"JUV7C6ET4ZQJNLO7B4JB7XMLV2YUBZB4ARJHN4JEPHDGGBWGLEVAC:10335"}}]}},{"Replacement":{"inode":{"change":3,"pos":10371},"path":"l10n_embed_interaction/src/editor.rs","line":10,"ins":{"up_context":[{"change":3,"pos":4865}],"down_context":[{"change":3,"pos":4965}],"flag":"BLOCK","start":292,"end":385,"inode":{"change":3,"pos":10371}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4865},"to":{"change":2,"start":2929,"end":3069},"introduced_by":2}],"inode":{"change":3,"pos":10371}},"ins_contents":[{"Add":{"text":" pub fn new(environment: &'environment InteractionEnvironment, extension: &str) -> Self {","pos":"BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC:384"}}],"del_contents":[{"Del":{"text":" pub(crate) fn new_from_environment(","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:2968"}},{"Del":{"text":" environment: &'environment InteractionEnvironment,","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:3027"}},{"Del":{"text":" extension: &str,","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:3052"}},{"Del":{"text":" ) -> Self {","pos":"IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC:3068"}}]}}],"owner":"finchie","repo":"l10n_embed","token":"UoYVFs2nGlxcCOpKW+vm6QxbDwkEq8GBQXylgT4ZpGY=","login":null}

…

Dependencies

Change contents

Review