{"header":{"message":"Rename `parse` module to `parse_fluent`","description":"Since the term `parse` is ambiguous in a project that parses both rust & fluent files, this makes things much clearer. Many of the functions also had the `match_` prefix stripped as it was unhelpful boilerplate.","timestamp":"2024-02-14T07:55:22.199247426Z","authors":[{}]},"hash":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC","authors":[{"login":"finchie","key":"6WCsL9cxQoPBLLwR1PUvmFBJi6wGTGFAxcxMovPQCwTZ"}],"deps":{"hashes":[["D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC","Rename `parse` module to `parse_fluent`"],["AA",null],["5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC","Split `fluent_embed` into `group` and `parse` modules"],["O77KA6C4UJGZXVGPEA7WCRQH6XYQJPWETSPDXI3VOKOSRQND7JEQC","Create `fluent_embed` crate"],["UOMQT7LTURIIWHZT2ZHLCJG6XESYTN26EJC7IHRFR4PYJ355PNYAC","Add support for cardinal CLDR plural selectors"]],"deps":["5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC"],"known":["O77KA6C4UJGZXVGPEA7WCRQH6XYQJPWETSPDXI3VOKOSRQND7JEQC","UOMQT7LTURIIWHZT2ZHLCJG6XESYTN26EJC7IHRFR4PYJ355PNYAC"]},"hunks":[{"FileMove":{"meta":{"basename":"parse_fluent.rs","metadata":0},"old":[{"basename":"parse.rs","metadata":0}],"up":[{"change":3,"pos":41}],"down":[{"change":2,"pos":33}],"show_perms":false}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":8,"ins":{"up_context":[{"change":2,"pos":239}],"down_context":[{"change":2,"pos":352}],"flag":"BLOCK","start":27,"end":120,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":239},"to":{"change":2,"start":239,"end":352},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":"pub(crate) fn pattern<'resource>(pattern: &'resource Pattern<&'resource str>) -> syn::Expr {","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:119"}}],"del_contents":[{"Del":{"text":"pub(crate) fn match_fluent_pattern<'resource>(","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:285"}},{"Del":{"text":" pattern: &'resource Pattern<&'resource str>,","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:334"}},{"Del":{"text":") -> syn::Expr {","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:351"}}]}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":16,"ins":{"up_context":[{"change":2,"pos":640}],"down_context":[{"change":2,"pos":714}],"flag":"BLOCK","start":121,"end":189,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":640},"to":{"change":2,"start":640,"end":714},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":" let expression = placeable_expression(&expression);","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:188"}}],"del_contents":[{"Del":{"text":" let expression = match_placeable_expression(&expression);","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:713"}}]}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":28,"ins":{"up_context":[{"change":2,"pos":1019}],"down_context":[{"change":2,"pos":1133}],"flag":"BLOCK","start":190,"end":291,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1019},"to":{"change":2,"start":1019,"end":1133},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":"fn placeable_expression<'resource>(expression: &'resource Expression<&'resource str>) -> syn::Expr {","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:290"}}],"del_contents":[{"Del":{"text":"fn match_placeable_expression<'resource>(","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1060"}},{"Del":{"text":" expression: &'resource Expression<&'resource str>,","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1115"}},{"Del":{"text":") -> syn::Expr {","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1132"}}]}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":31,"ins":{"up_context":[{"change":2,"pos":1211}],"down_context":[{"change":2,"pos":1367}],"flag":"BLOCK","start":292,"end":424,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1211},"to":{"change":2,"start":1211,"end":1367},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":" let target = inline_expression(selector);","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:345"}},{"Add":{"text":" let arms: Vec = variants.iter().map(variant).collect();","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:423"}}],"del_contents":[{"Del":{"text":" let match_target = match_inline_expression(selector);","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1276"}},{"Del":{"text":" let match_arms: Vec = variants.iter().map(match_variant).collect();","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1366"}}]}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":35,"ins":{"up_context":[{"change":2,"pos":1395}],"down_context":[{"change":2,"pos":1498}],"flag":"BLOCK","start":425,"end":516,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1395},"to":{"change":2,"start":1395,"end":1498},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":" match plural_rules.category_for(*#target) {","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:484"}},{"Add":{"text":" #(#arms),*","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:515"}}],"del_contents":[{"Del":{"text":" match plural_rules.category_for(*#match_target) {","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1460"}},{"Del":{"text":" #(#match_arms),*","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1497"}}]}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":41,"ins":{"up_context":[{"change":2,"pos":1541}],"down_context":[{"change":2,"pos":1620}],"flag":"BLOCK","start":517,"end":590,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1541},"to":{"change":2,"start":1541,"end":1620},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":" Expression::Inline(expression) => inline_expression(expression),","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:589"}}],"del_contents":[{"Del":{"text":" Expression::Inline(expression) => match_inline_expression(expression),","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1619"}}]}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":45,"ins":{"up_context":[{"change":2,"pos":1629}],"down_context":[{"change":2,"pos":1668}],"flag":"BLOCK","start":591,"end":624,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1629},"to":{"change":2,"start":1629,"end":1668},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":"fn inline_expression<'resource>(","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:623"}}],"del_contents":[{"Del":{"text":"fn match_inline_expression<'resource>(","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:1667"}}]}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":71,"ins":{"up_context":[{"change":2,"pos":2593}],"down_context":[{"change":2,"pos":2775}],"flag":"BLOCK","start":625,"end":786,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":2593},"to":{"change":2,"start":2593,"end":2775},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":"fn variant<'resource>(variant: &Variant<&'resource str>) -> syn::Arm {","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:695"}},{"Add":{"text":" let base_pattern = variant_key(&variant.key);","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:745"}},{"Add":{"text":" let body = pattern(&variant.value);","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:785"}}],"del_contents":[{"Del":{"text":"fn match_variant<'resource>(variant: &Variant<&'resource str>) -> syn::Arm {","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:2669"}},{"Del":{"text":" let base_pattern = match_pattern(&variant.key);","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:2721"}},{"Del":{"text":" let body = match_fluent_pattern(&variant.value);","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:2774"}}]}},{"Replacement":{"inode":{"change":2,"pos":33},"path":"fluent_embed/src/parse_fluent.rs","line":87,"ins":{"up_context":[{"change":2,"pos":3112}],"down_context":[{"change":2,"pos":3212}],"flag":"BLOCK","start":787,"end":893,"inode":{"change":2,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3112},"to":{"change":2,"start":3112,"end":3212},"introduced_by":2}],"inode":{"change":2,"pos":33}},"ins_contents":[{"Add":{"text":"fn variant_key<'resource>(variant_key: &VariantKey<&'resource str>) -> syn::Pat {","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:868"}},{"Add":{"text":" match variant_key {","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:892"}}],"del_contents":[{"Del":{"text":"fn match_pattern<'resource>(pattern: &VariantKey<&'resource str>) -> syn::Pat {","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:3191"}},{"Del":{"text":" match pattern {","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:3211"}}]}},{"Replacement":{"inode":{"change":3,"pos":74},"path":"fluent_embed/src/lib.rs","line":2,"ins":{"up_context":[{"change":2,"pos":3475}],"down_context":[{"change":3,"pos":1386}],"flag":"BLOCK","start":894,"end":912,"inode":{"change":3,"pos":74}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3475},"to":{"change":2,"start":3475,"end":3486},"introduced_by":2}],"inode":{"change":3,"pos":74}},"ins_contents":[{"Add":{"text":"mod parse_fluent;","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:911"}}],"del_contents":[{"Del":{"text":"mod parse;","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:3485"}}]}},{"Replacement":{"inode":{"change":2,"pos":3543},"path":"fluent_embed/src/group.rs","line":22,"ins":{"up_context":[{"change":2,"pos":4077}],"down_context":[{"change":2,"pos":4164}],"flag":"BLOCK","start":913,"end":994,"inode":{"change":2,"pos":3543}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":4077},"to":{"change":2,"start":4077,"end":4164},"introduced_by":2}],"inode":{"change":2,"pos":3543}},"ins_contents":[{"Add":{"text":" .map_or_else(|| parse_quote!(()), crate::parse_fluent::pattern),","pos":"D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC:993"}}],"del_contents":[{"Del":{"text":" .map_or_else(|| parse_quote!(()), crate::parse::match_fluent_pattern),","pos":"5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC:4163"}}]}}],"owner":"finchie","repo":"l10n_embed","token":"Kem0/Nr+N6zuBVdCmxN/U8kE5iSiknrb2TqArP/qG5k=","login":null}

…

Dependencies

Change contents

Review