{"header":{"message":"Change lists to be based on type (and, or, unit) rather than length (wide, short, narrow)","description":"Length may need to be added back later, but this is a more natural and type-friendly way of specifying how to format the list.","timestamp":"2025-08-29T07:58:31.724969989Z","authors":[{}]},"hash":"DJH52CL34NRGNCOD27PO2ZZ7QC6TBL5GAZKY2A5FLX55VJJU3ELQC","authors":[{"login":"finchie","key":"6WCsL9cxQoPBLLwR1PUvmFBJi6wGTGFAxcxMovPQCwTZ"}],"deps":{"hashes":[["DJH52CL34NRGNCOD27PO2ZZ7QC6TBL5GAZKY2A5FLX55VJJU3ELQC","Change lists to be based on type (and, or, unit) rather than length (wide, short, narrow)"],["AA",null],["2HHBS7VWRQRDNDCCSV3BJJJHA7LGN3L4CMKIP7URWQFXPI6QFNDQC","Add rudimentary support for localizing lists"],["Q7LUHXXBN3ACNMGT4O2SKY5EGDEJQXMVJGYETTKNWIUAZCQV6HGAC","Replace localization of `Vec` with `List` type"],["RA3H7PWCI7WHONXB32IWYECQ3VKPKEXXYAJDIOHWNAGHDO7L5ZLQC","Refactor `Localize` for performance"],["GOMTCPOLHRE3FNK7C7BVGGUBSSV3JERUEFNGF7XMPRPRCCAVQDVAC","Pass colors through a field in `Context` rather than on `Styled` directly"],["PGBXJWIHSVTRD7CGDSCPC4YHI65EBKMQFEX62RZWL4EZB63622XAC","Move `l10n_embed` re-exports into `macro_prelude` module"],["HHJDRLLNN36UNIA7STAXEEVBCEMPJNB7SJQOS3TJLLYN4AEZ4MHQC","Create `fluent_embed_runtime` crate"]],"deps":["2HHBS7VWRQRDNDCCSV3BJJJHA7LGN3L4CMKIP7URWQFXPI6QFNDQC","Q7LUHXXBN3ACNMGT4O2SKY5EGDEJQXMVJGYETTKNWIUAZCQV6HGAC","RA3H7PWCI7WHONXB32IWYECQ3VKPKEXXYAJDIOHWNAGHDO7L5ZLQC"],"known":["PGBXJWIHSVTRD7CGDSCPC4YHI65EBKMQFEX62RZWL4EZB63622XAC","GOMTCPOLHRE3FNK7C7BVGGUBSSV3JERUEFNGF7XMPRPRCCAVQDVAC"]},"hunks":[{"Edit":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":2,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":90},"to":{"change":3,"start":32,"end":151},"introduced_by":3}],"inode":{"change":2,"pos":32}}},"contents":[{"Del":"\n/// Re-export from [`icu_locale`] for convenience when constructing a [`List`]\npub use icu_list::options::ListLength;\n"}]}},{"Replacement":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":11,"ins":{"up_context":[{"change":3,"pos":277}],"down_context":[{"change":2,"pos":510}],"flag":"BLOCK","start":0,"end":47,"inode":{"change":2,"pos":32}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":277},"to":{"change":3,"start":277,"end":354},"introduced_by":3}],"inode":{"change":2,"pos":32}},"ins_contents":[{"Add":"pub enum ListType {"},{"Add":" And,"},{"Add":" Or,"},{"Add":" Unit,"}],"del_contents":[{"Del":"pub struct List {\n messages: Vec,\n length: ListLength,\n"}]}},{"Replacement":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":17,"ins":{"up_context":[{"change":2,"pos":513}],"down_context":[{"change":3,"pos":488}],"flag":"BLOCK","start":48,"end":203,"inode":{"change":2,"pos":32}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":513},"to":{"change":3,"start":355,"end":488},"introduced_by":3}],"inode":{"change":2,"pos":32}},"ins_contents":[{"Add":"macro_rules! list_impl {"},{"Add":" ($list_name:ident, $list_type:path) => {"},{"Add":" pub struct $list_name {"},{"Add":" messages: Vec,"},{"Add":" }"}],"del_contents":[{"Del":"impl List {\n pub fn new(messages: Vec, length: ListLength) -> Self {\n Self { messages, length }\n }\n}\n"}]}},{"Replacement":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":23,"ins":{"up_context":[{"change":3,"pos":489}],"down_context":[{"change":3,"pos":593}],"flag":"BLOCK","start":204,"end":355,"inode":{"change":2,"pos":32}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":489},"to":{"change":3,"start":489,"end":593},"introduced_by":3}],"inode":{"change":2,"pos":32}},"ins_contents":[{"Add":" impl $list_name {"},{"Add":" pub fn new(messages: Vec) -> Self {"},{"Add":" Self { messages }"},{"Add":" }"},{"Add":" }"}],"del_contents":[{"Del":"impl Length for List {\n fn len(&self) -> usize {\n self.messages.len()\n }\n}\n"}]}},{"Replacement":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":29,"ins":{"up_context":[{"change":3,"pos":594}],"down_context":[{"change":4,"pos":6589}],"flag":"BLOCK","start":356,"end":506,"inode":{"change":2,"pos":32}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":594},"to":{"change":3,"start":594,"end":635},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":635},"to":{"change":4,"start":6458,"end":6589},"introduced_by":4}],"inode":{"change":2,"pos":32}},"ins_contents":[{"Add":" impl Length for $list_name {"},{"Add":" fn len(&self) -> usize {"},{"Add":" self.messages.len()"},{"Add":" }"},{"Add":" }"}],"del_contents":[{"Del":"impl Localize for List {\n"},{"Del":" fn localize(&self, context: &Context, buffer: &mut String) {\n let list_formatter = context.list_formatter(self.length);\n"}]}},{"Replacement":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":35,"ins":{"up_context":[{"change":4,"pos":6590}],"down_context":[{"change":3,"pos":874}],"flag":"BLOCK","start":507,"end":708,"inode":{"change":2,"pos":32}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":6590},"to":{"change":4,"start":6590,"end":6756},"introduced_by":4}],"inode":{"change":2,"pos":32}},"ins_contents":[{"Add":" impl Localize for $list_name {"},{"Add":" fn localize(&self, context: &Context, buffer: &mut String) {"},{"Add":" let list_formatter = context.list_formatter($list_type);"}],"del_contents":[{"Del":" let localized_messages = self.messages.iter().map(|message| {\n let mut buffer = String::new();\n message.localize(context, &mut buffer);\n"}]}},{"Replacement":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":39,"ins":{"up_context":[{"change":3,"pos":875}],"down_context":[{"change":3,"pos":1013}],"flag":"BLOCK","start":709,"end":899,"inode":{"change":2,"pos":32}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":875},"to":{"change":4,"start":6757,"end":6788},"introduced_by":4}],"inode":{"change":2,"pos":32}},"ins_contents":[{"Add":" let localized_messages = self.messages.iter().map(|message| {"},{"Add":" let mut buffer = String::new();"},{"Add":" message.localize(context, &mut buffer);"}],"del_contents":[{"Del":" buffer\n });\n"}]}},{"Replacement":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":43,"ins":{"up_context":[{"change":3,"pos":1014}],"down_context":[{"change":3,"pos":1082}],"flag":"BLOCK","start":900,"end":1117,"inode":{"change":2,"pos":32}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1014},"to":{"change":4,"start":6789,"end":6911},"introduced_by":4},{"previous":"","flag":"DELETED","from":{"change":4,"pos":6911},"to":{"change":3,"start":1076,"end":1082},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1076},"to":{"change":3,"start":1076,"end":1082},"introduced_by":3}],"inode":{"change":2,"pos":32}},"ins_contents":[{"Add":" buffer"},{"Add":" });"},{"Add":""},{"Add":" let formatted_list = list_formatter.format(localized_messages);"},{"Add":" formatted_list.write_to(buffer).unwrap();"},{"Add":" }"},{"Add":" }"},{"Add":" };"}],"del_contents":[{"Del":" let formatted_list = list_formatter.format(localized_messages);\n formatted_list.write_to(buffer).unwrap();\n"},{"Del":" }\n"}]}},{"Edit":{"inode":{"change":2,"pos":32},"path":"l10n_embed/src/list.rs","line":52,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":1084}],"down_context":[],"flag":"BLOCK","start":1118,"end":1227,"inode":{"change":2,"pos":32}}},"contents":[{"Add":""},{"Add":"list_impl!(AndList, ListType::And);"},{"Add":"list_impl!(OrList, ListType::Or);"},{"Add":"list_impl!(UnitList, ListType::Unit);"}]}},{"Replacement":{"inode":{"change":8,"pos":82},"path":"l10n_embed/src/lib.rs","line":16,"ins":{"up_context":[{"change":4,"pos":7188}],"down_context":[{"change":4,"pos":7247}],"flag":"BLOCK","start":1228,"end":1273,"inode":{"change":8,"pos":82}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":7188},"to":{"change":4,"start":7188,"end":7247},"introduced_by":4}],"inode":{"change":8,"pos":82}},"ins_contents":[{"Add":"use icu_list::options::ListFormatterOptions;"}],"del_contents":[{"Del":"use icu_list::options::{ListFormatterOptions, ListLength};\n"}]}},{"Replacement":{"inode":{"change":8,"pos":82},"path":"l10n_embed/src/lib.rs","line":72,"ins":{"up_context":[{"change":4,"pos":8391}],"down_context":[{"change":4,"pos":8642}],"flag":"BLOCK","start":1274,"end":1506,"inode":{"change":8,"pos":82}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":8391},"to":{"change":4,"start":8391,"end":8642},"introduced_by":4}],"inode":{"change":8,"pos":82}},"ins_contents":[{"Add":" pub fn list_formatter(&self, list_type: list::ListType) -> &ListFormatter {"},{"Add":" let index = match list_type {"},{"Add":" list::ListType::And => 0,"},{"Add":" list::ListType::Or => 1,"},{"Add":" list::ListType::Unit => 2,"}],"del_contents":[{"Del":" pub fn list_formatter(&self, length: ListLength) -> &ListFormatter {\n let index = match length {\n ListLength::Wide => 0,\n ListLength::Short => 1,\n ListLength::Narrow => 2,\n _ => unimplemented!(),\n"}]}},{"Replacement":{"inode":{"change":8,"pos":82},"path":"l10n_embed/src/lib.rs","line":80,"ins":{"up_context":[{"change":4,"pos":8707}],"down_context":[{"change":4,"pos":8892}],"flag":"BLOCK","start":1507,"end":1954,"inode":{"change":8,"pos":82}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":8707},"to":{"change":4,"start":8707,"end":8892},"introduced_by":4}],"inode":{"change":8,"pos":82}},"ins_contents":[{"Add":" let preferences = ListFormatterPreferences::from(&self.locale);"},{"Add":" let options = ListFormatterOptions::default();"},{"Add":""},{"Add":" match list_type {"},{"Add":" list::ListType::And => ListFormatter::try_new_and(preferences, options),"},{"Add":" list::ListType::Or => ListFormatter::try_new_or(preferences, options),"},{"Add":" list::ListType::Unit => ListFormatter::try_new_unit(preferences, options),"},{"Add":" }"}],"del_contents":[{"Del":" ListFormatter::try_new_and(\n ListFormatterPreferences::from(&self.locale),\n ListFormatterOptions::default().with_length(length),\n )\n"}]}},{"Replacement":{"inode":{"change":3,"pos":1144},"path":"l10n_embed/examples/list.rs","line":4,"ins":{"up_context":[{"change":4,"pos":15112}],"down_context":[{"change":4,"pos":15113}],"flag":"BLOCK","start":1955,"end":2006,"inode":{"change":3,"pos":1144}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":4,"pos":15112},"to":{"change":3,"start":1248,"end":1290},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1248},"to":{"change":3,"start":1248,"end":1290},"introduced_by":3}],"inode":{"change":3,"pos":1144}},"ins_contents":[{"Add":"use l10n_embed::list::{AndList, OrList, UnitList};"}],"del_contents":[{"Del":"use l10n_embed::list::{List, ListLength};\n"}]}},{"Replacement":{"inode":{"change":3,"pos":1144},"path":"l10n_embed/examples/list.rs","line":11,"ins":{"up_context":[{"change":3,"pos":1462}],"down_context":[{"change":3,"pos":1660}],"flag":"BLOCK","start":2007,"end":2151,"inode":{"change":3,"pos":1144}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1462},"to":{"change":3,"start":1462,"end":1660},"introduced_by":3}],"inode":{"change":3,"pos":1144}},"ins_contents":[{"Add":" let and_list = AndList::new(items.clone());"},{"Add":" let or_list = OrList::new(items.clone());"},{"Add":" let unit_list = UnitList::new(items.clone());"}],"del_contents":[{"Del":" let narrow_list = List::new(items.clone(), ListLength::Narrow);\n let short_list = List::new(items.clone(), ListLength::Short);\n let wide_list = List::new(items.clone(), ListLength::Wide);\n"}]}},{"Replacement":{"inode":{"change":3,"pos":1144},"path":"l10n_embed/examples/list.rs","line":17,"ins":{"up_context":[{"change":4,"pos":15201}],"down_context":[{"change":4,"pos":15339}],"flag":"BLOCK","start":2152,"end":2278,"inode":{"change":3,"pos":1144}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":15201},"to":{"change":4,"start":15201,"end":15339},"introduced_by":4}],"inode":{"change":3,"pos":1144}},"ins_contents":[{"Add":" (\"And list\", Box::new(and_list)),"},{"Add":" (\"Or list\", Box::new(or_list)),"},{"Add":" (\"Unit list\", Box::new(unit_list)),"}],"del_contents":[{"Del":" (\"Narrow list\", Box::new(narrow_list)),\n (\"Short list\", Box::new(short_list)),\n (\"Wide list\", Box::new(wide_list)),\n"}]}}],"owner":"finchie","repo":"l10n_embed","token":"PtH4nY3Z8gPt2VXGz+h8FpyTnnsT1wSANUuybXJO+NM=","login":null}

…

Dependencies

Change contents