Apply Clippy fixes

finchie

Jun 11, 2025, 11:35 AM

NEBSVXIASWSJO2CVU3VWRONIWJJDLL3VDS6WNKQBWQBRUUI7RSYAC

Dependencies

• [2] QJC4IQIT Refactor `Localize` functions to infallibly return `String`
• [3] QFPQZR4K Refactor `fluent_embed`
• [4] WWDZWJTR Implement `Localize` for string types
• [5] LIO32J4B Fix compiler error when `expand` feature is disabled
• [6] LYZBTYIW Replace `proc-macro-error` with `proc-macro-error2`
• [7] 7M4UI3TW Update dependencies to latest versions
• [8] CFJKYXUX Remove newtype wrapper `RelativeTime` for `jiff::Timestamp`
• [9] 7U2DXFMP Refactor `fluent_embed::Localize` to support overriding locales
• [10] 2SITVDYW Handle common errors in Fluent code
• [11] BFL2Y7GN Add relative timestamps using `jiff` and `icu_relativetime`
• [12] 3NMKD6I5 Refactor `Localize` trait to use `std::io::Write`
• [13] NFV26FRQ Improve glob error handling
• [14] IRW6JACS Implement `Localize` for `RelativeTime`
• [15] BAH2JCJP Add progress bar to `fluent_embed_interaction`
• [16] JUV7C6ET Create initial prototype of `fluent_embed_interaction`
• [17] YZ6PVVQC Add error handling for common unsupported Rust code
• [18] 7X4MEZJU Use Fluent AST when reporting error spans
• [19] BQ6N55O7 Refactor how `Group` stores messages
• [20] NO3PDO7P Refactor `fluent_embed` to support structs
• [21] VQBJBFEX Improve error handling for missing Fluent messages
• [22] O77KA6C4 Create `fluent_embed` crate
• [23] K3G4HK2J Track Fluent files using `include!`
• [24] 7JPOCQEI Add explicit error handling for macro parsing
• [25] CESJ4CTO Move macro-specific code into `macro_impl` module
• [26] F5LG7WEN Emit compilation errors from Fluent source code
• [27] OWXLFLRM Merge `cli_macros` shim into `fluent_embed`
• [28] 7FYXVNAB Ignore comments in Fluent source code
• [29] C6W7N6N5 Implement `Localize` for `FixedDecimal` and primitive number types
• [30] QSK7JRBA Add simple `attribute_path` function
• [*] XGNME3WR Move `Group::derive_enum` to new `crate::parse_macro` module
• [*] 5TEX4MNU Split `fluent_embed` into `group` and `parse` modules

Change contents

• replacement in fluent_embed_interaction/src/prompt/macros.rs at line 4
  [3.4481]→[3.4481:4516](∅→∅)
  − pub fn new() -> Self {
  [3.4481]

  [3.4516]
  + #[must_use] pub fn new() -> Self {
• replacement in fluent_embed_interaction/src/prompt/macros.rs at line 14
  [3.4681]→[3.4681:4755](∅→∅)
  − pub fn with_default(mut self, default: $field_type) -> Self {
  [3.4681]

  [3.4755]
  + #[must_use] pub const fn with_default(mut self, default: $field_type) -> Self {
• replacement in fluent_embed_interaction/src/lib.rs at line 28
  [3.9895]→[3.9895:9967](∅→∅)
  − dialoguer::Error::IO(error) => InteractionError::IO(error),
  [3.9895]

  [3.9967]
  + dialoguer::Error::IO(error) => Self::IO(error),
• replacement in fluent_embed_interaction/src/lib.rs at line 39
  [3.10088]→[3.10088:10132](∅→∅)
  − pub fn new(interactive: bool) -> Self {
  [3.10088]

  [3.10132]
  + #[must_use] pub fn new(interactive: bool) -> Self {
• replacement in fluent_embed_interaction/src/lib.rs at line 41
  [3.10147]→[3.10147:10318](∅→∅)
  − context: match interactive {

  − true => InteractionContext::Terminal,

  − false => InteractionContext::NonInteractive,

  − },
  [3.10147]

  [3.1885]
  + context: if interactive { InteractionContext::Terminal } else { InteractionContext::NonInteractive },
• edit in fluent_embed_interaction/src/editor.rs at line 7
  [3.10531]

  [3.10531]
  + }

  +

  + impl Default for Editor {

  + fn default() -> Self {

  + Self::new()

  + }
• replacement in fluent_embed_interaction/src/editor.rs at line 16
  [3.10548]→[3.10548:10575](∅→∅)
  − pub fn new() -> Self {
  [3.10548]

  [3.10575]
  + #[must_use] pub const fn new() -> Self {
• replacement in fluent_embed_interaction/src/editor.rs at line 20
  [3.10615]→[3.10615:10678](∅→∅)
  − pub fn with_extension(mut self, extension: &str) -> Self {
  [3.10615]

  [3.10678]
  + #[must_use] pub fn with_extension(mut self, extension: &str) -> Self {
• replacement in fluent_embed_derive/src/macro_impl/mod.rs at line 63
  [3.454]→[3.454:530](∅→∅)
  − .map_err(|parse_error| ParseError::InvalidAttribute(parse_error))?;
  [3.454]

  [3.530]
  + .map_err(ParseError::InvalidAttribute)?;
• replacement in fluent_embed_derive/src/macro_impl/mod.rs at line 65
  [3.604]→[3.604:682](∅→∅)
  − .map_err(|parse_error| ParseError::InvalidDeriveInput(parse_error))?;
  [3.604]

  [3.682]
  + .map_err(ParseError::InvalidDeriveInput)?;
• replacement in fluent_embed_derive/src/macro_impl/error.rs at line 2
  [3.1515]→[3.1515:1530](∅→∅)
  − attribute,
  [3.1515]

  [3.1530]
  + MacroError, ParseError, UnsupportedError, UnsupportedReason, attribute,
• edit in fluent_embed_derive/src/macro_impl/error.rs at line 4
  [3.1562]→[3.735:800](∅→∅)
  − MacroError, ParseError, UnsupportedError, UnsupportedReason,
• edit in fluent_embed_derive/src/macro_impl/error.rs at line 6
  [3.1028]

  [3.2240]
  + use proc_macro_error2::{emit_call_site_error, emit_error};
• edit in fluent_embed_derive/src/macro_impl/error.rs at line 8
  [3.2270]→[3.0:59](∅→∅)
  − use proc_macro_error2::{emit_call_site_error, emit_error};
• replacement in fluent_embed_derive/src/macro_impl/error.rs at line 10
  [3.1124]→[3.2356:2427](∅→∅)
  − fn attribute(error: attribute::Error, attribute_stream: TokenStream) {
  [3.1124]

  [3.1194]
  + fn attribute(error: attribute::Error, attribute_stream: &TokenStream) {
• replacement in fluent_embed_derive/src/macro_impl/error.rs at line 85
  [3.168]→[3.168:229](∅→∅)
  − fn group(error: GroupError, attribute_stream: TokenStream) {
  [3.168]

  [3.229]
  + fn group(error: GroupError, attribute_stream: &TokenStream) {
• replacement in fluent_embed_derive/src/macro_impl/error.rs at line 120
  [3.931]→[3.931:1026](∅→∅)
  − fn parse(error: ParseError, attribute_stream: TokenStream, derive_input_stream: TokenStream) {
  [3.931]

  [3.1026]
  + fn parse(error: ParseError, attribute_stream: &TokenStream, derive_input_stream: &TokenStream) {
• replacement in fluent_embed_derive/src/macro_impl/error.rs at line 136
  [3.4667]→[3.1522:1620](∅→∅)
  − pub fn emit(error: MacroError, attribute_stream: TokenStream, derive_input_stream: TokenStream) {
  [3.4667]

  [3.4797]
  + pub fn emit(error: MacroError, attribute_stream: &TokenStream, derive_input_stream: &TokenStream) {
• replacement in fluent_embed_derive/src/macro_impl/derive.rs at line 74
  [3.929]→[3.929:969](∅→∅)
  − .map(|ident| ident.to_string())
  [3.929]

  [3.969]
  + .map(std::string::ToString::to_string)
• replacement in fluent_embed_derive/src/lib.rs at line 2
  [3.75]→[3.60:103](∅→∅)
  − use proc_macro_error2::{proc_macro_error};
  [3.75]

  [3.4348]
  + use proc_macro_error2::proc_macro_error;
• replacement in fluent_embed_derive/src/lib.rs at line 36
  [3.5545]→[3.2025:2116](∅→∅)
  − macro_impl::error::emit(error, attribute_stream, derive_input_stream.clone());
  [3.5545]

  [3.906]
  + macro_impl::error::emit(error, &attribute_stream, &derive_input_stream);
• replacement in fluent_embed_derive/src/fluent/mod.rs at line 98
  [3.2312]→[3.2312:2383](∅→∅)
  − let message_id = message_entry.id.name.to_owned();
  [3.2312]

  [3.2383]
  + let message_id = message_entry.id.name.clone();
• replacement in fluent_embed_derive/src/fluent/mod.rs at line 106
  [3.312]→[3.312:412](∅→∅)
  − Entry::Comment(_) | Entry::GroupComment(_) | Entry::ResourceComment(_) => continue,
  [3.312]

  [3.2865]
  + Entry::Comment(_) | Entry::GroupComment(_) | Entry::ResourceComment(_) => (),
• replacement in fluent_embed_derive/src/fluent/group.rs at line 102
  [3.6380]→[3.6380:6428](∅→∅)
  − pub fn canonical_locale(&self) -> &Locale {
  [3.6380]

  [3.6428]
  + pub const fn canonical_locale(&self) -> &Locale {
• replacement in fluent_embed_derive/src/fluent/group.rs at line 142
  [3.6937]→[3.5853:5922](∅→∅)
  − for (locale, compiled_messages) in self.locales.iter_mut() {
  [3.6937]

  [3.8681]
  + for (locale, compiled_messages) in &mut self.locales {
• replacement in fluent_embed_derive/src/fluent/group.rs at line 146
  [3.4666]→[3.4666:4714](∅→∅)
  − source: &compiled_messages,
  [3.4666]

  [3.4748]
  + source: compiled_messages,
• replacement in fluent_embed_derive/src/fluent/ast.rs at line 121
  [3.6230]→[3.1426:1489](∅→∅)
  − span: SourceSpan::from(span.0.to_owned()),
  [3.6230]

  [3.6305]
  + span: SourceSpan::from(span.0.clone()),
• replacement in fluent_embed/src/time.rs at line 25
  [3.1022]→[3.1022:1072](∅→∅)
  − let current_timestamp = Timestamp::now();
  [3.1022]

  [3.1072]
  + let current_timestamp = Self::now();
• replacement in fluent_embed/src/time.rs at line 42
  [3.1680]→[3.1680:1995](∅→∅)
  − (Unit::Year, unformatted_span.get_years() as i64),

  − (Unit::Month, unformatted_span.get_months() as i64),

  − (Unit::Week, unformatted_span.get_weeks() as i64),

  − (Unit::Day, unformatted_span.get_days() as i64),

  − (Unit::Hour, unformatted_span.get_hours() as i64),
  [3.1680]

  [3.1995]
  + (Unit::Year, i64::from(unformatted_span.get_years())),

  + (Unit::Month, i64::from(unformatted_span.get_months())),

  + (Unit::Week, i64::from(unformatted_span.get_weeks())),

  + (Unit::Day, i64::from(unformatted_span.get_days())),

  + (Unit::Hour, i64::from(unformatted_span.get_hours())),
• replacement in fluent_embed/src/time.rs at line 55
  [3.2274]→[3.2274:2353](∅→∅)
  − .map(|(unit, _value)| *unit)

  − .unwrap_or(Unit::Second);
  [3.2274]

  [3.2353]
  + .map_or(Unit::Second, |(unit, _value)| *unit);
• replacement in fluent_embed/src/time.rs at line 70
  [3.2827]→[3.2827:3132](∅→∅)
  − Unit::Year => formatted_span.get_years() as i64,

  − Unit::Month => formatted_span.get_months() as i64,

  − Unit::Week => formatted_span.get_weeks() as i64,

  − Unit::Day => formatted_span.get_days() as i64,

  − Unit::Hour => formatted_span.get_hours() as i64,
  [3.2827]

  [3.3132]
  + Unit::Year => i64::from(formatted_span.get_years()),

  + Unit::Month => i64::from(formatted_span.get_months()),

  + Unit::Week => i64::from(formatted_span.get_weeks()),

  + Unit::Day => i64::from(formatted_span.get_days()),

  + Unit::Hour => i64::from(formatted_span.get_hours()),
• replacement in fluent_embed/src/string.rs at line 25
  [2.2055]→[2.2055:2080](∅→∅)
  − self.to_string()
  [2.2055]

  [3.850]
  + (*self).to_string()
• replacement in fluent_embed/src/decimal.rs at line 26
  [3.3529]→[3.4766:4855](∅→∅)
  − [f32] [Decimal::try_from_f64(*self as f64, FloatPrecision::RoundTrip).unwrap()];
  [3.3529]

  [3.4855]
  + [f32] [Decimal::try_from_f64(f64::from(*self), FloatPrecision::RoundTrip).unwrap()];