{"header":{"message":"Add rudimentary support for built-in `LEN()` function","description":"Will need a refactor to support more complex use-cases - currently only vecs are supported.","timestamp":"2025-08-18T07:29:07.901134277Z","authors":[{}]},"hash":"XPGOKS6XWM2Q2R74DDEHQRMZH6BWQH2FMQGAXBLO7FW52J3VFKSQC","authors":[{"login":"finchie","key":"6WCsL9cxQoPBLLwR1PUvmFBJi6wGTGFAxcxMovPQCwTZ"}],"deps":{"hashes":[["XPGOKS6XWM2Q2R74DDEHQRMZH6BWQH2FMQGAXBLO7FW52J3VFKSQC","Add rudimentary support for built-in `LEN()` function"],["AA",null],["XDJBTEXUZNIAC2TKC4Z3OZORWAXR4ZWYUHNM6OEGXTL6WZDXOVZQC","Add support for integer selectors"],["D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC","Rename `parse` module to `parse_fluent`"],["5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC","Split `fluent_embed` into `group` and `parse` modules"],["3NMKD6I57ONAGHEN4PZIAV2KPYESVR4JL3DTWSHXKCMVJBEQ4GIQC","Refactor `Localize` trait to use `std::io::Write`"],["F5LG7WENUUDRSCTDMA4M6BAC5RWTGQO45C4ZEBZDX6FHCTTHBVGQC","Emit compilation errors from Fluent source code"],["QFPQZR4K4UZ7R2GQZJG4NYBGVQJVL2ANIKGGTOHAMIRIBQHPSQGAC","Refactor `fluent_embed`"],["CESJ4CTO26X4GBZBPXRXLOJT3JQJOGFN5EJSNAAZELNQRZF7QSYAC","Move macro-specific code into `macro_impl` module"],["VNSHGQYNPGKGGPYNVP4Z2RWD7JCSDJVYAADD6UXWBYL6ZRXKLE4AC","Support using glob paths in `localize` macro"],["XEEXWJLGVIPIGURSDU4ETZMGAIFTFDPECM4QWFOSRHU7GMGVOUVQC","Add simple end-to-end test for selectors"],["2SITVDYW6KANM24QXRHVSBL6S77UHKJLOSOHSUZQBJFL5NAAGQYAC","Handle common errors in Fluent code"]],"deps":["XDJBTEXUZNIAC2TKC4Z3OZORWAXR4ZWYUHNM6OEGXTL6WZDXOVZQC"],"known":["5TEX4MNUC4LDDRMNEOVCFNUUEZAGUXMKO3OIEQFXWRQKXSHY2NRQC","D652S2N3MHR7NJWSJIT7DUH5TPEFF6YII7EGV4C7IYWARXLMGAWQC","F5LG7WENUUDRSCTDMA4M6BAC5RWTGQO45C4ZEBZDX6FHCTTHBVGQC","QFPQZR4K4UZ7R2GQZJG4NYBGVQJVL2ANIKGGTOHAMIRIBQHPSQGAC","CESJ4CTO26X4GBZBPXRXLOJT3JQJOGFN5EJSNAAZELNQRZF7QSYAC","3NMKD6I57ONAGHEN4PZIAV2KPYESVR4JL3DTWSHXKCMVJBEQ4GIQC"]},"hunks":[{"FileAdd":{"meta":{"basename":"functions.ftl","metadata":0},"context":[{"change":10,"pos":990}],"contents":[{"Add":"length = Item count: { LEN($items) }"},{"Add":"numbers = { LEN($items) ->"},{"Add":" [0] No items"},{"Add":" [1] One item"},{"Add":" *[other] { LEN($items) } items"},{"Add":"}"},{"Add":"plurals = { LEN($items) ->"},{"Add":" [one] One item"},{"Add":" *[other] { LEN($items) } items"},{"Add":"}"}]}},{"FileAdd":{"meta":{"basename":"functions.rs","metadata":0},"context":[{"change":11,"pos":101}],"contents":[{"Add":"//! End-to-end test for function support in the `l10n_embed_derive` macro"},{"Add":""},{"Add":"mod common;"},{"Add":""},{"Add":"use common::compare_message;"},{"Add":"use icu_locale::{Locale, locale};"},{"Add":"use l10n_embed_derive::localize;"},{"Add":"use rstest::rstest;"},{"Add":""},{"Add":"const DEFAULT_LOCALE: Locale = locale!(\"en-US\");"},{"Add":""},{"Add":"#[localize(\"tests/locale/**/functions.ftl\")]"},{"Add":"pub enum MessageEnum {"},{"Add":" Length { items: Vec },"},{"Add":" Numbers { items: Vec },"},{"Add":" Plurals { items: Vec },"},{"Add":"}"},{"Add":""},{"Add":"#[localize(\"tests/locale/**/functions.ftl\")]"},{"Add":"pub struct Length {"},{"Add":" items: Vec,"},{"Add":"}"},{"Add":""},{"Add":"#[localize(\"tests/locale/**/functions.ftl\")]"},{"Add":"pub struct Numbers {"},{"Add":" items: Vec,"},{"Add":"}"},{"Add":""},{"Add":"#[localize(\"tests/locale/**/functions.ftl\")]"},{"Add":"pub struct Plurals {"},{"Add":" items: Vec,"},{"Add":"}"},{"Add":""},{"Add":"#[rstest]"},{"Add":"#[case::zero(0)]"},{"Add":"#[case::one(1)]"},{"Add":"#[case::two(2)]"},{"Add":"fn len(#[case] item_count: usize) {"},{"Add":" let items: Vec = (0..item_count)"},{"Add":" .map(|index| format!(\"Item {index}\"))"},{"Add":" .collect();"},{"Add":""},{"Add":" compare_message("},{"Add":" MessageEnum::Length {"},{"Add":" items: items.clone(),"},{"Add":" },"},{"Add":" format!(\"Item count: {item_count}\"),"},{"Add":" DEFAULT_LOCALE,"},{"Add":" );"},{"Add":" compare_message("},{"Add":" Length { items },"},{"Add":" format!(\"Item count: {item_count}\"),"},{"Add":" DEFAULT_LOCALE,"},{"Add":" );"},{"Add":"}"},{"Add":""},{"Add":"#[rstest]"},{"Add":"#[case::zero(0, \"No items\")]"},{"Add":"#[case::one(1, \"One item\")]"},{"Add":"#[case::two(2, \"2 items\")]"},{"Add":"fn numbers(#[case] item_count: usize, #[case] expected: &str) {"},{"Add":" let items: Vec = (0..item_count)"},{"Add":" .map(|index| format!(\"Item {index}\"))"},{"Add":" .collect();"},{"Add":""},{"Add":" compare_message("},{"Add":" MessageEnum::Numbers {"},{"Add":" items: items.clone(),"},{"Add":" },"},{"Add":" expected,"},{"Add":" DEFAULT_LOCALE,"},{"Add":" );"},{"Add":" compare_message(Numbers { items }, expected, DEFAULT_LOCALE);"},{"Add":"}"},{"Add":""},{"Add":"#[rstest]"},{"Add":"#[case::zero(0, \"0 items\")]"},{"Add":"#[case::one(1, \"One item\")]"},{"Add":"#[case::two(2, \"2 items\")]"},{"Add":"fn plurals(#[case] item_count: usize, #[case] expected: &str) {"},{"Add":" let items: Vec = (0..item_count)"},{"Add":" .map(|index| format!(\"Item {index}\"))"},{"Add":" .collect();"},{"Add":""},{"Add":" compare_message("},{"Add":" MessageEnum::Plurals {"},{"Add":" items: items.clone(),"},{"Add":" },"},{"Add":" expected,"},{"Add":" DEFAULT_LOCALE,"},{"Add":" );"},{"Add":" compare_message(Plurals { items }, expected, DEFAULT_LOCALE);"},{"Add":"}"}]}},{"Edit":{"inode":{"change":3,"pos":992},"path":"l10n_embed_derive/src/fluent/mod.rs","line":24,"atom":{"NewVertex":{"up_context":[{"change":12,"pos":346}],"down_context":[{"change":3,"pos":1320}],"flag":"BLOCK","start":2483,"end":3800,"inode":{"change":3,"pos":992}}},"contents":[{"Add":"#[error(\"unable to parse Fluent function\")]"},{"Add":"pub enum FunctionError {"},{"Add":" InvalidName {"},{"Add":" name: String,"},{"Add":" #[source_code]"},{"Add":" source_code: NamedSource,"},{"Add":" // TODO: blocked on https://github.com/projectfluent/fluent-rs/pull/373"},{"Add":" // #[label(\"This key isn't in the `{canonical_locale}` locale\")]"},{"Add":" // span: SourceSpan,"},{"Add":" },"},{"Add":" IncorrectPositionalArgumentCount {"},{"Add":" expected_len: usize,"},{"Add":" actual_len: usize,"},{"Add":" #[source_code]"},{"Add":" source_code: NamedSource,"},{"Add":" // TODO: blocked on https://github.com/projectfluent/fluent-rs/pull/373"},{"Add":" // #[label(\"This key isn't in the `{canonical_locale}` locale\")]"},{"Add":" // span: SourceSpan,"},{"Add":" },"},{"Add":" UnexpectedNamedArguments {"},{"Add":" #[source_code]"},{"Add":" source_code: NamedSource,"},{"Add":" // TODO: blocked on https://github.com/projectfluent/fluent-rs/pull/373"},{"Add":" // #[label(\"This key isn't in the `{canonical_locale}` locale\")]"},{"Add":" // span: SourceSpan,"},{"Add":" },"},{"Add":" NonVariableReference {"},{"Add":" #[source_code]"},{"Add":" source_code: NamedSource,"},{"Add":" // TODO: blocked on https://github.com/projectfluent/fluent-rs/pull/373"},{"Add":" // #[label(\"This key isn't in the `{canonical_locale}` locale\")]"},{"Add":" // span: SourceSpan,"},{"Add":" },"},{"Add":"}"},{"Add":""},{"Add":"#[derive(Diagnostic, Debug, Error)]"}]}},{"Edit":{"inode":{"change":3,"pos":992},"path":"l10n_embed_derive/src/fluent/mod.rs","line":106,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":2860}],"down_context":[{"change":12,"pos":1364}],"flag":"BLOCK","start":3801,"end":3887,"inode":{"change":3,"pos":992}}},"contents":[{"Add":" #[error(transparent)]"},{"Add":" #[diagnostic(transparent)]"},{"Add":" Function(FunctionError),"}]}},{"Replacement":{"inode":{"change":3,"pos":33},"path":"l10n_embed_derive/src/fluent/ast.rs","line":3,"ins":{"up_context":[{"change":3,"pos":856}],"down_context":[{"change":3,"pos":6229}],"flag":"BLOCK","start":3888,"end":3939,"inode":{"change":3,"pos":33}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":856},"to":{"change":3,"start":6411,"end":6447},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":33},"to":{"change":3,"start":6411,"end":6447},"introduced_by":3}],"inode":{"change":3,"pos":33}},"ins_contents":[{"Add":"use super::{Error, FunctionError, MessageContext};"}],"del_contents":[{"Del":"use super::{Error, MessageContext};\n"}]}},{"Replacement":{"inode":{"change":3,"pos":33},"path":"l10n_embed_derive/src/fluent/ast.rs","line":46,"ins":{"up_context":[{"change":2,"pos":3751}],"down_context":[{"change":2,"pos":3966}],"flag":"BLOCK","start":3940,"end":4453,"inode":{"change":3,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3751},"to":{"change":2,"start":3751,"end":3966},"introduced_by":2}],"inode":{"change":3,"pos":33}},"ins_contents":[{"Add":" let category_reference = match selector {"},{"Add":" // Can't dereference value returned by function"},{"Add":" InlineExpression::FunctionReference { .. } => {"},{"Add":" quote!(#raw_match_target)"},{"Add":" }"},{"Add":" // Only dereference if enum variant"},{"Add":" _ => match message_context.derive_context.reference_kind {"}],"del_contents":[{"Del":" // Only dereference if enum variant\n let category_reference =\n match message_context.derive_context.reference_kind {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":33},"path":"l10n_embed_derive/src/fluent/ast.rs","line":55,"ins":{"up_context":[{"change":2,"pos":4159}],"down_context":[{"change":2,"pos":4198}],"flag":"BLOCK","start":4454,"end":4528,"inode":{"change":3,"pos":33}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":4159},"to":{"change":2,"start":4159,"end":4198},"introduced_by":2}],"inode":{"change":3,"pos":33}},"ins_contents":[{"Add":" },"},{"Add":" };"}],"del_contents":[{"Del":" };\n"}]}},{"Edit":{"inode":{"change":3,"pos":33},"path":"l10n_embed_derive/src/fluent/ast.rs","line":288,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2509}],"down_context":[{"change":3,"pos":2509}],"flag":"BLOCK","start":4529,"end":6792,"inode":{"change":3,"pos":33}}},"contents":[{"Add":" InlineExpression::FunctionReference { id, arguments } => {"},{"Add":" match id.name.to_snake_case().as_str() {"},{"Add":" \"len\" => {"},{"Add":" if !arguments.named.is_empty() {"},{"Add":" return Err(Error::Function(FunctionError::UnexpectedNamedArguments {"},{"Add":" source_code: message_context.source.named_source.clone(),"},{"Add":" }));"},{"Add":" }"},{"Add":""},{"Add":" let argument = match arguments.positional.as_slice() {"},{"Add":" [single_argument] => single_argument,"},{"Add":" _ => {"},{"Add":" return Err(Error::Function("},{"Add":" FunctionError::IncorrectPositionalArgumentCount {"},{"Add":" expected_len: 1,"},{"Add":" actual_len: arguments.positional.len(),"},{"Add":" source_code: message_context.source.named_source.clone(),"},{"Add":" },"},{"Add":" ));"},{"Add":" }"},{"Add":" };"},{"Add":""},{"Add":" let variable_reference = match argument {"},{"Add":" InlineExpression::VariableReference { .. } => {"},{"Add":" inline_expression(argument, message_context)?"},{"Add":" }"},{"Add":" _ => {"},{"Add":" return Err(Error::Function(FunctionError::NonVariableReference {"},{"Add":" source_code: message_context.source.named_source.clone(),"},{"Add":" }));"},{"Add":" }"},{"Add":" };"},{"Add":""},{"Add":" let vec_reference = match message_context.derive_context.reference_kind {"},{"Add":" ReferenceKind::EnumField => quote!(#variable_reference),"},{"Add":" ReferenceKind::StructField => quote!(&#variable_reference),"},{"Add":" };"},{"Add":""},{"Add":" parse_quote!(Vec::len(#vec_reference))"},{"Add":" }"},{"Add":" _ => {"},{"Add":" return Err(Error::Function(FunctionError::InvalidName {"},{"Add":" name: id.name.clone(),"},{"Add":" source_code: message_context.source.named_source.clone(),"},{"Add":" }));"},{"Add":" }"},{"Add":" }"},{"Add":" }"}]}}],"owner":"finchie","repo":"l10n_embed","token":"OhdKJzUy4ireP0A78p3Wg/O8BqiJnAEmDFmKUrJjcHQ=","login":null}

…

Dependencies

Change contents