finchie/l10n_embed - Change IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC

Move prompt message to initial constructor

Since with_prompt was shared between all prompts, it is more idiomatic to have it in the constructor.

Created by finchie on August 8, 2025

IZ67IMRIPBOYLOAR5WE5NYA7MHOT7TXXEE7WM63MU4JSH6OM7YQQC

Dependencies

In channels

main

Change contents

Replacement in l10n_embed_interaction/src/prompt/select.rs at line 1 [3.109]
B:BD[3.109] → [4.16:74]
```
use super::macros::{impl_with_default, impl_with_prompt};
```
[3.109]
[5.0]
```
use super::macros::impl_with_default;
```
Insertion in l10n_embed_interaction/src/prompt/select.rs at line 7 [3.109]
[4.164]
[3.347]
```
    localized_prompt: String,
```
Deletion in l10n_embed_interaction/src/prompt/select.rs at line 10 [3.109]
B:BD[3.407] → [3.407:435]
```
    prompt: Option<String>,
```
Deletion in l10n_embed_interaction/src/prompt/select.rs at line 13 [3.109]
B:BD[3.492] → [3.492:519]
```
impl_with_prompt!(Select);
```

Replacement in l10n_embed_interaction/src/prompt/select.rs at line 15 [3.109]

B:BD[4.207] → [4.207:307]

    pub(crate) fn new_from_environment(environment: &'environment InteractionEnvironment) -> Self {

[4.207]

[4.307]

    pub(crate) fn new_from_environment<L: Localize>(
        environment: &'environment InteractionEnvironment,
        prompt: L,
    ) -> Self {
        let localized_prompt = prompt.localize_for(&environment.locale);

Insertion in l10n_embed_interaction/src/prompt/select.rs at line 23 [3.109]
[4.347]
[4.347]
```
            localized_prompt,
```
Deletion in l10n_embed_interaction/src/prompt/select.rs at line 26 [3.109]
B:BD[4.399] → [4.399:425]
```
            prompt: None,
```

Replacement in l10n_embed_interaction/src/prompt/select.rs at line 42 [3.109]

B:BD[3.1339] → [6.0:85]

                let mut prompt = dialoguer::FuzzySelect::with_theme(&*super::THEME);

[3.1339]

[3.1424]

                let mut prompt = dialoguer::FuzzySelect::with_theme(&*super::THEME)
                    .with_prompt(self.localized_prompt);

Deletion in l10n_embed_interaction/src/prompt/select.rs at line 53 [3.109]

B:BD[3.1672] → [3.1672:1810]

                if let Some(prompt_text) = self.prompt {
                    prompt = prompt.with_prompt(prompt_text);
                }

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 1 [3.2012]
B:BD[3.2012] → [4.632:692]
```
use super::macros::{impl_with_prompt, impl_with_validator};
```
[3.2012]
[5.303]
```
use super::macros::impl_with_validator;
```
Replacement in l10n_embed_interaction/src/prompt/password.rs at line 6 [3.2012]
B:BD[3.2243] → [3.2243:2263]
```
    prompt: String,
```
[3.2243]
[3.2263]
```
    localized_prompt: String,
```
Insertion in l10n_embed_interaction/src/prompt/password.rs at line 12 [3.2012]
[4.784]
[3.2335]
```
    prompt: String,
```
Deletion in l10n_embed_interaction/src/prompt/password.rs at line 14 [3.2012]
B:BD[3.2383] → [3.2383:2411]
```
    prompt: Option<String>,
```
Deletion in l10n_embed_interaction/src/prompt/password.rs at line 17 [3.2012]
B:BD[3.2502] → [3.2502:2531]
```
impl_with_prompt!(Password);
```

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 20 [3.2012]

B:BD[4.829] → [4.829:929]

    pub(crate) fn new_from_environment(environment: &'environment InteractionEnvironment) -> Self {

[4.829]

[4.929]

    pub(crate) fn new_from_environment<L: Localize>(
        environment: &'environment InteractionEnvironment,
        prompt: L,
    ) -> Self {
        let localized_prompt = prompt.localize_for(&environment.locale);

Insertion in l10n_embed_interaction/src/prompt/password.rs at line 28 [3.2012]
[4.969]
[4.969]
```
            prompt: localized_prompt,
```
Deletion in l10n_embed_interaction/src/prompt/password.rs at line 30 [3.2012]
B:BD[4.1001] → [4.1001:1027]
```
            prompt: None,
```
Replacement in l10n_embed_interaction/src/prompt/password.rs at line 43 [3.2012]
B:BD[3.3099] → [3.3099:3138]
```
            prompt: confirmation_text,
```
[3.3099]
[3.3138]
```
            localized_prompt: confirmation_text,
```

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 53 [3.2012]

B:BD[3.3438] → [6.86:168]

                let mut prompt = dialoguer::Password::with_theme(&*super::THEME);

[3.3438]

[3.3520]

                let mut prompt =
                    dialoguer::Password::with_theme(&*super::THEME).with_prompt(self.prompt);

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 57 [3.2012]

B:BD[3.3585] → [3.3585:3714]

                    prompt =
                        prompt.with_confirmation(confirmation.prompt, confirmation.mismatch_error);

[3.3585]

[3.3714]

                    prompt = prompt.with_confirmation(
                        confirmation.localized_prompt,
                        confirmation.mismatch_error,
                    );

Deletion in l10n_embed_interaction/src/prompt/password.rs at line 63 [3.2012]

B:BD[3.3733] → [3.3733:3871]

                if let Some(prompt_text) = self.prompt {
                    prompt = prompt.with_prompt(prompt_text);
                }

Deletion in l10n_embed_interaction/src/prompt/macros.rs at line 12 [3.4406]

B:BD[3.4855] → [3.4855:4914]

B:BD[3.4914] → [4.1532:1584]

∅:D[4.1584] → [7.88:175]

B:BD[3.4938] → [7.88:175]

B:BD[7.175] → [2.245:329]

∅:D[8.216] → [3.5244:5296]

∅:D[2.329] → [3.5244:5296]

∅:D[9.475] → [3.5244:5296]

∅:D[4.1675] → [3.5244:5296]

B:BD[3.5244] → [3.5244:5296]


macro_rules! impl_with_prompt {
    ($newtype:ident) => {
        impl<'environment> $newtype<'environment> {
            pub fn with_prompt<L: l10n_embed::Localize>(mut self, prompt: L) -> Self {
                let localized_text = prompt.localize_for(&self.environment.locale);
                self.prompt = Some(localized_text);

Deletion in l10n_embed_interaction/src/prompt/macros.rs at line 13 [3.4406]
B:BD[3.5297] → [9.476:497]
∅:D[9.497] → [3.5322:5356]
B:BD[3.5322] → [3.5322:5356]
```
                self
            }
        }
    };
}
```

Replacement in l10n_embed_interaction/src/prompt/macros.rs at line 41 [3.4406]

B:BD[3.6369] → [4.1862:1937]

pub(crate) use {impl_with_default, impl_with_prompt, impl_with_validator};

[3.6369]

pub(crate) use {impl_with_default, impl_with_validator};

Replacement in l10n_embed_interaction/src/prompt/input.rs at line 1 [3.6488]
B:BD[3.6488] → [4.1938:1998]
```
use super::macros::{impl_with_prompt, impl_with_validator};
```
[3.6488]
[5.526]
```
use super::macros::impl_with_validator;
```
Insertion in l10n_embed_interaction/src/prompt/input.rs at line 7 [3.6488]
[4.2087]
[3.6727]
```
    localized_prompt: String,
```
Deletion in l10n_embed_interaction/src/prompt/input.rs at line 9 [3.6488]
B:BD[3.6756] → [3.6756:6784]
```
    prompt: Option<String>,
```
Deletion in l10n_embed_interaction/src/prompt/input.rs at line 12 [3.6488]
B:BD[3.6872] → [3.6872:6898]
```
impl_with_prompt!(Input);
```

Replacement in l10n_embed_interaction/src/prompt/input.rs at line 15 [3.6488]

B:BD[4.2129] → [4.2129:2229]

    pub(crate) fn new_from_environment(environment: &'environment InteractionEnvironment) -> Self {

[4.2129]

[4.2229]

    pub(crate) fn new_from_environment<L: Localize>(
        environment: &'environment InteractionEnvironment,
        prompt: L,
    ) -> Self {
        let localized_prompt = prompt.localize_for(&environment.locale);

Insertion in l10n_embed_interaction/src/prompt/input.rs at line 23 [3.6488]
[4.2269]
[4.2269]
```
            localized_prompt,
```
Deletion in l10n_embed_interaction/src/prompt/input.rs at line 25 [3.6488]
B:BD[4.2296] → [4.2296:2322]
```
            prompt: None,
```

Replacement in l10n_embed_interaction/src/prompt/input.rs at line 39 [3.6488]

B:BD[3.7455] → [6.315:394]

                let mut prompt = dialoguer::Input::with_theme(&*super::THEME);

[3.7455]

[3.7534]

                let mut prompt =
                    dialoguer::Input::with_theme(&*super::THEME).with_prompt(self.localized_prompt);

Deletion in l10n_embed_interaction/src/prompt/input.rs at line 46 [3.6488]

B:BD[3.7662] → [3.7662:7800]

                if let Some(prompt_text) = self.prompt {
                    prompt = prompt.with_prompt(prompt_text);
                }

Replacement in l10n_embed_interaction/src/prompt/confirm.rs at line 1 [3.8140]
B:BD[3.8140] → [4.2567:2625]
```
use super::macros::{impl_with_default, impl_with_prompt};
```
[3.8140]
[5.749]
```
use super::macros::impl_with_default;
```
Insertion in l10n_embed_interaction/src/prompt/confirm.rs at line 3 [3.8140]
[5.804]
[3.8338]
```
use l10n_embed::Localize;
```
Insertion in l10n_embed_interaction/src/prompt/confirm.rs at line 8 [3.8140]
[4.2716]
[3.8379]
```
    localized_prompt: String,
```
Deletion in l10n_embed_interaction/src/prompt/confirm.rs at line 10 [3.8140]
B:BD[3.8406] → [3.8406:8434]
```
    prompt: Option<String>,
```
Deletion in l10n_embed_interaction/src/prompt/confirm.rs at line 13 [3.8140]
B:BD[3.8492] → [3.8492:8520]
```
impl_with_prompt!(Confirm);
```

Replacement in l10n_embed_interaction/src/prompt/confirm.rs at line 15 [3.8140]

B:BD[4.2760] → [4.2760:2860]

    pub(crate) fn new_from_environment(environment: &'environment InteractionEnvironment) -> Self {

[4.2760]

[4.2860]

    pub(crate) fn new_from_environment<L: Localize>(
        environment: &'environment InteractionEnvironment,
        prompt: L,
    ) -> Self {
        let localized_prompt = prompt.localize_for(&environment.locale);

Insertion in l10n_embed_interaction/src/prompt/confirm.rs at line 23 [3.8140]
[4.2900]
[4.2900]
```
            localized_prompt,
```
Deletion in l10n_embed_interaction/src/prompt/confirm.rs at line 25 [3.8140]
B:BD[4.2927] → [4.2927:2953]
```
            prompt: None,
```

Replacement in l10n_embed_interaction/src/prompt/confirm.rs at line 31 [3.8140]

B:BD[3.8725] → [6.395:476]

                let mut prompt = dialoguer::Confirm::with_theme(&*super::THEME);

[3.8725]

[3.8806]

                let mut confirm = dialoguer::Confirm::with_theme(&*super::THEME)
                    .with_prompt(self.localized_prompt);

Replacement in l10n_embed_interaction/src/prompt/confirm.rs at line 35 [3.8140]

B:BD[3.8861] → [3.8861:8915]

                    prompt = prompt.default(default);

[3.8861]

[3.8915]

                    confirm = confirm.default(default);

Replacement in l10n_embed_interaction/src/prompt/confirm.rs at line 38 [3.8140]

B:BD[3.8934] → [3.8934:9072]

B:BD[3.9072] → [5.937:982]

                if let Some(prompt_text) = self.prompt {
                    prompt = prompt.with_prompt(prompt_text);
                }
                Ok(Some(prompt.interact()?))

[3.8934]

[3.9111]

                Ok(Some(confirm.interact()?))

Replacement in l10n_embed_interaction/src/lib.rs at line 62 [3.9269]

B:BD[4.3949] → [4.3949:4104]

            pub fn $prompt_name<'environment>(&'environment self) -> $prompt_type<'environment> {
                $prompt_type::new_from_environment(self)

[4.3949]

[4.4104]

            pub fn $prompt_name<'environment, L: Localize>(
                &'environment self,
                prompt: L,
            ) -> $prompt_type<'environment> {
                $prompt_type::new_from_environment(self, prompt)

Replacement in l10n_embed_interaction/src/lib.rs at line 72 [3.9269]

B:BD[4.4138] → [4.4138:4219]

// Create constructors on InteractionEnvironment for different interaction types

[4.4138]

[4.4219]

// Create constructors on InteractionEnvironment for different prompt types

Deletion in l10n_embed_interaction/src/lib.rs at line 74 [3.9269]
B:BD[4.4260] → [4.4260:4299]
```
impl_constructor!(new_editor, Editor);
```

Insertion in l10n_embed_interaction/src/lib.rs at line 77 [3.9269]

[4.4418]


// Special implementation for text editor as the signature is different
impl InteractionEnvironment {
    pub fn new_editor<'environment>(&'environment self, extension: &str) -> Editor<'environment> {
        Editor::new_from_environment(self, extension)
    }
}

Replacement in l10n_embed_interaction/src/editor.rs at line 5 [3.10371]
∅:D[4.4822] → [3.10500:10531]
B:BD[3.10500] → [3.10500:10531]
```
    extension: Option<String>,
```
[4.4822]
[10.374]
```
    extension: String,
    executable: Option<String>,
```

Replacement in l10n_embed_interaction/src/editor.rs at line 10 [3.10371]

B:BD[4.4865] → [4.4865:4965]

    pub(crate) fn new_from_environment(environment: &'environment InteractionEnvironment) -> Self {

[4.4865]

[4.4965]

    pub(crate) fn new_from_environment(
        environment: &'environment InteractionEnvironment,
        extension: &str,
    ) -> Self {

Replacement in l10n_embed_interaction/src/editor.rs at line 16 [3.10371]

B:BD[4.5005] → [4.5005:5034]

            extension: None,

[4.5005]

[4.5034]

            extension: extension.to_string(),
            executable: None,

Replacement in l10n_embed_interaction/src/editor.rs at line 22 [3.10371]

B:BD[5.1193] → [5.1193:1256]

∅:D[10.578] → [3.10678:10732]

∅:D[5.1256] → [3.10678:10732]

B:BD[3.10678] → [3.10678:10732]

    pub fn with_extension(mut self, extension: &str) -> Self {
        self.extension = Some(extension.to_string());

[5.1143]

[3.10732]

    pub fn with_executable(mut self, executable: &str) -> Self {
        self.executable = Some(executable.to_string());

Replacement in l10n_embed_interaction/src/editor.rs at line 32 [3.10371]

B:BD[3.11044] → [3.11044:11152]

                if let Some(extension) = &self.extension {
                    editor.extension(extension);

[3.11044]

[3.11152]

                // Dialoguer just appends the extension to the file, so add a `.` to separate it
                editor.extension(&format!(".{}", self.extension));
                if let Some(executable) = &self.executable {
                    editor.executable(executable);

Move prompt message to initial constructor

Dependencies

In channels

Change contents

Replacement in l10n_embed_interaction/src/prompt/select.rs at line 1 [3.109]

Insertion in l10n_embed_interaction/src/prompt/select.rs at line 7 [3.109]

Deletion in l10n_embed_interaction/src/prompt/select.rs at line 10 [3.109]

Deletion in l10n_embed_interaction/src/prompt/select.rs at line 13 [3.109]

Replacement in l10n_embed_interaction/src/prompt/select.rs at line 15 [3.109]

Insertion in l10n_embed_interaction/src/prompt/select.rs at line 23 [3.109]

Deletion in l10n_embed_interaction/src/prompt/select.rs at line 26 [3.109]

Replacement in l10n_embed_interaction/src/prompt/select.rs at line 42 [3.109]

Deletion in l10n_embed_interaction/src/prompt/select.rs at line 53 [3.109]

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 1 [3.2012]

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 6 [3.2012]

Insertion in l10n_embed_interaction/src/prompt/password.rs at line 12 [3.2012]

Deletion in l10n_embed_interaction/src/prompt/password.rs at line 14 [3.2012]

Deletion in l10n_embed_interaction/src/prompt/password.rs at line 17 [3.2012]

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 20 [3.2012]

Insertion in l10n_embed_interaction/src/prompt/password.rs at line 28 [3.2012]

Deletion in l10n_embed_interaction/src/prompt/password.rs at line 30 [3.2012]

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 43 [3.2012]

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 53 [3.2012]

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 57 [3.2012]

Deletion in l10n_embed_interaction/src/prompt/password.rs at line 63 [3.2012]

Deletion in l10n_embed_interaction/src/prompt/macros.rs at line 12 [3.4406]

Deletion in l10n_embed_interaction/src/prompt/macros.rs at line 13 [3.4406]

Replacement in l10n_embed_interaction/src/prompt/macros.rs at line 41 [3.4406]

Replacement in l10n_embed_interaction/src/prompt/input.rs at line 1 [3.6488]

Insertion in l10n_embed_interaction/src/prompt/input.rs at line 7 [3.6488]

Deletion in l10n_embed_interaction/src/prompt/input.rs at line 9 [3.6488]

Deletion in l10n_embed_interaction/src/prompt/input.rs at line 12 [3.6488]

Replacement in l10n_embed_interaction/src/prompt/input.rs at line 15 [3.6488]

Insertion in l10n_embed_interaction/src/prompt/input.rs at line 23 [3.6488]

Deletion in l10n_embed_interaction/src/prompt/input.rs at line 25 [3.6488]

Replacement in l10n_embed_interaction/src/prompt/input.rs at line 39 [3.6488]

Deletion in l10n_embed_interaction/src/prompt/input.rs at line 46 [3.6488]

Replacement in l10n_embed_interaction/src/prompt/confirm.rs at line 1 [3.8140]

Insertion in l10n_embed_interaction/src/prompt/confirm.rs at line 3 [3.8140]

Insertion in l10n_embed_interaction/src/prompt/confirm.rs at line 8 [3.8140]

Deletion in l10n_embed_interaction/src/prompt/confirm.rs at line 10 [3.8140]

Deletion in l10n_embed_interaction/src/prompt/confirm.rs at line 13 [3.8140]