finchie/l10n_embed - Change VJCANIBGGIS7ICGVKKD637ULAFZCWPL3NZWSKZTCA4BQWV4OSDJQC

Move `old_locale_version` hack out of `Localize` trait

This makes Localize dyn-compatible, and will make it easier to remove the hack in the future as it is now more clearly an implementation detail.

Created by finchie on July 21, 2025

VJCANIBGGIS7ICGVKKD637ULAFZCWPL3NZWSKZTCA4BQWV4OSDJQC

Dependencies

In channels

main

Change contents

Deletion in fluent_embed/src/lib.rs at line 27 [3.82]

B:BD[2.1136] → [2.1136:1142]

∅:D[2.1142] → [4.4956:4957]

∅:D[5.2154] → [4.4956:4957]

B:BD[4.4956] → [4.4956:4957]

B:BD[4.4957] → [6.2871:2928]

B:BD[6.2928] → [7.101:164]

∅:D[7.164] → [6.2974:3145]

B:BD[6.2974] → [6.2974:3145]

B:BD[6.3145] → [7.165:219]

∅:D[7.219] → [6.3199:3279]

B:BD[6.3199] → [6.3199:3279]

B:BD[6.3279] → [7.220:320]

∅:D[7.320] → [6.3379:3440]

B:BD[6.3379] → [6.3379:3440]

    }
    // TODO: remove this hack
    fn old_locale_version(
        new_locales: Vec<icu_locale_core::LanguageIdentifier>,
    ) -> Vec<icu_locid::LanguageIdentifier> {
        new_locales
            .into_iter()
            // Convert new `icu_locale::LanguageIdentifier` to canonical string
            .map(|icu_langid| icu_langid.to_string())
            // Convert canonical string to old `icu_locid` for `fluent_langneg`
            .map(|icu_langid| icu_locid::LanguageIdentifier::try_from_bytes(icu_langid.as_bytes()))
            .map(Result::unwrap)
            .collect::<_>()

Replacement in fluent_embed/src/lib.rs at line 37 [3.82]

B:BD[7.737] → [7.737:811]

∅:D[7.811] → [6.3521:3605]

B:BD[6.3521] → [6.3521:3605]

        let requested_locales = Self::old_locale_version(system_langids);
        let available_locales = Self::old_locale_version(self.available_locales());

[7.737]

[6.3605]

        let requested_locales = old_locale_version(system_langids);
        let available_locales = old_locale_version(self.available_locales());

Insertion in fluent_embed/src/lib.rs at line 55 [3.82]

[4.5310]

[3.807]

}
// TODO: remove this hack
fn old_locale_version(
    new_locales: Vec<icu_locale_core::LanguageIdentifier>,
) -> Vec<icu_locid::LanguageIdentifier> {
    new_locales
        .into_iter()
        // Convert new `icu_locale::LanguageIdentifier` to canonical string
        .map(|icu_langid| icu_langid.to_string())
        // Convert canonical string to old `icu_locid` for `fluent_langneg`
        .map(|icu_langid| icu_locid::LanguageIdentifier::try_from_bytes(icu_langid.as_bytes()))
        .map(Result::unwrap)
        .collect::<_>()