{"header":{"message":"Refactor argument type handling into enum","description":"Not much has changed visually but should be a good basis to build more sophisticated visualizations on top of","timestamp":"2023-11-20T08:44:08.500449874Z","authors":[{}]},"hash":"YTW5RB26IF3MHIED6RA3AQ7KAZHPLABJ63WFSGAO6FAATFFCP4UAC","authors":[{"login":"finchie","key":"6WCsL9cxQoPBLLwR1PUvmFBJi6wGTGFAxcxMovPQCwTZ"}],"deps":{"hashes":[["YTW5RB26IF3MHIED6RA3AQ7KAZHPLABJ63WFSGAO6FAATFFCP4UAC","Refactor argument type handling into enum"],["AA",null],["LEJN3E4QCBMUTQQKGKNHHAO6ER7R76SXEKBL46QAWZ63D3QRFLVQC","Generate more semantic HTML"],["MIY7QPYK3EZTOGZF5PWU2ZKM7NG5ANWKNHS56FVTOY7PPATWLSSAC","Refactor argument handling into a separate file"]],"deps":["LEJN3E4QCBMUTQQKGKNHHAO6ER7R76SXEKBL46QAWZ63D3QRFLVQC"],"known":["MIY7QPYK3EZTOGZF5PWU2ZKM7NG5ANWKNHS56FVTOY7PPATWLSSAC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":640},"path":"src/arg.rs","line":1,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":640}],"down_context":[{"change":3,"pos":641}],"flag":"BLOCK","start":0,"end":78,"inode":{"change":3,"pos":640}}},"contents":[{"Add":"use clap::builder::{RangedI64ValueParser, RangedU64ValueParser, ValueParser};"}]}},{"Replacement":{"inode":{"change":3,"pos":640},"path":"src/arg.rs","line":3,"ins":{"up_context":[{"change":3,"pos":672}],"down_context":[{"change":3,"pos":703}],"flag":"BLOCK","start":79,"end":107,"inode":{"change":3,"pos":640}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":672},"to":{"change":3,"start":672,"end":703},"introduced_by":3}],"inode":{"change":3,"pos":640}},"ins_contents":[{"Add":"use clap::{Arg, ValueHint};"}],"del_contents":[{"Del":"use clap::{value_parser, Arg};\n"}]}},{"Replacement":{"inode":{"change":3,"pos":640},"path":"src/arg.rs","line":8,"ins":{"up_context":[{"change":3,"pos":814}],"down_context":[{"change":3,"pos":847}],"flag":"BLOCK","start":108,"end":178,"inode":{"change":3,"pos":640}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":814},"to":{"change":3,"start":814,"end":847},"introduced_by":3}],"inode":{"change":3,"pos":640}},"ins_contents":[{"Add":"enum ValueType {"},{"Add":" Path,"},{"Add":" Command,"},{"Add":" Name,"},{"Add":" Url,"},{"Add":" Email,"}],"del_contents":[{"Del":"#[non_exhaustive]\nenum ArgType {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":640},"path":"src/arg.rs","line":15,"ins":{"up_context":[{"change":3,"pos":859}],"down_context":[{"change":3,"pos":870}],"flag":"BLOCK","start":179,"end":232,"inode":{"change":3,"pos":640}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":859},"to":{"change":3,"start":859,"end":870},"introduced_by":3}],"inode":{"change":3,"pos":640}},"ins_contents":[{"Add":" Range,"},{"Add":" Bool,"},{"Add":" Enum,"},{"Add":" Map,"},{"Add":" Unknown,"}],"del_contents":[{"Del":" Other,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":640},"path":"src/arg.rs","line":22,"ins":{"up_context":[{"change":3,"pos":873}],"down_context":[{"change":3,"pos":903}],"flag":"BLOCK","start":233,"end":741,"inode":{"change":3,"pos":640}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":873},"to":{"change":3,"start":873,"end":903},"introduced_by":3}],"inode":{"change":3,"pos":640}},"ins_contents":[{"Add":"impl ValueType {"},{"Add":" fn name(&self) -> &str {"},{"Add":" match self {"},{"Add":" Self::Path => \"path\","},{"Add":" Self::Command => \"command\","},{"Add":" Self::Name => \"name\","},{"Add":" Self::Url => \"url\","},{"Add":" Self::Email => \"email\","},{"Add":" Self::String => \"string\","},{"Add":" Self::Range => \"range\","},{"Add":" Self::Bool => \"bool\","},{"Add":" Self::Enum => \"enum\","},{"Add":" Self::Map => \"map\","},{"Add":" Self::Unknown => \"unknown\","},{"Add":" }"},{"Add":" }"},{"Add":"}"},{"Add":""},{"Add":"impl From<&Arg> for ValueType {"}],"del_contents":[{"Del":"impl From<&Arg> for ArgType {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":640},"path":"src/arg.rs","line":42,"ins":{"up_context":[{"change":3,"pos":938}],"down_context":[{"change":3,"pos":1118}],"flag":"BLOCK","start":742,"end":2769,"inode":{"change":3,"pos":640}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":938},"to":{"change":3,"start":938,"end":1118},"introduced_by":3}],"inode":{"change":3,"pos":640}},"ins_contents":[{"Add":" match value.get_value_hint() {"},{"Add":" ValueHint::AnyPath => Self::Path,"},{"Add":" ValueHint::FilePath => Self::Path,"},{"Add":" ValueHint::DirPath => Self::Path,"},{"Add":" ValueHint::ExecutablePath => Self::Path,"},{"Add":" ValueHint::CommandName => Self::Command,"},{"Add":" ValueHint::CommandString => Self::Command,"},{"Add":" ValueHint::CommandWithArguments => Self::Command,"},{"Add":" ValueHint::Username => Self::Name,"},{"Add":" ValueHint::Hostname => Self::Name,"},{"Add":" ValueHint::Url => Self::Url,"},{"Add":" ValueHint::EmailAddress => Self::Email,"},{"Add":" _ => {"},{"Add":" let type_id = value.get_value_parser().type_id();"},{"Add":" if type_id == ValueParser::new(RangedU64ValueParser::::new()).type_id() {"},{"Add":" Self::Range"},{"Add":" } else if type_id == ValueParser::new(RangedU64ValueParser::::new()).type_id()"},{"Add":" {"},{"Add":" Self::Range"},{"Add":" } else if type_id == ValueParser::new(RangedU64ValueParser::::new()).type_id()"},{"Add":" {"},{"Add":" Self::Range"},{"Add":" } else if type_id == ValueParser::new(RangedU64ValueParser::::new()).type_id()"},{"Add":" {"},{"Add":" Self::Range"},{"Add":" } else if type_id == ValueParser::new(RangedI64ValueParser::::new()).type_id() {"},{"Add":" Self::Range"},{"Add":" } else if type_id == ValueParser::new(RangedI64ValueParser::::new()).type_id()"},{"Add":" {"},{"Add":" Self::Range"},{"Add":" } else if type_id == ValueParser::new(RangedI64ValueParser::::new()).type_id()"},{"Add":" {"},{"Add":" Self::Range"},{"Add":" } else if type_id == ValueParser::new(RangedI64ValueParser::::new()).type_id()"},{"Add":" {"},{"Add":" Self::Range"},{"Add":" } else if type_id == ValueParser::string().type_id() {"},{"Add":" Self::String"},{"Add":" } else {"},{"Add":" Self::Unknown"},{"Add":" }"},{"Add":" }"}],"del_contents":[{"Del":" let type_id = value.get_value_parser().type_id();\n if type_id == value_parser!(String).type_id() {\n Self::String\n } else {\n Self::Other\n"}]}},{"Replacement":{"inode":{"change":3,"pos":640},"path":"src/arg.rs","line":89,"ins":{"up_context":[{"change":3,"pos":1201}],"down_context":[{"change":3,"pos":1516}],"flag":"BLOCK","start":2770,"end":2873,"inode":{"change":3,"pos":640}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1201},"to":{"change":3,"start":1201,"end":1258},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1258},"to":{"change":2,"start":0,"end":127},"introduced_by":2}],"inode":{"change":3,"pos":640}},"ins_contents":[{"Add":" let value_type = ValueType::from(arg);"},{"Add":" el::details(el::summary(value_type.name().to_string()))"}],"del_contents":[{"Del":" let supported_type_description = ArgType::from(arg);\n"},{"Del":" el::span(match supported_type_description {\n ArgType::String => \"string\",\n ArgType::Other => \"other\",\n })\n"}]}}],"owner":"finchie","repo":"new_manual","token":"y/PiUrdFSpsDdeX+jwNx+CKk93QW3AjSAx22lr4jK5g=","login":null}

…

Dependencies

Change contents