{"header":{"message":"Add `OpenTextEditor` event","description":"Includes a new threadsafe function to get the text contents from a `TextEditorRef`. This probably has potential for a TOCTOU bug, but I'm not sure how to avoid this without unnecessary calls to `Document::get_text()` every time the visible editor changes.","timestamp":"2026-01-02T00:53:41.458933344Z","authors":[{}]},"hash":"M5RW5PN4VFYZOKHUFMVWR2XAUAXHUYROVZFTS3RIE7AAUGTVHAEQC","authors":[{"login":"finchie","key":"6WCsL9cxQoPBLLwR1PUvmFBJi6wGTGFAxcxMovPQCwTZ"}],"deps":{"hashes":[["M5RW5PN4VFYZOKHUFMVWR2XAUAXHUYROVZFTS3RIE7AAUGTVHAEQC","Add `OpenTextEditor` event"],["AA",null],["WFWTKCJNC4VSURSQWE5FXJGTEJJOCDMQ6LN2O6EW2DNOVT2ZUMRQC","Create initial Visual Studio Code extension"],["3YGYMEXVHOHRQVPC53MVPSLI2ZJM77MBPWNPDDCL56DNCPUC6XTAC","Create `event_loop` module"],["NB2MF3MYAJ25KNZP3GMHX42LUSBYOX6FTNLIBK3CQ7CMANFZFEGQC","Add `OpenWorkspaceFolder` event"],["OUADGWKR6A7G3UHCLSC7AWLJIMS45Y56NPVTQ7FENJPYNTAMXXMAC","Create fully-initialized `SourceControl` object in `event_loop`"],["2ZAM5V35CAQD5MOFPZEGU4ERQ2FM5CL5MB2DOJDW2ZQ74IQFBISQC","Move event handling into modules"],["TWEUQ64DU5ZXAEG67GQSS7GDEZ2O2JR5352WRVIIUK5J7ZOMO5QAC","Move threadsafe function builder logic into function-specific modules"],["QY4Z5ZXZ7G6DZFCTRPX7D6TIDZ5DHSDTLOWFDANIPUHOEKQRAIXAC","Refactor `event_loop/threadsafe_function` file into `event_loop::js_function` module"],["IBVCQSSGPKLQTD4T4TAJZRC4LY3G6FP4QWFEBHN5KEFI44ZGGAXQC","Use `External` to wrap `initialize_source_control` arguments"],["IDY5SNLOFZ663OCJ2L5NZMFNJXZSGL5O22QQXR5BIV3SJ2VUQIMQC","Update source control resource states in event loop"],["3RNQI5RXZMXF5N2WKYS3O3G2GTD4TTWDNQ3EBVGUVVKNNOTKQTJAC","Refactor `provide_file_decoration` to return a `Promise` resolved by `event_loop`"]],"deps":["WFWTKCJNC4VSURSQWE5FXJGTEJJOCDMQ6LN2O6EW2DNOVT2ZUMRQC","3YGYMEXVHOHRQVPC53MVPSLI2ZJM77MBPWNPDDCL56DNCPUC6XTAC","NB2MF3MYAJ25KNZP3GMHX42LUSBYOX6FTNLIBK3CQ7CMANFZFEGQC","OUADGWKR6A7G3UHCLSC7AWLJIMS45Y56NPVTQ7FENJPYNTAMXXMAC","2ZAM5V35CAQD5MOFPZEGU4ERQ2FM5CL5MB2DOJDW2ZQ74IQFBISQC","TWEUQ64DU5ZXAEG67GQSS7GDEZ2O2JR5352WRVIIUK5J7ZOMO5QAC","QY4Z5ZXZ7G6DZFCTRPX7D6TIDZ5DHSDTLOWFDANIPUHOEKQRAIXAC","IBVCQSSGPKLQTD4T4TAJZRC4LY3G6FP4QWFEBHN5KEFI44ZGGAXQC","IDY5SNLOFZ663OCJ2L5NZMFNJXZSGL5O22QQXR5BIV3SJ2VUQIMQC","3RNQI5RXZMXF5N2WKYS3O3G2GTD4TTWDNQ3EBVGUVVKNNOTKQTJAC"],"known":[]},"hunks":[{"Edit":{"inode":{"change":2,"pos":108513},"path":"editors/vscode/src/lib.rs","line":238,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":117772}],"down_context":[{"change":2,"pos":117772}],"flag":"BLOCK","start":0,"end":382,"inode":{"change":2,"pos":108513}}},"contents":[{"Add":""},{"Add":" for text_editor in &visible_text_editors {"},{"Add":" let uri = UriAbsoluteString::try_from(text_editor.get_document()?.get_uri()?.to_string()?)"},{"Add":" .map_err(|error| napi::Error::from_reason(format!(\"Failed to parse URI: {error}\")))?;"},{"Add":""},{"Add":" event_loop::send(Event::OpenTextEditor {"},{"Add":" uri,"},{"Add":" text_editor: text_editor.create_ref()?,"},{"Add":" });"},{"Add":" }"}]}},{"Replacement":{"inode":{"change":3,"pos":171},"path":"editors/vscode/src/event_loop/mod.rs","line":6,"ins":{"up_context":[{"change":11,"pos":538}],"down_context":[{"change":3,"pos":198}],"flag":"BLOCK","start":383,"end":443,"inode":{"change":3,"pos":171}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":538},"to":{"change":11,"start":538,"end":577},"introduced_by":11}],"inode":{"change":3,"pos":171}},"ins_contents":[{"Add":"use iri_string::types::{UriAbsoluteStr, UriAbsoluteString};"}],"del_contents":[{"Del":"use iri_string::types::UriAbsoluteStr;\n"}]}},{"Replacement":{"inode":{"change":3,"pos":171},"path":"editors/vscode/src/event_loop/mod.rs","line":24,"ins":{"up_context":[{"change":5,"pos":2708}],"down_context":[{"change":10,"pos":18}],"flag":"BLOCK","start":444,"end":526,"inode":{"change":3,"pos":171}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":2708},"to":{"change":5,"start":2708,"end":2786},"introduced_by":5}],"inode":{"change":3,"pos":171}},"ins_contents":[{"Add":" open_editors: HashMap>,"}],"del_contents":[{"Del":" open_editors: HashMap,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":171},"path":"editors/vscode/src/event_loop/mod.rs","line":35,"ins":{"up_context":[{"change":11,"pos":721}],"down_context":[{"change":11,"pos":771}],"flag":"BLOCK","start":527,"end":577,"inode":{"change":3,"pos":171}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":721},"to":{"change":11,"start":721,"end":771},"introduced_by":11}],"inode":{"change":3,"pos":171}},"ins_contents":[{"Add":" fn find_repository_root<'uri>("},{"Add":" &self,"}],"del_contents":[{"Del":" fn find_repository<'uri>(\n &'uri self,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":171},"path":"editors/vscode/src/event_loop/mod.rs","line":38,"ins":{"up_context":[{"change":11,"pos":806}],"down_context":[{"change":11,"pos":860}],"flag":"BLOCK","start":578,"end":630,"inode":{"change":3,"pos":171}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":806},"to":{"change":11,"start":806,"end":860},"introduced_by":11}],"inode":{"change":3,"pos":171}},"ins_contents":[{"Add":" ) -> Option<(&'uri Utf8Path, &'uri Utf8Path)> {"}],"del_contents":[{"Del":" ) -> Option<(&'uri Utf8Path, &'uri Repository)> {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":171},"path":"editors/vscode/src/event_loop/mod.rs","line":43,"ins":{"up_context":[{"change":11,"pos":936}],"down_context":[{"change":11,"pos":1129}],"flag":"BLOCK","start":631,"end":873,"inode":{"change":3,"pos":171}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":936},"to":{"change":11,"start":936,"end":1129},"introduced_by":11}],"inode":{"change":3,"pos":171}},"ins_contents":[{"Add":" let uri_path = Utf8Path::new(uri.path_str());"},{"Add":" for ancestor in uri_path.ancestors() {"},{"Add":" if self.repositories.contains_key(ancestor) {"},{"Add":" return Some((ancestor, uri_path.strip_prefix(ancestor).unwrap()));"}],"del_contents":[{"Del":" for ancestor in Utf8Path::new(uri.path_str()).ancestors() {\n if let Some(repository) = self.repositories.get(ancestor) {\n return Some((ancestor, repository));\n"}]}},{"Edit":{"inode":{"change":3,"pos":171},"path":"editors/vscode/src/event_loop/mod.rs","line":51,"atom":{"NewVertex":{"up_context":[{"change":11,"pos":1167}],"down_context":[{"change":11,"pos":1167}],"flag":"BLOCK","start":874,"end":1840,"inode":{"change":3,"pos":171}}},"contents":[{"Add":" }"},{"Add":""},{"Add":" #[tracing::instrument(skip(self))]"},{"Add":" fn get_repository<'uri>("},{"Add":" &self,"},{"Add":" uri: &'uri UriAbsoluteStr,"},{"Add":" ) -> Option<(&'uri Utf8Path, &'uri Utf8Path, &Repository)> {"},{"Add":" self.find_repository_root(uri)"},{"Add":" .map(|(repository_path, relative_path)| {"},{"Add":" ("},{"Add":" repository_path,"},{"Add":" relative_path,"},{"Add":" self.repositories.get(repository_path).unwrap(),"},{"Add":" )"},{"Add":" })"},{"Add":" }"},{"Add":""},{"Add":" #[tracing::instrument(skip(self))]"},{"Add":" fn get_repository_mut<'uri>("},{"Add":" &mut self,"},{"Add":" uri: &'uri UriAbsoluteStr,"},{"Add":" ) -> Option<(&'uri Utf8Path, &'uri Utf8Path, &mut Repository)> {"},{"Add":" self.find_repository_root(uri)"},{"Add":" .map(|(repository_path, relative_path)| {"},{"Add":" ("},{"Add":" repository_path,"},{"Add":" relative_path,"},{"Add":" self.repositories.get_mut(repository_path).unwrap(),"},{"Add":" )"},{"Add":" })"}]}},{"Edit":{"inode":{"change":3,"pos":171},"path":"editors/vscode/src/event_loop/mod.rs","line":115,"atom":{"NewVertex":{"up_context":[{"change":10,"pos":589}],"down_context":[{"change":10,"pos":589}],"flag":"BLOCK","start":1841,"end":2176,"inode":{"change":3,"pos":171}}},"contents":[{"Add":" )"},{"Add":" .await"},{"Add":" }"},{"Add":" Event::OpenTextEditor { uri, text_editor } => {"},{"Add":" event::open_text_editor::handle("},{"Add":" uri,"},{"Add":" text_editor,"},{"Add":" &mut extension_state,"},{"Add":" &js_functions,"}]}},{"Edit":{"inode":{"change":4,"pos":772},"path":"editors/vscode/src/event_loop/js_function/mod.rs","line":9,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":833}],"down_context":[{"change":9,"pos":56}],"flag":"BLOCK","start":2177,"end":2211,"inode":{"change":4,"pos":772}}},"contents":[{"Add":"pub mod get_text_editor_contents;"}]}},{"Edit":{"inode":{"change":4,"pos":772},"path":"editors/vscode/src/event_loop/js_function/mod.rs","line":14,"atom":{"NewVertex":{"up_context":[{"change":8,"pos":510}],"down_context":[{"change":5,"pos":46}],"flag":"BLOCK","start":2212,"end":2279,"inode":{"change":4,"pos":772}}},"contents":[{"Add":" get_text_editor_contents: get_text_editor_contents::Prototype,"}]}},{"Edit":{"inode":{"change":4,"pos":772},"path":"editors/vscode/src/event_loop/js_function/mod.rs","line":23,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":1076}],"down_context":[{"change":7,"pos":0}],"flag":"BLOCK","start":2280,"end":2357,"inode":{"change":4,"pos":772}}},"contents":[{"Add":" get_text_editor_contents: get_text_editor_contents::build(env)?,"}]}},{"Edit":{"inode":{"change":4,"pos":772},"path":"editors/vscode/src/event_loop/js_function/mod.rs","line":28,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":1210}],"down_context":[{"change":4,"pos":1210}],"flag":"BLOCK","start":2358,"end":2786,"inode":{"change":4,"pos":772}}},"contents":[{"Add":" }"},{"Add":""},{"Add":" pub async fn get_text_editor_contents("},{"Add":" &self,"},{"Add":" text_editor_reference: &Rc,"},{"Add":" ) -> Result {"},{"Add":" let arguments = get_text_editor_contents::Arguments {"},{"Add":" text_editor_reference: Rc::clone(text_editor_reference),"},{"Add":" };"},{"Add":""},{"Add":" self.get_text_editor_contents"},{"Add":" .call_async(External::new(arguments))"},{"Add":" .await"}]}},{"FileAdd":{"meta":{"basename":"get_text_editor_contents.rs","metadata":0},"context":[{"change":8,"pos":435}],"contents":[{"Add":"use std::rc::Rc;"},{"Add":""},{"Add":"use napi::bindgen_prelude::{External, FunctionCallContext};"},{"Add":"use napi::threadsafe_function::ThreadsafeFunction;"},{"Add":""},{"Add":"use crate::vscode_sys;"},{"Add":""},{"Add":"pub struct Arguments {"},{"Add":" pub text_editor_reference: Rc,"},{"Add":"}"},{"Add":""},{"Add":"pub type Prototype = ThreadsafeFunction<"},{"Add":" External,"},{"Add":" String,"},{"Add":" External,"},{"Add":" napi::Status,"},{"Add":" false,"},{"Add":" false,"},{"Add":" 0,"},{"Add":">;"},{"Add":""},{"Add":"pub fn build(env: &napi::Env) -> Result {"},{"Add":" env.create_function_from_closure(\"get_text_editor_contents\", callback)?"},{"Add":" .build_threadsafe_function()"},{"Add":" .build()"},{"Add":"}"},{"Add":""},{"Add":"fn callback(function_call_context: FunctionCallContext) -> Result {"},{"Add":" let (external,): (&External,) = function_call_context.args()?;"},{"Add":" let Arguments {"},{"Add":" text_editor_reference,"},{"Add":" } = &**external;"},{"Add":""},{"Add":" let text_editor = text_editor_reference.get_inner(function_call_context.env)?;"},{"Add":" let document = text_editor.get_document()?;"},{"Add":""},{"Add":" document.get_text(None)"},{"Add":"}"}]}},{"Edit":{"inode":{"change":11,"pos":1917},"path":"editors/vscode/src/event_loop/event/request_file_decoration.rs","line":1,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":1917},"to":{"change":11,"start":1918,"end":1940},"introduced_by":11}],"inode":{"change":11,"pos":1917}}},"contents":[{"Del":"use camino::Utf8Path;\n"}]}},{"Replacement":{"inode":{"change":11,"pos":1917},"path":"editors/vscode/src/event_loop/event/request_file_decoration.rs","line":58,"ins":{"up_context":[{"change":11,"pos":4024}],"down_context":[{"change":11,"pos":4114}],"flag":"BLOCK","start":3849,"end":3958,"inode":{"change":11,"pos":1917}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":4024},"to":{"change":11,"start":4024,"end":4114},"introduced_by":11}],"inode":{"change":11,"pos":1917}},"ins_contents":[{"Add":" let Some((_repository_path, relative_path, repository)) = extension_state.get_repository(uri)"},{"Add":" else {"}],"del_contents":[{"Del":" let Some((repository_path, repository)) = extension_state.find_repository(uri) else {\n"}]}},{"Replacement":{"inode":{"change":11,"pos":1917},"path":"editors/vscode/src/event_loop/event/request_file_decoration.rs","line":64,"ins":{"up_context":[{"change":11,"pos":4218}],"down_context":[{"change":11,"pos":4681}],"flag":"BLOCK","start":3959,"end":4015,"inode":{"change":11,"pos":1917}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":4218},"to":{"change":11,"start":4218,"end":4681},"introduced_by":11}],"inode":{"change":11,"pos":1917}},"ins_contents":[{"Add":" repository.repository.get_path_state(relative_path)"}],"del_contents":[{"Del":" let decoration_path = match Utf8Path::new(uri.path_str()).strip_prefix(repository_path) {\n Ok(decoration_path) => decoration_path,\n Err(error) => {\n tracing::error!(\n message = \"Failed to strip repository prefix from path\",\n ?repository_path,\n ?uri,\n ?error\n );\n return None;\n }\n };\n\n repository.repository.get_path_state(decoration_path)\n"}]}},{"FileAdd":{"meta":{"basename":"open_text_editor.rs","metadata":0},"context":[{"change":6,"pos":332}],"contents":[{"Add":"use std::rc::Rc;"},{"Add":""},{"Add":"use iri_string::types::UriAbsoluteString;"},{"Add":""},{"Add":"use crate::event_loop::ExtensionState;"},{"Add":"use crate::event_loop::js_function::Functions;"},{"Add":"use crate::vscode_sys;"},{"Add":""},{"Add":"#[tracing::instrument(skip(text_editor_reference, extension_state, js_functions))]"},{"Add":"pub async fn handle("},{"Add":" uri: UriAbsoluteString,"},{"Add":" text_editor_reference: vscode_sys::reference::TextEditorRef,"},{"Add":" extension_state: &mut ExtensionState,"},{"Add":" js_functions: &Functions,"},{"Add":") {"},{"Add":" let Some((repository_path, relative_path, repository)) ="},{"Add":" extension_state.get_repository_mut(&uri)"},{"Add":" else {"},{"Add":" // TODO: keep track of unassigned text editors in case they later become part of a repository"},{"Add":" tracing::info!(message = \"Ignoring text editor\");"},{"Add":" return;"},{"Add":" };"},{"Add":""},{"Add":" if repository.open_editors.contains_key(relative_path) {"},{"Add":" tracing::debug!("},{"Add":" message = \"Ignoring existing text editor\","},{"Add":" ?repository_path,"},{"Add":" ?relative_path"},{"Add":" );"},{"Add":" } else {"},{"Add":" let text_editor = Rc::new(text_editor_reference);"},{"Add":""},{"Add":" let editor_contents = match js_functions.get_text_editor_contents(&text_editor).await {"},{"Add":" Ok(contents) => contents,"},{"Add":" Err(error) => {"},{"Add":" tracing::error!(message = \"Failed to get text editor contents\", ?error);"},{"Add":" return;"},{"Add":" }"},{"Add":" };"},{"Add":""},{"Add":" if let Err(error) = repository"},{"Add":" .repository"},{"Add":" .create_open_file(relative_path.to_path_buf(), editor_contents)"},{"Add":" {"},{"Add":" tracing::error!(message = \"Failed to create open file\", ?error);"},{"Add":" };"},{"Add":""},{"Add":" repository"},{"Add":" .open_editors"},{"Add":" .insert(relative_path.to_path_buf(), text_editor);"},{"Add":""},{"Add":" tracing::info!("},{"Add":" message = \"Opened new text editor\","},{"Add":" ?repository_path,"},{"Add":" ?relative_path"},{"Add":" );"},{"Add":" }"},{"Add":"}"}]}},{"Edit":{"inode":{"change":6,"pos":3067},"path":"editors/vscode/src/event_loop/event/mod.rs","line":3,"atom":{"NewVertex":{"up_context":[{"change":11,"pos":4972}],"down_context":[{"change":10,"pos":5705}],"flag":"BLOCK","start":5888,"end":5912,"inode":{"change":6,"pos":3067}}},"contents":[{"Add":""},{"Add":"use crate::vscode_sys;"}]}},{"Edit":{"inode":{"change":6,"pos":3067},"path":"editors/vscode/src/event_loop/event/mod.rs","line":6,"atom":{"NewVertex":{"up_context":[{"change":10,"pos":5706}],"down_context":[{"change":6,"pos":3068}],"flag":"BLOCK","start":5913,"end":5939,"inode":{"change":6,"pos":3067}}},"contents":[{"Add":"pub mod open_text_editor;"}]}},{"Edit":{"inode":{"change":6,"pos":3067},"path":"editors/vscode/src/event_loop/event/mod.rs","line":15,"atom":{"NewVertex":{"up_context":[{"change":11,"pos":5061}],"down_context":[{"change":11,"pos":5061}],"flag":"BLOCK","start":5940,"end":6059,"inode":{"change":6,"pos":3067}}},"contents":[{"Add":" OpenTextEditor {"},{"Add":" uri: UriAbsoluteString,"},{"Add":" text_editor: vscode_sys::reference::TextEditorRef,"},{"Add":" },"}]}}],"owner":"finchie","repo":"pijul_extension","token":"eUbVkIKUbVqbKb+ehgrJd2NMYbCsas/OkmsQ/LK14OY=","login":null}

…

Dependencies

Change contents