finchie/pijul_extension - Change T4NQUSRPQAIACUZLVDPXMNISBHKMD73A22H5SGQWIDQZD675VAZAC

Emit events on file decoration change

Mostly just shuffling macros around to get basic, untyped EventEmitter support for FileDecorationProvider.onDidChangeFileDecorations. Typed event emitters would be ideal but are probably best left to a full vscode_bindgen crate instead of the macro_rules! hacks currently used.

Created by finchie on December 15, 2025

T4NQUSRPQAIACUZLVDPXMNISBHKMD73A22H5SGQWIDQZD675VAZAC

Dependencies

In channels

main

Change contents

Replacement in extensions/vscode/src/vscode_sys/reference.rs at line 4 [2.57967]

B:BD[2.58033] → [2.58033:58127]

use super::{SourceControl, SourceControlResourceGroup, TextEditor, TextEditorDecorationType};

[2.58033]

[2.58127]

use super::{
    EventEmitter, SourceControl, SourceControlResourceGroup, TextEditor, TextEditorDecorationType,
};

Insertion in extensions/vscode/src/vscode_sys/reference.rs at line 8 [2.57967]
[2.58128]
[2.58128]
```
object_reference!(EventEmitterRef: EventEmitter);
```

Replacement in extensions/vscode/src/vscode_sys/mod.rs at line 15 [2.58410]

B:BD[2.58796] → [2.58796:58883]

B:BD[2.58883] → [5.301:384]

    class_wrapper, empty_function_caller, field_getter, field_setter, function_caller,
    function_setter, interface_builder, object_event_handler, static_class_method,

[2.58796]

[2.58944]

    class_wrapper, class_wrapper_empty, empty_function_caller, field_getter, field_setter,
    function_caller, function_setter, interface_builder, object_event_handler, static_class_method,

Insertion in extensions/vscode/src/vscode_sys/mod.rs at line 89 [2.58410]

[2.60957]

class_wrapper_empty!(EventEmitter);
field_getter! {
    EventEmitter {
        // TODO: this should be a typed function
        "event": get_event -> bindgen_prelude::Unknown<'env>;
    }
}
function_caller! {
    EventEmitter {
        "fire":
            fire(
                data: bindgen_prelude::Object,
            ) -> ();
    }
}

Insertion in extensions/vscode/src/vscode_sys/mod.rs at line 182 [2.58410]

[2.62886]

    }
}
field_setter! {
    FileDecorationProvider {
        "onDidChangeFileDecorations": set_on_did_change_file_decorations(bindgen_prelude::Unknown);

Insertion in extensions/vscode/src/vscode_sys/macros/mod.rs at line 11 [2.77320]

[2.77551]

[4.3266]

pub(super) use class::wrapper::class_wrapper_empty;
pub(super) use class::wrapper::class_wrapper_inner;

Insertion in extensions/vscode/src/vscode_sys/macros/class/wrapper.rs at line 3 [2.86622]
[2.86717]
[2.86717]

Replacement in extensions/vscode/src/vscode_sys/macros/class/wrapper.rs at line 5 [2.86622]

B:BD[2.86746] → [2.86746:86821]

    ($class_name:ident($($argument_name:ident: $argument_type:ty),*)) => {

[2.86746]

[2.86821]

    ($class_name:ident($($argument_name:ident: $argument_type:ty),+)) => {
        crate::vscode_sys::macros::class_wrapper_inner! {
            ::napi::bindgen_prelude::FnArgs<($($argument_type,)*)>,
            ::napi::bindgen_prelude::FnArgs::from(($($argument_name,)*)),
            $class_name($($argument_name: $argument_type),+)
        }
    };
}
macro_rules! class_wrapper_empty {
    ($class_name:ident) => {
        crate::vscode_sys::macros::class_wrapper_inner! {
            (),
            (),
            $class_name()
        }
    };
}
macro_rules! class_wrapper_inner {
    ($constructor_args_type:ty, $constructor_args_initializer:expr, $class_name:ident($($argument_name:ident: $argument_type:ty),*)) => {

Replacement in extensions/vscode/src/vscode_sys/macros/class/wrapper.rs at line 38 [2.86622]

B:BD[2.87297] → [2.87297:87373]

                    ::napi::bindgen_prelude::FnArgs<($($argument_type,)*)>,

[2.87297]

[2.87373]

                    $constructor_args_type,

Replacement in extensions/vscode/src/vscode_sys/macros/class/wrapper.rs at line 43 [2.86622]

B:BD[2.87582] → [2.87582:87701]

                    constructor_prototype.new_instance(::napi::bindgen_prelude::FnArgs::from(($($argument_name,)*)))?;

[2.87582]

[2.87701]

                    constructor_prototype.new_instance($constructor_args_initializer)?;

Replacement in extensions/vscode/src/vscode_sys/macros/class/wrapper.rs at line 104 [2.86622]

B:BD[2.90067] → [2.90067:90261]

                let constructor: bindgen_prelude::Function<bindgen_prelude::FnArgs<($($argument_type,)*)>, bindgen_prelude::Object> = vscode_object.get_named_property(stringify!($class_name))?;

[2.90067]

[2.90261]

                let constructor: bindgen_prelude::Function<$constructor_args_type, bindgen_prelude::Object> = vscode_object.get_named_property(stringify!($class_name))?;

Insertion in extensions/vscode/src/vscode_sys/macros/class/wrapper.rs at line 121 [2.86622]
[2.90642]
```
pub(crate) use class_wrapper_empty;
pub(crate) use class_wrapper_inner;
```

Insertion in extensions/vscode/src/lib.rs at line 35 [2.108513]

[2.109730]

    decoration_change_event_emitter: vscode_sys::reference::EventEmitterRef,

Insertion in extensions/vscode/src/lib.rs at line 273 [2.108513]

[5.813]

    let decoration_change_event_emitter = extension_state
        .decoration_change_event_emitter
        .get_inner(env)?;

Insertion in extensions/vscode/src/lib.rs at line 297 [2.108513]
[5.1607]
[5.1607]
```
        decoration_change_event_emitter.fire(uri.inner)?;
```

Insertion in extensions/vscode/src/lib.rs at line 334 [2.108513]

[3.947]

[2.118947]


    let decoration_change_event_emitter = vscode_sys::EventEmitter::new(env)?;
    let decoration_change_event = decoration_change_event_emitter.get_event()?;

Insertion in extensions/vscode/src/lib.rs at line 340 [2.108513]

[2.119047]

        decoration_change_event_emitter: decoration_change_event_emitter.create_ref()?,

Replacement in extensions/vscode/src/lib.rs at line 354 [2.108513]
B:BD[2.119529] → [2.119529:119564]
```
    let file_decoration_provider =
```
[2.119529]
[2.119564]
```
    let mut file_decoration_provider =
```

Insertion in extensions/vscode/src/lib.rs at line 356 [2.108513]

[2.119644]

    file_decoration_provider.set_on_did_change_file_decorations(decoration_change_event)?;