{"header":{"message":"Hotfix for use-after-free in `Color` to pattern (#156)","description":"* hotfix for use-after-free in `Color` -> pattern,\n\n* fixes for `Color` and `BitmapData`","timestamp":"2023-10-03T16:01:13Z","authors":[{"email":"888526+boozook@users.noreply.github.com","name":"Alexander Koz"}]},"hash":"MN4T66BPGYTSGP5DVRH5MR4RPVQIRJQKNV7TBRR4CDWL2NCRP3YAC","authors":[],"deps":{"hashes":[["MN4T66BPGYTSGP5DVRH5MR4RPVQIRJQKNV7TBRR4CDWL2NCRP3YAC","Hotfix for use-after-free in `Color` to pattern (#156)"],["AA",null],["N37SUM4JCJBPJ47YSITTXZNT3HDOA4I7J23UNY57LHJPPVEZSBZQC","Initial import (history reset)"],["Q6QBQYQ7RQ4QTMDHG3AIQI4ANR4PIFGKB4QZQT7TE25CHNIWNE3AC","Initial import (history reset, this is the last time!)"],["33G5WXD5ZDZBJ7XING26E2ZHRTG5VH6UPCE7MPGFTWT4IPWECL4QC","fix include miss-use in cargo manifests"],["6JRSPXY35YVEQQ5IFJZMUKFCIIYMWPFHNHRL4P6SOOSEZTRGGJFAC","sprite api, improve bitmap, add trait to sys"],["G6EWAJR3HKDY6F6H5QEHIWZ3JQFBKDZTK56PL56YV3GHRHZHJ5BQC","improve docs including [missed `getDisplayBufferBitmap`][link]"],["4FJROIHD3ZPNVJZ4JRRPZ2RWL7QM6TGSAQV3FBHDVU3LH4OF2NQAC","Add cached api end points (part 1) (#130)"],["SDWZKQ7AU2CRPWATMQDADMSW4ZCYZOTV5YILO5T4YSQCZQ7KQVUAC","Api features refactoring to prevent lang-items duplication (#139)"],["UZGMQBLF2TPEWJSSL75FUEQ473DMRXKH737OVGAZR2P5EG4W7FEQC","various api improvements:"],["YHABB5J2ZD2PRI7AFPXCDPSSK5X3ULEHQOR5BF6YAT3E52GJWREAC","improve ctrls api,"],["LOKBVSOPIZ6PM5OPKXVDAK4RM3PHYNTBHLTCIM7LEBXVKW5X6NZAC","fix UB in `Bitmap::get_color_of_pattern` (#57)"],["2SVXBYKBWMR2WGULGT2JX36BGZYVAD7P4ODBYEXQZ754D5QFGBHAC","add SDK v2.1 compatibility"],["MVTT62BRQ76MZQQLAGKDYQIO5CAMTSXMJDJSZ62V3EMRJ55RTM3QC","add text api, improve sprite api, add missed crates to cargo-playdate for `new/init` cmd."],["IRPWJFHL6T2Z5AK2RW5EFRJPFKMCCHXV74HKGPZHPFC3QIYI23BAC","Api handlers, entry-point and various improvements (#118)"],["XXGYT7QMHF5H3BXACCWDKVIIG5HZIVIK3NMVGVCQQN2KH6ETENNAC","sound: add source, various little improvements"],["NYM6JUERELBF4MFTRKOIUTWEBXJYHMJCZGPJBOHVASEWWGAWEEUAC","add missed metadata, update manifests, improve readme, bump versions"],["QUGRW4H7QRZK3WBWSC4R6LMGODSMRT2VP3JVEPVFM5BVNLVXRKTAC","Improve examples (#143)"],["RSL4UVHONEGOEXS7XNG6RBULITXVVW6SUX6YGE72LLPIATXSXWVAC","bump crates"],["SFNCB6M4GGCTCYYDKSHPH23ZEPQ3OXI3B3TACFNDRZ2334SCNS4QC","Add cached api end points (part 2) (#131)"],["ICZTDXWGYZ4FHFBTKAWPEZ56RPXOQWWFME6MOAEUGEJFFPCJUFXAC","Add main api crate (#96)"],["AHVKTWDFEJX6ZLJI5ITRHJBQIXG3IG2A7RFPRFFREDMVRNRXK5NAC","gfx: improve docs 🤏"],["UEVSH77MUES342YHST7RXMAGSXHZS2QMAZURGLGRCV6HK5V73CTQC","Improve sprite examples, fix metadata for docs.rs"]],"deps":["N37SUM4JCJBPJ47YSITTXZNT3HDOA4I7J23UNY57LHJPPVEZSBZQC","Q6QBQYQ7RQ4QTMDHG3AIQI4ANR4PIFGKB4QZQT7TE25CHNIWNE3AC","33G5WXD5ZDZBJ7XING26E2ZHRTG5VH6UPCE7MPGFTWT4IPWECL4QC","6JRSPXY35YVEQQ5IFJZMUKFCIIYMWPFHNHRL4P6SOOSEZTRGGJFAC","G6EWAJR3HKDY6F6H5QEHIWZ3JQFBKDZTK56PL56YV3GHRHZHJ5BQC","4FJROIHD3ZPNVJZ4JRRPZ2RWL7QM6TGSAQV3FBHDVU3LH4OF2NQAC","SDWZKQ7AU2CRPWATMQDADMSW4ZCYZOTV5YILO5T4YSQCZQ7KQVUAC","UZGMQBLF2TPEWJSSL75FUEQ473DMRXKH737OVGAZR2P5EG4W7FEQC"],"known":["RSL4UVHONEGOEXS7XNG6RBULITXVVW6SUX6YGE72LLPIATXSXWVAC","LOKBVSOPIZ6PM5OPKXVDAK4RM3PHYNTBHLTCIM7LEBXVKW5X6NZAC","NYM6JUERELBF4MFTRKOIUTWEBXJYHMJCZGPJBOHVASEWWGAWEEUAC","MVTT62BRQ76MZQQLAGKDYQIO5CAMTSXMJDJSZ62V3EMRJ55RTM3QC","ICZTDXWGYZ4FHFBTKAWPEZ56RPXOQWWFME6MOAEUGEJFFPCJUFXAC","IRPWJFHL6T2Z5AK2RW5EFRJPFKMCCHXV74HKGPZHPFC3QIYI23BAC","SFNCB6M4GGCTCYYDKSHPH23ZEPQ3OXI3B3TACFNDRZ2334SCNS4QC","AHVKTWDFEJX6ZLJI5ITRHJBQIXG3IG2A7RFPRFFREDMVRNRXK5NAC","XXGYT7QMHF5H3BXACCWDKVIIG5HZIVIK3NMVGVCQQN2KH6ETENNAC","2SVXBYKBWMR2WGULGT2JX36BGZYVAD7P4ODBYEXQZ754D5QFGBHAC","UEVSH77MUES342YHST7RXMAGSXHZS2QMAZURGLGRCV6HK5V73CTQC","QUGRW4H7QRZK3WBWSC4R6LMGODSMRT2VP3JVEPVFM5BVNLVXRKTAC","YHABB5J2ZD2PRI7AFPXCDPSSK5X3ULEHQOR5BF6YAT3E52GJWREAC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":6,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":58303}],"down_context":[{"change":5,"pos":91005}],"flag":"BLOCK","start":311,"end":333,"inode":{"change":3,"pos":58233}}},"contents":[{"Add":"use core::fmt::Write;"}]}},{"Edit":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":11,"atom":{"NewVertex":{"up_context":[{"change":7,"pos":55829}],"down_context":[{"change":5,"pos":91037}],"flag":"BLOCK","start":334,"end":360,"inode":{"change":3,"pos":58233}}},"contents":[{"Add":"use sys::ffi::LCDPattern;"}]}},{"Edit":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":311,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":62314},"to":{"change":3,"start":62314,"end":62412},"introduced_by":3}],"inode":{"change":3,"pos":58233}}},"contents":[{"Del":"\t\tlet len = if mask.is_some() {\n\t\t\trow_bytes * height\n\t\t} else {\n\t\t\t(row_bytes * height) * 2\n\t\t};\n"}]}},{"Edit":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":486,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":67611}],"down_context":[{"change":3,"pos":67611}],"flag":"BLOCK","start":361,"end":849,"inode":{"change":3,"pos":58233}}},"contents":[{"Add":""},{"Add":""},{"Add":"\t/// Returns pattern `8 x 8` from this bitmap."},{"Add":"\t///"},{"Add":"\t/// `x, y` indicates the top left corner of the 8 x 8 pattern in bitmap's coordinates."},{"Add":"\t///"},{"Add":"\t/// Returned pattern is owned by rust and can be dropped freely."},{"Add":"\t///"},{"Add":"\t/// Uses [`sys::ffi::playdate_graphics::setColorToPattern`]."},{"Add":"\t#[doc(alias = \"sys::ffi::playdate_graphics::setColorToPattern\")]"},{"Add":"\tpub fn pattern_at(&self, x: c_int, y: c_int) -> LCDPattern {"},{"Add":"\t\tlet mut color = LCDColor::default();"},{"Add":"\t\tlet f = self.1.set_color_to_pattern();"}]}},{"Edit":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":500,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":67612}],"down_context":[{"change":3,"pos":67612}],"flag":"BLOCK","start":850,"end":962,"inode":{"change":3,"pos":58233}}},"contents":[{"Add":"\t\tunsafe {"},{"Add":"\t\t\tf(core::ptr::addr_of_mut!(color), self.0, x, y);"},{"Add":"\t\t\t*(color as *mut u8 as *mut LCDPattern)"},{"Add":"\t\t}"},{"Add":"\t}"}]}},{"Edit":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":507,"atom":{"NewVertex":{"up_context":[{"change":6,"pos":5673}],"down_context":[{"change":3,"pos":67670}],"flag":"BLOCK","start":963,"end":968,"inode":{"change":3,"pos":58233}}},"contents":[{"Add":"\t///"}]}},{"Edit":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":510,"atom":{"NewVertex":{"up_context":[{"change":6,"pos":5679}],"down_context":[{"change":6,"pos":5679}],"flag":"BLOCK","start":969,"end":1092,"inode":{"change":3,"pos":58233}}},"contents":[{"Add":"\t/// After this operation inner pointer is owned by the system."},{"Add":"\t/// To get owned pattern use [`Bitmap::pattern_at`]."},{"Add":"\t///"}]}},{"Replacement":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":535,"ins":{"up_context":[{"change":3,"pos":68791}],"down_context":[{"change":3,"pos":68935}],"flag":"BLOCK","start":1093,"end":1256,"inode":{"change":3,"pos":58233}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":68791},"to":{"change":3,"start":68791,"end":68883},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":68883},"to":{"change":5,"start":93370,"end":93423},"introduced_by":5}],"inode":{"change":3,"pos":58233}},"ins_contents":[{"Add":"\tpub const fn width(&self) -> c_int { self.width }"},{"Add":"\tpub const fn height(&self) -> c_int { self.height }"},{"Add":"\tpub const fn row_bytes(&self) -> c_int { self.row_bytes }"}],"del_contents":[{"Del":"\tpub fn width(&self) -> c_int { self.width }\n\tpub fn height(&self) -> c_int { self.height }\n"},{"Del":"\tpub fn row_bytes(&self) -> c_int { self.row_bytes }\n"}]}},{"Replacement":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":540,"ins":{"up_context":[{"change":3,"pos":69075}],"down_context":[{"change":3,"pos":69118}],"flag":"BLOCK","start":1257,"end":1306,"inode":{"change":3,"pos":58233}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":69075},"to":{"change":3,"start":69075,"end":69118},"introduced_by":3}],"inode":{"change":3,"pos":58233}},"ins_contents":[{"Add":"\tpub const fn data(&self) -> &[u8] { self.data }"}],"del_contents":[{"Del":"\tpub fn data(&self) -> &[u8] { self.data }\n"}]}},{"Edit":{"inode":{"change":3,"pos":58233},"path":"api/gfx/src/bitmap/bitmap.rs","line":542,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":69173}],"down_context":[{"change":3,"pos":69173}],"flag":"BLOCK","start":1307,"end":2501,"inode":{"change":3,"pos":58233}}},"contents":[{"Add":"}"},{"Add":""},{"Add":"impl core::fmt::Display for BitmapData<'_> {"},{"Add":"\tfn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {"},{"Add":"\t\twrite!(f, \"BitmapData({}, {}\", self.width(), self.height())?;"},{"Add":"\t\tif self.mask.is_some() {"},{"Add":"\t\t\twrite!(f, \", masked)\")"},{"Add":"\t\t} else {"},{"Add":"\t\t\twrite!(f, \")\")"},{"Add":"\t\t}"},{"Add":"\t}"},{"Add":"}"},{"Add":""},{"Add":"impl core::fmt::Debug for BitmapData<'_> {"},{"Add":"\tfn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {"},{"Add":"\t\tlet alternate = f.alternate();"},{"Add":"\t\tif alternate {"},{"Add":"\t\t\tlet fmt_bd = |f: &mut core::fmt::Formatter<'_>, data: &[u8], row_len: c_int| {"},{"Add":"\t\t\t\tfor (i, b) in data.iter().enumerate() {"},{"Add":"\t\t\t\t\tif i % row_len as usize == 0 {"},{"Add":"\t\t\t\t\t\tf.write_char('\\n')?;"},{"Add":"\t\t\t\t\t\tf.write_char('\\t')?;"},{"Add":"\t\t\t\t\t}"},{"Add":"\t\t\t\t\tf.write_fmt(format_args!(\"{b:08b} \"))?;"},{"Add":"\t\t\t\t}"},{"Add":"\t\t\t\tOk(())"},{"Add":"\t\t\t};"},{"Add":""},{"Add":"\t\t\twrite!(f, \"BitmapData({}, {}\", self.width(), self.height())?;"},{"Add":"\t\t\tif self.mask.is_some() {"},{"Add":"\t\t\t\twrite!(f, \", masked\")?;"},{"Add":"\t\t\t}"},{"Add":"\t\t\twrite!(f, \", data:\")?;"},{"Add":"\t\t\tfmt_bd(f, self.data, self.row_bytes)?;"},{"Add":"\t\t\twrite!(f, \")\")"},{"Add":"\t\t} else {"},{"Add":"\t\t\tlet mut res = f.debug_struct(\"BitmapData\");"},{"Add":"\t\t\tres.field(\"width\", &self.width)"},{"Add":"\t\t\t .field(\"height\", &self.height)"},{"Add":"\t\t\t .field(\"row_bytes\", &self.row_bytes);"},{"Add":"\t\t\tres.field(\"data\", &self.data).field(\"mask\", &self.mask).finish()"},{"Add":"\t\t}"},{"Add":"\t}"}]}},{"Replacement":{"inode":{"change":3,"pos":79011},"path":"api/gfx/Cargo.toml","line":3,"ins":{"up_context":[{"change":3,"pos":79049}],"down_context":[{"change":3,"pos":79085}],"flag":"BLOCK","start":2510,"end":2529,"inode":{"change":3,"pos":79011}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":79049},"to":{"change":9,"start":6066,"end":6084},"introduced_by":9}],"inode":{"change":3,"pos":79011}},"ins_contents":[{"Add":"version = \"0.3.10\""}],"del_contents":[{"Del":"version = \"0.3.9\"\n"}]}},{"Replacement":{"inode":{"change":2,"pos":3663670},"path":"api/color/src/lib.rs","line":15,"ins":{"up_context":[{"change":2,"pos":3664012}],"down_context":[{"change":2,"pos":3664038}],"flag":"BLOCK","start":2563,"end":2589,"inode":{"change":2,"pos":3663670}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3664012},"to":{"change":3,"start":84720,"end":84771},"introduced_by":3}],"inode":{"change":2,"pos":3663670}},"ins_contents":[{"Add":"\tPattern(&'t LCDPattern),"}],"del_contents":[{"Del":"\tPatternRef(&'t LCDPattern),\n\tPattern(LCDPattern),\n"}]}},{"Replacement":{"inode":{"change":2,"pos":3663670},"path":"api/color/src/lib.rs","line":18,"ins":{"up_context":[{"change":2,"pos":3664041}],"down_context":[{"change":2,"pos":3664063}],"flag":"BLOCK","start":2590,"end":2607,"inode":{"change":2,"pos":3663670}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3664041},"to":{"change":2,"start":3664041,"end":3664063},"introduced_by":2}],"inode":{"change":2,"pos":3663670}},"ins_contents":[{"Add":"impl Color<'_> {"}],"del_contents":[{"Del":"impl Color<'static> {\n"}]}},{"Replacement":{"inode":{"change":2,"pos":3663670},"path":"api/color/src/lib.rs","line":25,"ins":{"up_context":[{"change":2,"pos":3664326}],"down_context":[{"change":2,"pos":3664362}],"flag":"BLOCK","start":2608,"end":2685,"inode":{"change":2,"pos":3663670}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3664326},"to":{"change":2,"start":3664326,"end":3664362},"introduced_by":2}],"inode":{"change":2,"pos":3663670}},"ins_contents":[{"Add":"impl<'t> From> for LCDColor"},{"Add":"\twhere Self: 't,"},{"Add":"\t LCDColor: 't"},{"Add":"{"}],"del_contents":[{"Del":"impl From> for LCDColor {\n"}]}},{"Replacement":{"inode":{"change":2,"pos":3663670},"path":"api/color/src/lib.rs","line":32,"ins":{"up_context":[{"change":2,"pos":3664456}],"down_context":[{"change":2,"pos":3664522}],"flag":"BLOCK","start":2686,"end":2752,"inode":{"change":2,"pos":3663670}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3664456},"to":{"change":3,"start":84772,"end":84911},"introduced_by":3}],"inode":{"change":2,"pos":3663670}},"ins_contents":[{"Add":"\t\t\tColor::Pattern(pattern) => (pattern as *const u8) as LCDColor,"}],"del_contents":[{"Del":"\t\t\tColor::Pattern(ref pattern) => (pattern as *const u8) as LCDColor,\n\t\t\tColor::PatternRef(pattern) => (pattern as *const u8) as LCDColor,\n"}]}},{"Replacement":{"inode":{"change":2,"pos":3663670},"path":"api/color/src/lib.rs","line":88,"ins":{"up_context":[{"change":2,"pos":3665777}],"down_context":[{"change":2,"pos":3665820}],"flag":"BLOCK","start":2753,"end":2815,"inode":{"change":2,"pos":3663670}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3665777},"to":{"change":2,"start":3665777,"end":3665820},"introduced_by":2}],"inode":{"change":2,"pos":3663670}},"ins_contents":[{"Add":"impl<'t> IntoLCDColor for &'t LCDPattern where LCDColor: 't {"}],"del_contents":[{"Del":"impl<'t> IntoLCDColor for &'t LCDPattern {\n"}]}},{"Replacement":{"inode":{"change":2,"pos":3668360},"path":"api/color/Cargo.toml","line":3,"ins":{"up_context":[{"change":2,"pos":3668395}],"down_context":[{"change":2,"pos":3668431}],"flag":"BLOCK","start":2818,"end":2836,"inode":{"change":2,"pos":3668360}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3668395},"to":{"change":8,"start":10282,"end":10300},"introduced_by":8}],"inode":{"change":2,"pos":3668360}},"ins_contents":[{"Add":"version = \"0.2.1\""}],"del_contents":[{"Del":"version = \"0.2.0\"\n"}]}},{"Replacement":{"inode":{"change":2,"pos":3671603},"path":"Cargo.lock","line":2538,"ins":{"up_context":[{"change":2,"pos":3730437}],"down_context":[{"change":2,"pos":3730455}],"flag":"BLOCK","start":2841,"end":2859,"inode":{"change":2,"pos":3671603}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":3730437},"to":{"change":8,"start":11439,"end":11457},"introduced_by":8}],"inode":{"change":2,"pos":3671603}},"ins_contents":[{"Add":"version = \"0.2.1\""}],"del_contents":[{"Del":"version = \"0.2.0\"\n"}]}},{"Replacement":{"inode":{"change":2,"pos":3671603},"path":"Cargo.lock","line":2570,"ins":{"up_context":[{"change":4,"pos":4237}],"down_context":[{"change":2,"pos":3730799}],"flag":"BLOCK","start":2860,"end":2879,"inode":{"change":2,"pos":3671603}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":4237},"to":{"change":9,"start":6792,"end":6810},"introduced_by":9}],"inode":{"change":2,"pos":3671603}},"ins_contents":[{"Add":"version = \"0.3.10\""}],"del_contents":[{"Del":"version = \"0.3.9\"\n"}]}}],"owner":"fzzr","repo":"playdate","token":"2JzamRai6rDGm6P00oepFYwds5spWWRrqgHCtLORI4M=","login":null}

…

Dependencies

Change contents