Tighten up 'should exit with return code'

[?]
Jun 16, 2021, 3:48 PM
2AM7IAS5PKZSYIG4ZMRDXF6OKLGTBSYRNTRDXFRPXD3SEI4BGD3QC

Dependencies

  • [2] HENEI752 evaluate-dependent-jobsets: clean up test to be more clear
  • [3] 4OLBA6TU Tests: build-products: use `is` for good errors on failures
  • [4] HWGFAF2B queue runner: test notifications
  • [5] 4Y3LBQYI Use system-features from the Nix conf in the default machine file
  • [6] LQDK2TS5 Test that each page listing evals works
  • [7] MQLCUSZL Test the fake derivations channel, asserting nested packages are properly represented.
  • [8] NI53QY2D Disable the remote dest store for the channel test
  • [9] HUCBINMQ Only add the Nix system feature to the test that requires it
  • [10] UIA3ULNU Give each test its own Nix directories
  • [11] 3AKZKWCR RunCommand: Test
  • [12] NZXX6PLD Remove the Jobs table
  • [13] 3G475GRT Split out dependent tests in to its own .t
  • [14] YIZWKGFI tests: add jobsdir and testdir to ctx hash
  • [15] Z4AMS3T7 RunCommand: emit the `finished` field as a boolean
  • [16] PY5GVGC7 Implemented quoted strings support in hydra-build-products to allow file names with spaces + testcase
  • [*] HX4QYOYA add first evaluations tests

Change contents

  • replacement in t/Controller/Build/evals.t at line 26
    [6.743][6.743:836]()
    ok(runBuild($build), "Build '".$build->job."' from jobs/basic.nix should exit with code 0");
    [6.743]
    [6.836]
    ok(runBuild($build), "Build '".$build->job."' from jobs/basic.nix should exit with return code 0");
  • replacement in t/Controller/Jobset/channel.t at line 32
    [7.1234][7.1234:1311]()
    ok(runBuild($build), "Build '".$build->job."' should exit with code 0");
    [7.1234]
    [7.1311]
    ok(runBuild($build), "Build '".$build->job."' should exit with return code 0");
  • replacement in t/build-products.t at line 24
    [3.279][3.279:342]()
    ok(runBuild($build), "Build should exit with code 0");
    [3.279]
    [3.342]
    ok(runBuild($build), "Build should exit with return code 0");
  • replacement in t/evaluate-basic.t at line 24
    [7.669][7.669:766]()
    ok(runBuild($build), "Build '".$build->job."' from jobs/basic.nix should exit with code 0");
    [7.669]
    [7.766]
    ok(runBuild($build), "Build '".$build->job."' from jobs/basic.nix should exit with return code 0");
  • replacement in t/evaluate-dependent-jobsets.t at line 24
    [2.362][2.362:421]()
    ok(runBuild($build), "Build should exit with code 0");
    [2.362]
    [7.797]
    ok(runBuild($build), "Build should exit with return code 0");
  • replacement in t/evaluate-dependent-jobsets.t at line 36
    [7.1001][2.958:1017]()
    ok(runBuild($build), "Build should exit with code 0");
    [7.1001]
    [7.1444]
    ok(runBuild($build), "Build should exit with return code 0");
  • replacement in t/plugins/runcommand.t at line 33
    [7.2105][7.2105:2160]()
    ok(runBuild($build), "Build should exit with code 0");
    [7.2105]
    [7.2160]
    ok(runBuild($build), "Build should exit with return code 0");
  • replacement in t/queue-runner/default-machine-file.t at line 27
    [5.817][5.817:929]()
    ok(runBuild($build), "Build '".$build->job."' from jobs/default-machine-file.nix should exit with code 0");
    [5.817]
    [5.929]
    ok(runBuild($build), "Build '".$build->job."' from jobs/default-machine-file.nix should exit with return code 0");
  • replacement in t/queue-runner/notifications.t at line 91
    [4.3960][4.3960:4019]()
    ok(runBuild($build), "Build should exit with code 0");
    [4.3960]
    [4.4019]
    ok(runBuild($build), "Build should exit with return code 0");
  • replacement in t/queue-runner/notifications.t at line 110
    [4.4843][4.4843:4902]()
    ok(runBuild($build), "Build should exit with code 0");
    [4.4843]
    [4.4902]
    ok(runBuild($build), "Build should exit with return code 0");