Build.pm: Don't get isChannel using buildproducts.

[?]
Apr 21, 2015, 6:09 AM
2T3XCADO3TVJM2TONBE46KC2XMOVO5IPYN6CRQG5HHFTDDPJFH5QC

Dependencies

  • [2] 3EJABTVV Show build products on aggregates with channels.
  • [3] 2GUAKGTB Fix indentation of build.tt
  • [4] UYWFRWQ6 Sort constituents by job name
  • [5] ELABMHJI * hydra: layout changes
  • [6] 3PNG7NIB Remove trailing whitespace
  • [7] BYGDNBDF Fix Changes section on build page. Now shows the changes of the first evaluation a build was part of compared to the previous one. Also separated previous builds from the changes section, as that was confusing sometimes.
  • [8] 2R7GHSA4 * hydra: added initial version of build graph
  • [9] ZI535LI6 * hydra: 'new' UI for project/jobset/job/build
  • [10] M6WGSGNM Don't show duration of unfinished builds
  • [11] 3TZYSSGX built.tt: Handle the case where the original build is not known
  • [12] ZH6B56XR Try harder to find build logs
  • [13] HN3V252L On the build page, show how many aggregate constituents failed
  • [14] MSIHMO45 Tweak build steps
  • [15] Z6MDQIGO * A quick (non-Web 2.0) interface to manually add builds to a release.
  • [16] XTKCALUA Make "Add to release" a modal dialog
  • [17] LBNVQXUB * Build the /build stuff in a separate controller.
  • [18] CAFO4ATE Always show the build duration (using the cached build if necessary)
  • [19] OEPUOUNB Using twitter bootstrap for more consistent looks for Hydra
  • [*] J5UVLXOK * Start of a basic Catalyst web interface.

Change contents

  • edit in src/lib/Hydra/Controller/Build.pm at line 111
    [3.164][2.0:119]()
    $c->stash->{isChannel} = $c->stash->{build}->buildproducts->search(
    {type => "channel"}
    )->count > 0;
  • replacement in src/root/build.tt at line 191
    [3.3656][2.120:245]()
    [% IF (!isAggregate || !isChannel) && build.finished; actualBuild = build.iscachedbuild ? cachedBuild : build %]
    [3.3656]
    [3.535]
    [% IF (!isAggregate || !build.isChannel) && build.finished; actualBuild = build.iscachedbuild ? cachedBuild : build %]
  • replacement in src/root/build.tt at line 203
    [3.59][2.246:321]()
    [% IF (!isAggregate || !isChannel) && buildLogExists(build) %]
    [3.59]
    [3.6492]
    [% IF (!isAggregate || !build.isChannel) && buildLogExists(build) %]
  • replacement in src/root/build.tt at line 218
    [3.843][2.322:386]()
    [% IF isChannel || (build.buildproducts && !isAggregate) %]
    [3.843]
    [3.1105]
    [% IF build.isChannel || (build.buildproducts && !isAggregate) %]