BuildDiff: move cmdBuilds from Controller/JobsetEval

[?]
Jan 10, 2022, 6:35 PM
4CBVJEISYVKWSY4ZQEAEUN33UDG6E42RDNHF35K4MIRWQH6PTZHAC

Dependencies

  • [2] 4TJC72AA JobsetEval: $a, $b to $left, $right (perlcritic)
  • [3] NYIIFA32 BuildDiff: split out from JobsetEval GET impl
  • [4] 3PNG7NIB Remove trailing whitespace
  • [5] DE2DNCOI Allow comparing an evaluation with an arbitrary other evaluation
  • [6] 2S7UHICM Allow filtering jobs in eval pages
  • [7] L7NUCXKS Show new and removed jobs
  • [8] U4TD3AIQ Add support for viewing jobset evaluations
  • [9] X46KWQFN Fix incorrect removed jobs in eval pages

Change contents

  • edit in src/lib/Hydra/Controller/JobsetEval.pm at line 67
    [4.2209][4.0:20](),[4.20][2.0:179](),[2.179][4.178:184](),[4.178][4.178:184](),[4.184][4.2346:2347](),[4.1474][4.2346:2347](),[4.2346][4.2346:2347]()
    sub cmpBuilds {
    my ($left, $right) = @_;
    return $left->get_column('job') cmp $right->get_column('job')
    || $left->get_column('system') cmp $right->get_column('system')
    }
  • edit in src/lib/Hydra/Controller/JobsetEval.pm at line 69
    [4.366][4.369:473](),[4.369][4.369:473]()
    @builds = sort { cmpBuilds($a, $b) } @builds;
    @builds2 = sort { cmpBuilds($a, $b) } @builds2;
  • edit in src/lib/Hydra/Helper/BuildDiff.pm at line 18
    [3.356]
    [3.356]
    sub cmpBuilds {
    my ($left, $right) = @_;
    return $left->get_column('job') cmp $right->get_column('job')
    || $left->get_column('system') cmp $right->get_column('system')
    }
    # $builds = sort { cmpBuilds($a, $b) } $builds;
    # $builds2 = sort { cmpBuilds($a, $b) } $builds2;