HIpChatNotification: $build -> $topbuild, $b -> $build (perlcritic)

[?]

Aug 21, 2021, 1:38 AM

6IQ5AEQNRPMVB2FRDLDCSN6JU3HUPLV4MBTDIR5MJT7TWHKWG6JQC

Dependencies

[2] YILQ4PZP Allow notify option to be set for hipchat notification. (https://www.hipchat.com/docs/api/method/rooms/message)
[3] VVSVQJPI Allow HipChat notification on all builds, in stead of status changes only.
[4] 6HWIUOSU Avoid fetching Projects/Jobsets just to get the name column
[5] NC2HLVBT Remove image dependency on hydra.nixos.org
[6] BEFHUCGN Factor a getResponsibleAuthors helper out of the HipChatNotification
[7] H6D6OVYK Get rid of a warning in the HipChat plugin
[8] 5WNGKHLZ Plugins: Add isEnabled method
[9] 55CRMHEA Remove unused assignment
[10] NB2VOKIR Include names of committers in HipChat notifications
[11] ZDEHAFHV Add a plugin for HipChat notification

Change contents

replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 14

[6.208]→[6.208:250](∅→∅)

my ($self, $build, $dependents) = @_;

[6.208]

[6.250]

my ($self, $topbuild, $dependents) = @_;
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 24

[6.554]→[6.554:683](∅→∅)

foreach my $b ($build, @{$dependents}) {
my $prevBuild = getPreviousBuild($b);
my $jobName = showJobName $b;

[6.554]

[6.683]

foreach my $build ($topbuild, @{$dependents}) {
my $prevBuild = getPreviousBuild($build);
my $jobName = showJobName $build;
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 33

[6.844]→[3.41:121](∅→∅)

next if ! $force && ($b->buildstatus == 4 || $b->buildstatus == 3);

[6.844]

[6.910]

next if ! $force && ($build->buildstatus == 4 || $build->buildstatus == 3);
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 37

[6.1045]→[3.122:222](∅→∅)

next if ! $force && defined $prevBuild && ($b->buildstatus == $prevBuild->buildstatus);

[6.1045]

[6.1133]

next if ! $force && defined $prevBuild && ($build->buildstatus == $prevBuild->buildstatus);
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 40

[6.1205]→[6.1205:1262](∅→∅)

push @{$rooms{$room->{room}}->{builds}}, $b;

[6.1205]

[6.1262]

push @{$rooms{$room->{room}}->{builds}}, $build;
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 46

[6.2729]→[6.1200:1281](∅→∅)

my ($authors, $nrCommits) = getResponsibleAuthors($build, $self->{plugins});

[6.1987]

[6.2972]

my ($authors, $nrCommits) = getResponsibleAuthors($topbuild, $self->{plugins});
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 51

[6.1389]→[6.1389:1458](∅→∅)

my @deps = grep { $_->id != $build->id } @{$room->{builds}};

[6.1389]

[6.1458]

my @deps = grep { $_->id != $topbuild->id } @{$room->{builds}};
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 54

[6.1525]→[5.0:250](∅→∅)

$build->buildstatus == 0 ? "$baseurl/static/images/checkmark_16.png" :
$build->buildstatus == 2 ? "$baseurl/static/images/dependency_16.png" :
$build->buildstatus == 4 ? "$baseurl/static/images/cancelled_16.png" :

[6.1525]

[5.250]

$topbuild->buildstatus == 0 ? "$baseurl/static/images/checkmark_16.png" :
$topbuild->buildstatus == 2 ? "$baseurl/static/images/dependency_16.png" :
$topbuild->buildstatus == 4 ? "$baseurl/static/images/cancelled_16.png" :
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 61

[6.1887]→[4.1086:1257](∅→∅)

$msg .= "Job <a href='$baseurl/job/${\$build->get_column('project')}/${\$build->get_column('jobset')}/${\$build->get_column('job')}'>${\showJobName($build)}</a>";

[6.1887]

[6.2034]

$msg .= "Job <a href='$baseurl/job/${\$topbuild->get_column('project')}/${\$topbuild->get_column('jobset')}/${\$topbuild->get_column('job')}'>${\showJobName($topbuild)}</a>";
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 63

[6.2104]→[6.2104:2196](∅→∅)

$msg .= ": <a href='$baseurl/build/${\$build->id}'>" . showStatus($build) . "</a>";

[6.2104]

[6.2196]

$msg .= ": <a href='$baseurl/build/${\$topbuild->id}'>" . showStatus($topbuild) . "</a>";
replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 82

[2.52]→[6.2592:2660](∅→∅),[6.2592]→[6.2592:2660](∅→∅)

color => $build->buildstatus == 0 ? 'green' : 'red' });

[2.52]

[6.2660]

color => $topbuild->buildstatus == 0 ? 'green' : 'red' });