perlcritic: explicitly assign the result of readdir/file reads

Dependencies

• [2] 4VVBCVPD SoTest: read credentials from file
• [3] L6PVAEWJ perlcritic: don't open files as bare words
• [4] HTL6HIBM machine-status: Read /etc/nix.machines instead of using the BuildMachines table
• [5] UGA45FNC Add a plugin for backing up builds in s3
• [6] FW4PJE5K Add SoTest plugin
• [7] O3NM62IZ Support multiple machines files
• [8] THUMRES3 hydra: add Coverity Scan plugin
• [*] 2GK5DOU7 * Downloading closures.

Change contents

• replacement in src/lib/Hydra/Helper/Nix.pm at line 346
  [3.145]→[3.145:171](∅→∅)
  − while (<$conf>) {
  [3.145]

  [4.669]
  + while (my $line = <$conf>) {
• replacement in src/lib/Hydra/Helper/Nix.pm at line 350
  [4.741]→[4.741:782](∅→∅)
  − my @tokens = split /\s/, $_;
  [4.741]

  [4.782]
  + my @tokens = split /\s/, $line;
• replacement in src/lib/Hydra/Plugin/CoverityScan.pm at line 56
  [3.245]→[3.245:283](∅→∅),[3.283]→[4.1588:1701](∅→∅),[4.1588]→[4.1588:1701](∅→∅)
  − while (readdir $tarballshandle) {

  − next unless $_ =~ /.*-coverity-int\.(tgz|lzma|xz|bz2|zip)$/;

  − $covTarball = "$tarballs/$_"; last;
  [3.245]

  [4.1701]
  + while (my $file = readdir $tarballshandle) {

  + next unless $file =~ /.*-coverity-int\.(tgz|lzma|xz|bz2|zip)$/;

  + $covTarball = "$tarballs/$file"; last;
• replacement in src/lib/Hydra/Plugin/SoTest.pm at line 105
  [2.504]→[2.504:566](∅→∅)
  − while (<$authfile>) {

  − if ( $_ =~ /(.+):(.+)/m ) {
  [2.504]

  [2.566]
  + while (my $line = <$authfile>) {

  + if ( $line =~ /(.+):(.+)/m ) {
• replacement in t/s3-backup-test.pl at line 43
  [3.511]→[3.511:533](∅→∅),[3.533]→[4.11494:11560](∅→∅),[4.11494]→[4.11494:11560](∅→∅)
  − while(readdir $dir) {

  − next if $_ eq "." or $_ eq "..";

  − unlink "$gcRootsDir/$_";
  [3.511]

  [4.11560]
  + while(my $file = readdir $dir) {

  + next if $file eq "." or $file eq "..";

  + unlink "$gcRootsDir/$file";