Really fix hydra-eval-jobs

[?]
Sep 24, 2014, 1:55 PM
7BRTFGVYL3EF5LQWMLTKOCHLRA4PLPZDATZWWGHOSW3FN6PMFQWQC

Dependencies

  • [2] 7GKAIP3V Fix build and handling of string inputs starting with a dash
  • [3] KD5237CU * eval-jobs now efficiently evaluates all Hydra jobs from a
  • [4] AEFNBIIW * Merge the GC branch.
  • [5] 4LWGZL33
  • [6] 4N5APGRG * Start of a helper tool to evaluate job expressions efficiently.
  • [7] AEKIREIH * Updated hydra_eval_jobs for the new evaluator.

Change contents

  • replacement in src/c/hydra-eval-jobs.cc at line 37
    [3.393][3.393:426]()
    const Bindings & actualArgs)
    [3.393]
    [3.306]
    Bindings & actualArgs) // FIXME: should be const
  • replacement in src/c/hydra-eval-jobs.cc at line 42
    [3.613][3.613:647]()
    *arg->attrs = actualArgs;
    [3.613]
    [3.647]
    arg->attrs = &actualArgs;
  • replacement in src/c/hydra-eval-jobs.cc at line 62
    [3.733][3.880:941](),[3.880][3.880:941]()
    Bindings actualArgs2(actualArgs); // !!! inefficient
    [3.733]
    [3.941]
    Bindings & actualArgs2(*state.allocBindings(actualArgs.size() + 1)); // !!! inefficient
    for (auto & i: actualArgs)
    actualArgs2.push_back(i);
  • edit in src/c/hydra-eval-jobs.cc at line 285
    [2.1844][2.1844:1896]()
    //evalAutoArgs(state, autoArgs_, autoArgs);