perlcritic: use strict, use warnings

[?]
Aug 19, 2021, 8:36 PM
7I2U2MHUBHR456Z2BSYIDPUCUGZP6FS5JENSQGMRILGG65IX3RCAC

Dependencies

  • [2] 5US6TQ2N Update binary cache signing to Nix 1.9
  • [3] RCTBHBVC Add CircleCI plugin.
  • [4] D5YPJDT6 Add GithubPulls input plugin.
  • [5] OI2FTIMY Add BitBucket plugin
  • [6] 6ZXL5UOP Add a plugin to execute arbitrary commands when a build finishes
  • [7] 27UAQK2W Add BitBucket pull request support
  • [8] UDL2YPNH Add GitlabPulls input plugin
  • [9] E6QWSAFL Add hydra-dev-server which uses the classic Catalyst server
  • [10] 5M6YEYUJ hydra-backfill-ids: create to add jobset_id values to Builds and Jobs
  • [11] FW4PJE5K Add SoTest plugin
  • [12] KIRRGSUC Add GithubRefs plugin
  • [13] JFG4FYTW Implement simple status notifications for Git repos hosted on gitea
  • [14] SNXMD4NO hydra-create-user: re-hash sha1 as Argon2
  • [15] QSA3MZ3Q hydra-init: upgrade passwords to Argon2 on startup
  • [16] LN3E2P4E t: Test Projects JSON serialization and deserialization
  • [17] ZDH6UX5U Jobset: add HTTP API test
  • [18] GLJD3PG2 api-test.t: make it work under yath
  • [19] QOV7KWRH Expose Prometheus metrics at /metrics
  • [20] LQDK2TS5 Test that each page listing evals works
  • [21] LIKQZ4LG Jobset: test `type`-related constraints
  • [22] 7YTZDNBO Apply requested changes to Config.pm
  • [23] HXEZUCTD Add test to verify includes work
  • [24] 4H6FVIWG hydra-notify: make the prometheus endpoint configurable, default-off
  • [25] IDT3SO3P Generate *.narinfo files on the fly to support the binary cache substituter
  • [*] J5UVLXOK * Start of a basic Catalyst web interface.
  • [*] 5DZAUSUV Factor out common options
  • [*] EKHD4I44 Event: init structure and parse existing messages
  • [*] OOQ2D3KC * Refactoring: move fetchInput out of hydra_scheduler into a separate
  • [*] AKRVETP5 Handle UTF-8 characters in eval error messages
  • [*] LBNVQXUB * Build the /build stuff in a separate controller.
  • [*] RX5IIZMT Use Email::MIME instead of Email::Simple
  • [*] I6QMKSIS Move getBaseUrl
  • [*] S2KNQCPB NixExprs: extract the `escape` function and test it
  • [*] 2GK5DOU7 * Downloading closures.
  • [*] AFTXA575 * $HYDRA_DATA environment variable.
  • [*] JAH3UPWA Support revision control systems via plugins
  • [*] UVQJBDHN Move log compression to a plugin
  • [*] THUMRES3 hydra: add Coverity Scan plugin
  • [*] Q5HZWFCY Add support for darcs repositories.
  • [*] TNS4QKM4 Declarative jobsets: move event handling to a plugin
  • [*] 5EQYVRWE Add a plugin mechanism
  • [*] BLVQGJ4L Use OO-style plugins
  • [*] NSRWW6LC Add a plugin to interact with the github status API.
  • [*] YXU6JABK Create a gitlab status plugin
  • [*] ZDEHAFHV Add a plugin for HipChat notification
  • [*] ANJBFPBE Added the InfluxDBNotification plugin including a NixOS test
  • [*] UGA45FNC Add a plugin for backing up builds in s3
  • [*] KUORZDSR Add slack plugin.
  • [*] HSVVEKTY * Start of a JSON API to get information about a specific build.
  • [*] LVJKRTIK * Generate a Nix expression for the channel.
  • [*] KI423DCQ Stream logs if possible and remove size limit
  • [*] IWVA2P2Y * Generate manifests on demand. Next step: generate NAR archives on
  • [*] NYC3LZKH * Generate NAR archives on the fly. Necessary for producing channels
  • [*] XHOZT4WT Add a command `hydra-create-user' for managing user accounts
  • [*] N22GPKYT * Put info about logs / build products in the DB.
  • [*] AMFMXR52 Provide a command ‘hydra-init’ to initialise/upgrade the database
  • [*] IE2PRAQU hydra-queue-runner: Send build notifications
  • [*] DODOGD7M Send queue runner stats to statsd
  • [*] T7WD3RLR
  • [*] WZ3AEJ67 * hydra_update_gc_roots.pl registers build outputs that should be kept
  • [*] 4S5JF5JP Use latest DBIx::Class::Schema::Loader
  • [*] IGR322YP sql: Generate models from postgresql
  • [*] 5DXGOH6Q statsd: add a chance to set hostname and port in hydra.conf
  • [*] MQLCUSZL Test the fake derivations channel, asserting nested packages are properly represented.
  • [*] T3OHZDYP hydra-notify: move BuildFinished processing to an Event
  • [*] OPSWSU4L hydra-notify: move BuildStarted processing to an Event
  • [*] LQEYBAEL hydra-notify: move StepFinished processing to an Event
  • [*] P4SME2BC Abstract over postgres' LISTEN/NOTIFY
  • [*] ASPD4MDN Passwords: check in constant time
  • [*] LZVO64YG Merge in the first bits of the API work
  • [*] HX4QYOYA add first evaluations tests
  • [*] UIA3ULNU Give each test its own Nix directories
  • [*] 3G475GRT Split out dependent tests in to its own .t
  • [*] F7WJVMRV tests/input-types: split out scminputs into individual tests
  • [*] 4Y3LBQYI Use system-features from the Nix conf in the default machine file
  • [*] DNOLOMX7 hydra-send-stats: add a failing test asserting it can run

Change contents

  • edit in src/Makefile.PL at line 3
    [27.126]
    [27.126]
    use strict;
    use warnings;
  • edit in src/lib/Hydra/Config.pm at line 3
    [28.117]
    [22.0]
    use strict;
    use warnings;
  • edit in src/lib/Hydra/Event.pm at line 4
    [29.2280]
    [29.2280]
    use warnings;
  • edit in src/lib/Hydra/Helper/AddBuilds.pm at line 4
    [30.2711]
    [31.0]
    use warnings;
  • edit in src/lib/Hydra/Helper/CatalystUtils.pm at line 5
    [32.3521]
    [32.3521]
    use warnings;
  • edit in src/lib/Hydra/Helper/Email.pm at line 4
    [33.180]
    [34.0]
    use warnings;
  • edit in src/lib/Hydra/Helper/Escape.pm at line 4
    [35.46]
    [35.46]
    use warnings;
  • edit in src/lib/Hydra/Helper/Nix.pm at line 4
    [36.486]
    [37.113]
    use warnings;
  • edit in src/lib/Hydra/Model/DB.pm at line 4
    [27.2742]
    [27.2742]
    use warnings;
  • edit in src/lib/Hydra/Plugin/BazaarInput.pm at line 4
    [38.2185]
    [38.2185]
    use warnings;
  • edit in src/lib/Hydra/Plugin/BitBucketPulls.pm at line 4
    [7.54]
    [7.54]
    use warnings;
  • edit in src/lib/Hydra/Plugin/BitBucketStatus.pm at line 4
    [5.55]
    [5.55]
    use warnings;
  • edit in src/lib/Hydra/Plugin/CircleCINotification.pm at line 4
    [3.60]
    [3.60]
    use warnings;
  • edit in src/lib/Hydra/Plugin/CompressLog.pm at line 4
    [39.443]
    [39.443]
    use warnings;
  • edit in src/lib/Hydra/Plugin/CoverityScan.pm at line 4
    [40.52]
    [40.74]
    use warnings;
  • edit in src/lib/Hydra/Plugin/DarcsInput.pm at line 4
    [41.50]
    [41.50]
    use warnings;
  • edit in src/lib/Hydra/Plugin/DeclarativeJobsets.pm at line 4
    [42.58]
    [42.58]
    use warnings;
  • edit in src/lib/Hydra/Plugin/EmailNotification.pm at line 5
    [43.77]
    [44.0]
    use warnings;
  • edit in src/lib/Hydra/Plugin/GitInput.pm at line 4
    [38.4924]
    [38.4924]
    use warnings;
  • edit in src/lib/Hydra/Plugin/GiteaStatus.pm at line 4
    [13.1193]
    [13.1193]
    use warnings;
  • edit in src/lib/Hydra/Plugin/GithubPulls.pm at line 4
    [4.51]
    [4.51]
    use warnings;
  • edit in src/lib/Hydra/Plugin/GithubRefs.pm at line 4
    [12.50]
    [12.50]
    use warnings;
  • edit in src/lib/Hydra/Plugin/GithubStatus.pm at line 4
    [45.109]
    [45.109]
    use warnings;
  • edit in src/lib/Hydra/Plugin/GitlabPulls.pm at line 18
    [8.448]
    [8.448]
    use warnings;
  • edit in src/lib/Hydra/Plugin/GitlabStatus.pm at line 4
    [46.52]
    [46.52]
    use warnings;
  • edit in src/lib/Hydra/Plugin/HipChatNotification.pm at line 4
    [47.105]
    [47.105]
    use warnings;
  • edit in src/lib/Hydra/Plugin/InfluxDBNotification.pm at line 4
    [48.2679]
    [48.2679]
    use warnings;
  • edit in src/lib/Hydra/Plugin/MercurialInput.pm at line 4
    [38.10738]
    [38.10738]
    use warnings;
  • edit in src/lib/Hydra/Plugin/PathInput.pm at line 4
    [38.13463]
    [38.13463]
    use warnings;
  • edit in src/lib/Hydra/Plugin/RunCommand.pm at line 4
    [6.50]
    [6.50]
    use warnings;
  • edit in src/lib/Hydra/Plugin/S3Backup.pm at line 4
    [49.1754]
    [49.1754]
    use warnings;
  • edit in src/lib/Hydra/Plugin/SlackNotification.pm at line 4
    [50.125]
    [50.125]
    use warnings;
  • edit in src/lib/Hydra/Plugin/SoTest.pm at line 4
    [11.46]
    [11.46]
    use warnings;
  • edit in src/lib/Hydra/Plugin/SubversionInput.pm at line 4
    [38.15957]
    [38.15957]
    use warnings;
  • edit in src/lib/Hydra/Plugin.pm at line 4
    [44.287]
    [43.5934]
    use warnings;
  • edit in src/lib/Hydra/View/JSON.pm at line 2
    [51.446]
    [51.446]
    use strict;
    use warnings;
  • edit in src/lib/Hydra/View/NARInfo.pm at line 3
    [25.701]
    [25.742]
    use strict;
    use warnings;
  • edit in src/lib/Hydra/View/NARInfo.pm at line 12
    [2.117][2.117:129]()
    use strict;
  • edit in src/lib/Hydra/View/NixClosure.pm at line 4
    [36.769]
    [36.769]
    use warnings;
  • edit in src/lib/Hydra/View/NixExprs.pm at line 4
    [52.426]
    [52.426]
    use warnings;
  • edit in src/lib/Hydra/View/NixLog.pm at line 4
    [53.570]
    [53.570]
    use warnings;
  • edit in src/lib/Hydra/View/NixManifest.pm at line 4
    [54.343]
    [54.343]
    use warnings;
  • edit in src/lib/Hydra/View/NixNAR.pm at line 4
    [55.527]
    [55.527]
    use warnings;
  • edit in src/lib/Hydra/View/TT.pm at line 4
    [27.6836]
    [27.6836]
    use warnings;
  • edit in src/script/hydra-backfill-ids at line 4
    [10.63]
    [10.63]
    use warnings;
  • edit in src/script/hydra-create-user at line 4
    [56.479]
    [56.479]
    use warnings;
  • edit in src/script/hydra-dev-server at line 3
    [9.176]
    [9.176]
    use strict;
    use warnings;
  • edit in src/script/hydra-eval-jobset at line 4
    [57.1346]
    [31.141]
    use warnings;
  • edit in src/script/hydra-init at line 4
    [58.2694]
    [58.2694]
    use warnings;
  • edit in src/script/hydra-notify at line 4
    [59.3043]
    [59.3043]
    use warnings;
  • edit in src/script/hydra-s3-backup-collect-garbage at line 4
    [49.7635]
    [49.7635]
    use warnings;
  • edit in src/script/hydra-send-stats at line 4
    [60.484]
    [60.484]
    use warnings;
  • edit in src/script/hydra-server at line 3
    [27.16566]
    [61.455]
    use strict;
    use warnings;
  • edit in src/script/hydra-update-gc-roots at line 4
    [62.528]
    [62.528]
    use warnings;
  • edit in src/sql/update-dbix.pl at line 2
    [64.9641]
    [64.9641]
    use strict;
    use warnings;
  • edit in t/Config/hydra-notify.t at line 2
    [24.1803]
    [24.1803]
    use warnings;
  • edit in t/Config/include.t at line 2
    [23.14]
    [23.14]
    use warnings;
  • edit in t/Config/statsd.t at line 2
    [65.1019]
    [65.1019]
    use warnings;
  • edit in t/Controller/Build/evals.t at line 2
    [20.33]
    [20.33]
    use warnings;
  • edit in t/Controller/Jobset/channel.t at line 3
    [66.539]
    [66.539]
    use warnings;
  • edit in t/Controller/Jobset/evals.t at line 2
    [20.1096]
    [20.1096]
    use warnings;
  • edit in t/Controller/Jobset/http.t at line 3
    [17.45]
    [17.45]
    use warnings;
  • edit in t/Controller/Jobset/type-constraints.t at line 2
    [21.14]
    [21.14]
    use warnings;
  • edit in t/Controller/Root/evals.t at line 2
    [20.2153]
    [20.2153]
    use warnings;
  • edit in t/Controller/metrics.t at line 3
    [19.1030]
    [19.1030]
    use warnings;
  • edit in t/Controller/projects.t at line 3
    [16.45]
    [16.45]
    use warnings;
  • edit in t/Event/BuildFinished.t at line 2
    [67.1698]
    [67.1698]
    use warnings;
  • edit in t/Event/BuildStarted.t at line 2
    [68.619]
    [68.619]
    use warnings;
  • edit in t/Event/StepFinished.t at line 2
    [69.843]
    [69.843]
    use warnings;
  • edit in t/Event.t at line 2
    [29.2983]
    [29.2983]
    use warnings;
  • edit in t/Helper/escape.t at line 2
    [35.1014]
    [35.1014]
    use warnings;
  • edit in t/PostgresListener.t at line 2
    [70.2164]
    [70.2164]
    use warnings;
  • edit in t/Schema/Users.t at line 2
    [71.928]
    [71.928]
    use warnings;
  • edit in t/api-test.t at line 2
    [18.12]
    [18.12]
    use warnings;
  • edit in t/build-products.t at line 2
    [73.851]
    [73.934]
    use warnings;
  • edit in t/evaluate-basic.t at line 3
    [74.45]
    [74.54]
    use warnings;
  • edit in t/evaluate-dependent-jobsets.t at line 2
    [75.14]
    [75.23]
    use warnings;
  • edit in t/input-types/bzr-checkout.t at line 2
    [76.52]
    [76.61]
    use warnings;
  • edit in t/input-types/bzr.t at line 2
    [76.601]
    [76.610]
    use warnings;
  • edit in t/input-types/darcs.t at line 2
    [76.1101]
    [76.1110]
    use warnings;
  • edit in t/input-types/deepgit.t at line 2
    [76.1613]
    [76.1622]
    use warnings;
  • edit in t/input-types/git-rev.t at line 2
    [76.2157]
    [76.2166]
    use warnings;
  • edit in t/input-types/git.t at line 2
    [76.2735]
    [76.2744]
    use warnings;
  • edit in t/input-types/hg.t at line 2
    [76.3235]
    [76.3244]
    use warnings;
  • edit in t/input-types/svn-checkout.t at line 2
    [76.3729]
    [76.3738]
    use warnings;
  • edit in t/input-types/svn.t at line 2
    [76.4278]
    [76.4287]
    use warnings;
  • edit in t/lib/Setup.pm at line 4
    [73.547]
    [73.547]
    use warnings;
  • edit in t/queue-runner/default-machine-file.t at line 3
    [77.183]
    [77.183]
    use warnings;
  • edit in t/s3-backup-test.pl at line 2
    [49.9785]
    [49.9785]
    use warnings;
  • edit in t/scripts/hydra-create-user.t at line 3
    [14.1610]
    [14.1610]
    use warnings;
  • edit in t/scripts/hydra-init.t at line 3
    [15.398]
    [15.398]
    use warnings;
  • edit in t/scripts/hydra-send-stats.t at line 3
    [78.342]
    [78.342]
    use warnings;
  • edit in t/setup-notifications-jobset.pl at line 1
    [48.6878]
    [48.6879]
    use strict;
    use warnings;